Re: MS Windows Frame Maximize in .emacs (again)

[Juanma Barranquero <lekktu@gmail.com>]

I've been testing Lennart's patch for the maximizing problems on
Windows for about a month with no glitch whatsoever.

Of the two components of Lennart's patch, the first one was decided it
would be better fixed when adding support for fractional heights:

> --- src/w32fns.c        3 Jan 2005 22:53:30 -0000       1.246
> +++ src/w32fns.c        9 Jun 2005 08:17:43 -0000
> @@ -3649,10 +3649,9 @@
>                    and Y positions as well.  */
> 
> -               lppos->cx -= wdiff;
> -               lppos->cy -= hdiff;
> -
>                 if (wp.showCmd != SW_SHOWMAXIMIZED
>                     && (lppos->flags & SWP_NOMOVE) == 0)
>                   {
> +                    lppos->cx -= wdiff;
> +                    lppos->cy -= hdiff;
>                     if (lppos->x != wr.left || lppos->y != wr.top)
>                       {

However, this part of the change shouldn't be dependant on that, should it?

> --- src/w32term.c       26 Mar 2005 00:19:53 -0000      1.224
> +++ src/w32term.c       9 Jun 2005 08:20:38 -0000
> @@ -3836,7 +3836,8 @@
>               area of the parent window now exposed will be refreshed.  */
>            my_show_window (f, hwnd, SW_HIDE);
> -          MoveWindow (hwnd, sb_left + VERTICAL_SCROLL_BAR_WIDTH_TRIM,
> -                     top, sb_width - VERTICAL_SCROLL_BAR_WIDTH_TRIM * 2,
> -                     max (height, 1), TRUE);
> +          if (!IsZoomed (hwnd))
> +              MoveWindow (hwnd, sb_left + VERTICAL_SCROLL_BAR_WIDTH_TRIM,
> +                          top, sb_width - VERTICAL_SCROLL_BAR_WIDTH_TRIM * 2,
> +                          max (height, 1), TRUE);
>            if (pfnSetScrollInfo)
>              {
> 

I mean, we shouldn't be allowing to move a zoomed window. I propose we
install this part (which can reasonably be supposed to introduce no
instability, it's just skipping a MoveWindow call).

-- 
                    /L/e/k/t/u