From: Juanma Barranquero <lekktu@gmail.com>
Subject: Re: A few issues with thumbs.el
Date: Thu, 26 May 2005 20:22:35 +0200 [thread overview]
Message-ID: <f7ccd24b0505261122598a91c0@mail.gmail.com> (raw)
In-Reply-To: <87vf56q6fk.fsf-monnier+emacs@gnu.org>
> Oh, right. So the docstring should be fixed to make it clear that the
> argument should be an *absolute* file name.
Uh? convert-standard-filename works right with non-absolute paths:
(convert-standard-filename "file/test:.dat") => "file\\test!.dat"
It just handles an initial "X:" differently (on Windows):
(convert-standard-filename "c:file/test:.dat") => "c:file\\test!.dat"
I see nothing wrong with convert-standard-filename or its docstring.
AFAICS, the problem is that convert-standard-filename is intended to
transform a filename into another filename, suitable for the current
filesystem. But what you're trying in the code you proposed is using
convert-standard-filename to build the *name* part of a filename.
There's nothing anywhere that guarantees that a filename (with path
etc) is a valid name for a file. In MS-DOS/Windows you've got the ":",
in VMS the brackets, etc. When you concatenate thumbs-thumbsdir with
the output of convert-standard-filename, the result can perfectly be a
non-valid filename.
So you'll have to use convert-standard-filename, and then filter its
output to remove potentially dangerous characters, or, as I did in my
example, use convert-standard-filename as the last pass:
(convert-standard-filename (concat thumbs-thumbsdir "/"
(subst-char-in-string [etc...])
I don't think the trouble is worth the tiny benefit that the filename
of the cached thumbnail is user-friendly on debugging. If someone has
to debug it he can modify thumbs-thumbname easily enough.
--
/L/e/k/t/u
next prev parent reply other threads:[~2005-05-26 18:22 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-25 15:18 A few issues with thumbs.el Juanma Barranquero
2005-05-25 22:24 ` Stefan Monnier
2005-05-26 0:40 ` Juanma Barranquero
2005-05-26 3:01 ` Stefan Monnier
2005-05-26 8:17 ` Juanma Barranquero
2005-05-26 14:03 ` Stefan Monnier
2005-05-26 9:37 ` Juanma Barranquero
2005-05-26 14:02 ` Stefan Monnier
2005-05-26 14:19 ` Juanma Barranquero
2005-05-26 16:55 ` Stefan Monnier
2005-05-26 18:22 ` Juanma Barranquero [this message]
2005-05-26 19:24 ` Stefan Monnier
2005-05-26 22:49 ` Juanma Barranquero
2005-05-26 23:05 ` Stefan Monnier
2005-05-27 7:45 ` Juanma Barranquero
2005-05-27 14:19 ` Richard Stallman
2005-05-27 14:45 ` Juri Linkov
2005-05-28 11:53 ` Richard Stallman
2005-05-28 18:00 ` Juanma Barranquero
2005-05-28 21:03 ` Robert J. Chassell
2005-05-29 2:48 ` Juanma Barranquero
2005-05-29 20:27 ` Robert J. Chassell
2005-05-29 21:48 ` Juanma Barranquero
2005-05-30 0:42 ` Robert J. Chassell
2005-05-29 12:04 ` Richard Stallman
2005-05-29 15:08 ` Juanma Barranquero
2005-05-30 10:03 ` Juanma Barranquero
2005-05-30 18:57 ` Juri Linkov
2005-05-30 20:29 ` Juanma Barranquero
2005-05-30 20:38 ` David Kastrup
2005-05-30 21:05 ` Stefan Monnier
2005-05-30 21:20 ` Juanma Barranquero
2005-05-31 17:46 ` Richard Stallman
2005-05-31 23:20 ` Juanma Barranquero
2005-06-09 2:00 ` Juanma Barranquero
2005-06-09 13:22 ` Stefan Monnier
2005-06-09 13:35 ` Juanma Barranquero
2005-06-09 14:22 ` Stefan Monnier
2005-06-09 14:44 ` Juanma Barranquero
2005-06-09 15:56 ` Stefan Monnier
2005-06-12 9:13 ` Mathias Dahl
2005-06-12 23:40 ` Juanma Barranquero
2005-06-12 10:45 ` Mathias Dahl
2005-06-12 23:46 ` Juanma Barranquero
2005-06-13 7:12 ` Mathias Dahl
2005-06-13 7:28 ` Juanma Barranquero
2005-06-10 0:14 ` Richard Stallman
2005-06-10 0:38 ` Juanma Barranquero
2005-06-10 12:37 ` Mathias Dahl
2005-06-10 14:27 ` Juanma Barranquero
2005-06-10 15:06 ` Juanma Barranquero
2005-06-12 9:01 ` Mathias Dahl
2005-06-12 10:30 ` Henrik Enberg
2005-06-12 14:02 ` Mathias Dahl
2005-06-12 15:33 ` Paul Pogonyshev
2005-06-13 6:02 ` Juri Linkov
2005-06-13 7:11 ` Mathias Dahl
2005-06-13 7:28 ` Mathias Dahl
2005-06-13 21:48 ` Daniel Brockman
2005-06-14 12:53 ` Mathias Dahl
2005-06-13 8:44 ` Kim F. Storm
2005-06-13 14:21 ` Mathias Dahl
2005-06-13 22:03 ` Daniel Brockman
2005-06-13 15:03 ` Richard Stallman
2005-06-13 16:56 ` Paul Pogonyshev
2005-06-13 23:38 ` Richard Stallman
2005-06-12 18:03 ` Stefan Monnier
2005-06-13 6:01 ` Juri Linkov
2005-06-13 15:02 ` Richard Stallman
2005-05-26 0:48 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b0505261122598a91c0@mail.gmail.com \
--to=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).