From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: Problem with library images on Windows (again) Date: Fri, 20 May 2005 19:57:30 +0200 Message-ID: References: <01c55d0c$Blat.v2.4$8d418800@zahav.net.il> <428DB8F3.3070108@gnu.org> <01c55d4a$Blat.v2.4$8e2e76e0@zahav.net.il> <428E065E.6040307@gnu.org> <01c55d54$Blat.v2.4$04c543c0@zahav.net.il> Reply-To: Juanma Barranquero NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1116612181 27713 80.91.229.2 (20 May 2005 18:03:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 20 May 2005 18:03:01 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 20 20:02:55 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DZBnT-0007Uw-6q for ged-emacs-devel@m.gmane.org; Fri, 20 May 2005 20:00:31 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DZBqM-0006IM-1P for ged-emacs-devel@m.gmane.org; Fri, 20 May 2005 14:03:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DZBnv-0005YR-Ny for emacs-devel@gnu.org; Fri, 20 May 2005 14:01:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DZBnr-0005WA-Lb for emacs-devel@gnu.org; Fri, 20 May 2005 14:00:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DZBnp-0005Sh-SN for emacs-devel@gnu.org; Fri, 20 May 2005 14:00:54 -0400 Original-Received: from [64.233.184.200] (helo=wproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DZBt4-00055s-31 for emacs-devel@gnu.org; Fri, 20 May 2005 14:06:18 -0400 Original-Received: by wproxy.gmail.com with SMTP id 50so1248701wri for ; Fri, 20 May 2005 10:57:30 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=aqWQJdW+jpt6OUFDePii39ENdlWkPVLwvBPgNt+kSEqLbBXzC6Qcbb0yQvVIjGroFsc9ttHMKgWm4rhXh0Uj3e1BQ450bLC0keHV6PfLbyQ5JqMcc8cTFt9QgFZqf+XfJ6nQpuzvBGt9VWtCL01diny8AXduUvaazICdryIwTL8= Original-Received: by 10.54.35.77 with SMTP id i77mr1808142wri; Fri, 20 May 2005 10:57:30 -0700 (PDT) Original-Received: by 10.54.82.6 with HTTP; Fri, 20 May 2005 10:57:30 -0700 (PDT) Original-To: emacs-devel@gnu.org In-Reply-To: Content-Disposition: inline X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37402 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37402 With the single change from #define DEF_IMGLIB_FN(func) FARPROC fn_##func to #define DEF_IMGLIB_FN(func) int (FAR CDECL *fn_##func)() all test images I have do work beautifully. MORE IMPORTANT: two horrible hacks that I added about a year ago (when I first fought this same issue and came to the wrong conclusion) to keep Emacs from crashing CAN BE REMOVED! So I'd say this is probably the right answer. I've commited the changes so people with MinGW builds can test them. If this works for them, today will be a happy day indeed :) /L/e/k/t/u