From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too Date: Sat, 15 Jun 2024 01:44:32 +0300 Message-ID: References: <171823002031.28307.18221225159709452537@vcs2.savannah.gnu.org> <20240612220700.A0F4DC1FB4C@vcs2.savannah.gnu.org> <86h6dwf40q.fsf@mail.linkov.net> <86frtffpdb.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3364"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: emacs-devel@gnu.org To: Eshel Yaron , Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 15 00:45:41 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIFfx-0000dI-9t for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jun 2024 00:45:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIFf0-0001JG-L4; Fri, 14 Jun 2024 18:44:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIFey-0001Ii-U4 for emacs-devel@gnu.org; Fri, 14 Jun 2024 18:44:40 -0400 Original-Received: from wfhigh1-smtp.messagingengine.com ([64.147.123.152]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIFex-00083s-27 for emacs-devel@gnu.org; Fri, 14 Jun 2024 18:44:40 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.west.internal (Postfix) with ESMTP id 9907B18000A9; Fri, 14 Jun 2024 18:44:35 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 14 Jun 2024 18:44:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1718405075; x=1718491475; bh=sRsQVV8pxXzBz4lCUvEqjf9Akf64bxctlnfCyRxy8ZE=; b= TJl4C65xVOy+pG6TF4DxzedxCfKU4MiQeRiy27SWrjedGSrqRLZBxvBDaXAZ24HH 7C3CbW7UAInkLMq4L061gy4Zg0YQ7d7aRayr6CnrQy3IgCvXvlhsLGKb5RQSvGjn M0ZwWrX4NYz4ksGjRILpgGLfsAVK/Wjdcm591gKNAP8zQJjMs3OIc3tzqX6h839G e9LFNyF2K1LsEEXWMJz+500SoiwqQpyewZHpgMfeZW/0wOIn54k5nVEzRgi7eShl vveQDahs+WQ8bJbYrhsTaMyXxrJcYAU5gBv/nvtfJTn/sADA5WJoOssCNlxrZACH DxdKHPEtl1/8axVIZDnjDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1718405075; x= 1718491475; bh=sRsQVV8pxXzBz4lCUvEqjf9Akf64bxctlnfCyRxy8ZE=; b=e nQTRveRMbxxB+ylXX0iaPtyBG7D9XzzpDSaPRJQupXWQ3sMJQtNbk8tmRZ7pt+QV WFGgOr11s+jdYhXhiqFM8Zqo2egwgGu3W2oCSviwDPAXCePpgRKFUpUcyZ+sHaqY YVK0TDKT5e+yAgPoK08g/KQ1ePnrhGUSDE7AB8JN54hssGYmbFe79MLTQ9Kc+zAB wX3Q3dQfvfrPXbJDLZYTKgY5ZZAHmh5uefcqgVpJ7SKH+rVKCkQrofBe/D4oXoPg kV54w/q/KQBcCmF2zhVWB0H4Wyv/qoFPT1fti/N+JK/w9GbPeOm6biqxiLzid4lH MomPlK6GFNtSj5ubBRJWQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedvtddgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Jun 2024 18:44:34 -0400 (EDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=64.147.123.152; envelope-from=dmitry@gutov.dev; helo=wfhigh1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320088 Archived-At: On 14/06/2024 21:04, Eshel Yaron wrote: > Juri Linkov writes: > >>>> Lisp error: (wrong-type-argument number-or-marker-p nil) >>> Hmm that's quite curious... I can reproduce it also without my change >>> in 56537ab0228, FWIW. AFAICT the issue is that icomplete trims the >>> prefix from completion candidates before passing them to >>> completion-lazy-hilit, while completion--hilit-from-re expects the full >>> candidate (prefix included). I'm not deeply familiar with icomplete, >>> but maybe calling completion-lazy-hilit before trimming the candidates >>> as in the diff below should do the trick? >> Thanks, I confirm with this change icomplete doesn't fail anymore. > Thanks for confirming, pushed to master as commit 3b07d330591. Looking good, thank you.