From: Dmitry Gutov <dmitry@gutov.dev>
To: Eshel Yaron <me@eshelyaron.com>, Juri Linkov <juri@linkov.net>
Cc: emacs-devel@gnu.org
Subject: Re: master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too
Date: Sat, 15 Jun 2024 01:44:32 +0300 [thread overview]
Message-ID: <f74855a4-6de7-42f0-8cbd-aa97c9a7ae99@gutov.dev> (raw)
In-Reply-To: <m1plsjtn79.fsf@dazzs-mbp.kpn>
On 14/06/2024 21:04, Eshel Yaron wrote:
> Juri Linkov<juri@linkov.net> writes:
>
>>>> Lisp error: (wrong-type-argument number-or-marker-p nil)
>>> Hmm that's quite curious... I can reproduce it also without my change
>>> in 56537ab0228, FWIW. AFAICT the issue is that icomplete trims the
>>> prefix from completion candidates before passing them to
>>> completion-lazy-hilit, while completion--hilit-from-re expects the full
>>> candidate (prefix included). I'm not deeply familiar with icomplete,
>>> but maybe calling completion-lazy-hilit before trimming the candidates
>>> as in the diff below should do the trick?
>> Thanks, I confirm with this change icomplete doesn't fail anymore.
> Thanks for confirming, pushed to master as commit 3b07d330591.
Looking good, thank you.
next prev parent reply other threads:[~2024-06-14 22:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171823002031.28307.18221225159709452537@vcs2.savannah.gnu.org>
[not found] ` <20240612220700.A0F4DC1FB4C@vcs2.savannah.gnu.org>
2024-06-13 8:20 ` master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too Eshel Yaron
2024-06-13 14:11 ` Dmitry Gutov
2024-06-13 14:51 ` Eshel Yaron
2024-06-14 6:10 ` Juri Linkov
2024-06-14 7:35 ` Eshel Yaron
2024-06-14 16:41 ` Juri Linkov
2024-06-14 18:04 ` Eshel Yaron
2024-06-14 22:44 ` Dmitry Gutov [this message]
2024-06-30 16:29 ` Juri Linkov
2024-06-30 18:14 ` Eshel Yaron
2024-07-01 6:57 ` Juri Linkov
2024-07-01 8:58 ` Eshel Yaron
2024-07-01 16:29 ` Juri Linkov
2024-07-02 11:12 ` Eli Zaretskii
2024-07-02 12:17 ` Eshel Yaron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f74855a4-6de7-42f0-8cbd-aa97c9a7ae99@gutov.dev \
--to=dmitry@gutov.dev \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).