From: Dmitry Gutov <dgutov@yandex.ru>
To: Glenn Morris <rgm@gnu.org>, Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master ed8b4e0: Prevent running vc-tests writing to ~/.bzr.log
Date: Tue, 23 May 2017 00:02:50 +0300 [thread overview]
Message-ID: <f72bc85d-6f3a-94a1-29bd-f33a2574093f@yandex.ru> (raw)
In-Reply-To: <f5lgpo7gxz.fsf@fencepost.gnu.org>
On 5/22/17 11:52 PM, Glenn Morris wrote:
>
>>> This is one big patch.
>
> I don't think adding the same 7 lines to 4 functions is big,
> nor something that should be split into more than one commit.
Rather, it's a chance that might be hard to maintain. I can easily see
myself adding a test or two and forgetting to use Bzr the way you want here.
So I have to wonder whether this change is really necessary, or if it
could be made in a more fool-proof way.
> I think running tests should not interact with HOME at all,
> and certainly should not write there.
> (Perhaps test/Makefile should export a temporary HOME,
> but tests can still be run not via the Makefile.)
Perhaps the tests could use a special proxy script for calling Bzr that
would reside in the test directory, which disables logging somehow.
prev parent reply other threads:[~2017-05-22 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170521000028.30429.38577@vcs0.savannah.gnu.org>
[not found] ` <20170521000029.791B421038@vcs0.savannah.gnu.org>
2017-05-21 7:30 ` [Emacs-diffs] master ed8b4e0: Prevent running vc-tests writing to ~/.bzr.log Dmitry Gutov
2017-05-21 14:49 ` Eli Zaretskii
2017-05-22 20:52 ` Glenn Morris
2017-05-22 21:02 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f72bc85d-6f3a-94a1-29bd-f33a2574093f@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).