From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Bug #25608 and the comment-cache branch Date: Fri, 3 Feb 2017 23:53:31 +0200 Message-ID: References: <20170202202418.GA2505@acm> <9d0b3156-e8b2-c2d8-0d0c-a025861e5e0c@yandex.ru> <20170203164457.GB2250@acm> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1486158834 29929 195.159.176.226 (3 Feb 2017 21:53:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Feb 2017 21:53:54 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 Cc: Eli Zaretskii , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 03 22:53:47 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZlne-0007Z0-F0 for ged-emacs-devel@m.gmane.org; Fri, 03 Feb 2017 22:53:46 +0100 Original-Received: from localhost ([::1]:37021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZlnj-0002O8-TQ for ged-emacs-devel@m.gmane.org; Fri, 03 Feb 2017 16:53:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZlnd-0002Nr-MY for emacs-devel@gnu.org; Fri, 03 Feb 2017 16:53:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZlnc-0003St-Ke for emacs-devel@gnu.org; Fri, 03 Feb 2017 16:53:45 -0500 Original-Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:37021) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZlnY-0003Of-Kb; Fri, 03 Feb 2017 16:53:40 -0500 Original-Received: by mail-wm0-x229.google.com with SMTP id v77so48555744wmv.0; Fri, 03 Feb 2017 13:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aa5sZbg+axRaX+E+xTGa1mOG82S7P1O3XvRG+Xpd58Y=; b=Es8lY/DdGrashGN1mPVPALe0ki5gSSlFi5sR2RLbx7E+I4rjOBImn0trd68VkXRcR7 +YFmrUGTsLjFIrA7iLDj2zo+IDkzvDcJ/1wfZyNIuuX8EuflfziVTEK4tj/c2zh4vJDR kVCAzcEFzAglDoP2S197ncEuIpAgtAO2AM2Isf0JGJNw/2mmXzyfBOw8CfQBEev6oXQu SmPJBrtfJ9nuvMliAVcMBEzrxv1HgAsfEMZPbVydGrs912MZRTh6CyBlg6a2o7r5mL/z tufxV8DfK1HAMjXV0Gffd+BHTwZhKNCx1/ouuH0dPyy5ogHCYVYpjD+5jn6nMwbvd3BI V4tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aa5sZbg+axRaX+E+xTGa1mOG82S7P1O3XvRG+Xpd58Y=; b=jRZ6vD2ccmKjM6wQylkDTpUyf8FUCnWzxNKZ5tbYaJvarnLUWWKKvhzcGz3sYEeiT+ qFjRg6SAIq7csqU4yzk1Hd0lKhehDVpP86v5L8c2GSyBYSuoNTfPHvKJxd49YHjPO4RL iiZSbr2MMZzTt3hA0CFqEbRFTYSCz9L7x31MJVpamgRYn8pC2xARR9V3cVKdmv1Yv/gd sjCZwTHp0Io+9gWlyQ3ZggLF36KtYJUVNmoyNqkSxjFe53Fi/Hvaq/7aJy7dQaFZrBLq PmaLPdT0YsgRDnBfgCvnPQTykqrKH4DSFVm8CtYA6USFvwPFUEA/yLc4na6RQx6k9i7L TFeA== X-Gm-Message-State: AMke39lFNKo6g5w7xZ6VTjQJObyaawk9eyv3qKYc9Xl+6c2bg5d36a4sMvHsS6JanJYtWA== X-Received: by 10.28.65.196 with SMTP id o187mr2970694wma.37.1486158814558; Fri, 03 Feb 2017 13:53:34 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id m29sm47048039wrm.38.2017.02.03.13.53.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Feb 2017 13:53:33 -0800 (PST) In-Reply-To: <20170203164457.GB2250@acm> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211942 Archived-At: On 03.02.2017 18:44, Alan Mackenzie wrote: > Perhaps, for clarity's sake, you could post this alternative patch here, > or if it's big, put it into a scratch branch. Then, at least we'll all > know that we're talking about the same thing. I've already posted the url. The path is in the comments of the bug you're purportedly trying to fix. So here is the message you unlimately ignored: http://lists.gnu.org/archive/html/emacs-devel/2016-12/msg01075.html If the patch is not good enough for some reasons, please post those, with specific examples. And I'm sure we can improve it. > I'm not sure what you want them for. To see how they compare performance-wise, at least. "syntax-ppss cache is slow" was one of the big reasons for introducing the text property cache implemented via text properties, written in C, IIRC. So you should be able to demonstrate this stark difference in performance. > The "alternative patch" didn't > scan comments correctly all the time when I looked at it, just as the > current back_comment doesn't. Please remind us of the specific problems it has. > But, post the patch, remind me precisely > what you want tested, Can you read the message archive (that I've linked to above), or should I copy the past messages here? > and I'll do it. > > Constructive criticism of comment-cache would be most welcome. Just look up the previous threads on the subject. Surely you don't expect people to rehash the arguments time and time again.