From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: xref-query-replace-in-results error message after xref-find-definitions, was: Re: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful
Date: Tue, 11 Oct 2022 17:55:02 +0300 [thread overview]
Message-ID: <f549dcd6-62a6-ab96-46ad-4bf20f7e3395@yandex.ru> (raw)
In-Reply-To: <83sfjuecyw.fsf@gnu.org>
On 11.10.2022 15:55, Eli Zaretskii wrote:
>> But we can try to be helpful by offering an alternative:
>>
>> Cannot replace in this search; to rename a symbol, invoke
>> \\[xref-find-references] first
>
> But then we'd need to name the other 2 commands as well, to be
> accurate, yes?
If our conclusion is that the error is due to user trying to rename a
symbol (and failing because xref-find-definitions's results don't allow
them to do so), then xref-find-references is exactly the right suggestion.
Users who try to replace in regexp search matches don't see the error.
>>>> Perhaps I should remind that xref-find-definitions is still the main
>>>> exception -- where this command doesn't work.
>>>
>>> But not the only one?
>>
>> The only known one, so far.
>
> So maybe just saying
>
> Cannot do global replacement using results of \\[xref-find-definitions]
>
> should be okay?
Isn't it almost the same as I suggested upthread? Except I suggested
"this search" instead of naming the specific command.
Do you think naming it will be helpful enough to sacrifice the 10%
accuracy of the message? I suppose someone might have indeed forgotten
that they did the search using xref-find-definitions.
>> That would mean that one 'r' can work in lsp-mode's
>> xref-find-definitions results (they define a bunch of custom commands
>> like lsp-find-definition and lsp-find-declaration, but that probably
>> doesn't matter). Not sure if we should do something about that.
>
> If 'r' happens to work in that case, we don't have to worry about the
> error message, right?
That's correct, but having the command succeed might be a problem by
itself, couldn't it? It will rename the definitions (and/or
declarations), but not other occurrences.
If we go in from this direction, we can have
xref-show-definitions-buffer (the default
xref-show-definitions-function) ensure that the binding for 'r' is set
to some command that always reports an error (like 'cannot replace in
definitions'), or is unbound.
This would do nothing for custom values of
xref-show-definitions-function, but should remove most of the confusion
with default configuration. And some non-default ones as well (lsp-mode
doesn't change the value of xref-show-definitions-function).
If the docstring of xref-show-definitions-function looks okay to you, we
can use its vocabulary.
Cannot replace in definition search results
should cover xref-find-definitions, lsp-find-definition and
lsp-find-declaration. Wouldn't help with lsp-find-implementation, though
(its results are also questionable WRT renaming because they don't
include all references either), but it won't make it worse.
next prev parent reply other threads:[~2022-10-11 14:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m28rm2oiiy.fsf@Mini.fritz.box>
[not found] ` <83h70qhez0.fsf@gnu.org>
[not found] ` <m28rm2u0ga.fsf@Mini.fritz.box>
[not found] ` <83edvuhaby.fsf@gnu.org>
[not found] ` <m2zgeisg1u.fsf@Mini.fritz.box>
[not found] ` <831qruh67o.fsf@gnu.org>
[not found] ` <m2o7uysdfl.fsf@Mini.fritz.box>
[not found] ` <83y1u2foli.fsf@gnu.org>
[not found] ` <jwvh70q9whx.fsf-monnier+emacs@gnu.org>
[not found] ` <m235cas1w2.fsf@Mini.fritz.box>
[not found] ` <m2y1u2qm9s.fsf@Mini.fritz.box>
[not found] ` <jwvfsg996o3.fsf-monnier+emacs@gnu.org>
[not found] ` <m2o7uxqvlx.fsf@Mini.fritz.box>
[not found] ` <83zgehe6iq.fsf@gnu.org>
[not found] ` <95113379-99d8-eba4-f980-a7fca11430d5@yandex.ru>
[not found] ` <834jwfmn5a.fsf@gnu.org>
[not found] ` <f3967957-a4b2-8a9b-ae9c-b18b59370541@yandex.ru>
[not found] ` <838rlohzeo.fsf@gnu.org>
[not found] ` <d07f076f-21bf-9ab5-5ebe-1bf3d9fb7df1@yandex.ru>
[not found] ` <83mta2g91p.fsf@gnu.org>
2022-10-11 11:36 ` xref-query-replace-in-results error message after xref-find-definitions, was: Re: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful Dmitry Gutov
2022-10-11 11:51 ` Eli Zaretskii
2022-10-11 12:10 ` Dmitry Gutov
2022-10-11 12:17 ` Eli Zaretskii
2022-10-11 12:44 ` Dmitry Gutov
2022-10-11 12:55 ` Eli Zaretskii
2022-10-11 14:55 ` Dmitry Gutov [this message]
2022-10-11 16:01 ` Eli Zaretskii
2022-10-11 16:41 ` Dmitry Gutov
2022-10-11 16:50 ` Eli Zaretskii
2022-10-11 20:31 ` Dmitry Gutov
2022-10-12 5:17 ` Eli Zaretskii
2022-10-12 10:06 ` John Yates
2022-10-12 10:17 ` Eli Zaretskii
[not found] ` <CAJnXXogKsM=gMTFi2NivDMHW4A3EBtBtsNDBV3o5vcu2xXfuvw@mail.gmail.com>
2022-10-12 13:21 ` Eli Zaretskii
2022-10-12 16:12 ` John Yates
2022-10-12 13:47 ` Dmitry Gutov
2022-10-12 14:05 ` Eli Zaretskii
2022-10-11 14:04 ` Stefan Monnier
2022-10-11 14:07 ` Stefan Monnier
2022-10-11 15:07 ` Dmitry Gutov
2022-10-11 15:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f549dcd6-62a6-ab96-46ad-4bf20f7e3395@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).