unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: eskinjp@gmail.com, emacs-devel@gnu.org
Subject: Re: [Patch] Add project.el command to replace symbol at point throughout project
Date: Thu, 13 Jan 2022 03:19:12 +0200	[thread overview]
Message-ID: <f4b8783d-803e-7d74-a0f6-d6a1fd127c71@yandex.ru> (raw)
In-Reply-To: <83zgo15dhp.fsf@gnu.org>

On 12.01.2022 14:45, Eli Zaretskii wrote:
>> Cc: emacs-devel@gnu.org
>> From: Dmitry Gutov <dgutov@yandex.ru>
>> Date: Wed, 12 Jan 2022 05:46:53 +0200
>>
>> On 11.01.2022 15:10, Eli Zaretskii wrote:
>>> I think we should have such a command outside project.el as well.
>>> Would it be possible to base it on xref.el and related facilities, so
>>> that, for example, one could rename a symbol in all the files
>>> mentioned in TAGS table?
>>
>> We could add a command like xref-find-references-and-replace.
> 
> That's what I had in mind.  Perhaps it would even make sense to have
> that command automatically adjust itself to a project, when invoked in
> the context of a project?

The conceptual problem with that is we have a number of commands which 
produce a list of matches in an Xref buffer:

xref-find-references,
xref-find-apropos,
project-find-regexp,
project-or-external-find-regexp

They're all fairly, so I won't think there's a change of implementing 
any meaningful automatic switching based on context.

Do we create the -and-replace counterpart only for xref-find-references?

There's also dired-do-find-regexp for which we have added said 
counterpart already (dired-do-find-regexp-and-replace), but that was 
primarily for backward compatibility of the UI.

>> Or you can do a search with M-? and then press 'r'. Have you tried that?
> 
> At some point.  But I think someone who wants refactoring might have
> trouble discovering that, and a separate command will make that
> easier.

I rather remember the old recommendation to 'M-x find-grep-dired' 
followed by '% m RET .*' and 'M-x dired-do-query-replace-regexp', when 
one wanted to replace across the project. I think we're rather spoiled 
these days by comparison.

Anyway, if you're sure adding xref-find-references-and-replace will 
help, I've got no problem with that.



  reply	other threads:[~2022-01-13  1:19 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11  7:45 [Patch] Add project.el command to replace symbol at point throughout project Jon Eskin
2022-01-11  7:51 ` Manuel Uberti
2022-01-11  9:50   ` Jon Eskin
2022-01-12  3:43     ` Dmitry Gutov
2022-01-12  9:42       ` Jon Eskin
2022-01-13  1:03         ` Dmitry Gutov
2022-01-13  9:57           ` Jon Eskin
2022-01-14  2:39             ` Dmitry Gutov
2022-01-11 13:10 ` Eli Zaretskii
2022-01-11 15:15   ` Daniel Martín
2022-01-11 17:17     ` Eli Zaretskii
2022-01-12  3:46   ` Dmitry Gutov
2022-01-12 12:45     ` Eli Zaretskii
2022-01-13  1:19       ` Dmitry Gutov [this message]
2022-01-13  8:25         ` Eli Zaretskii
2022-01-14  2:43           ` Dmitry Gutov
2022-01-14  7:46             ` Eli Zaretskii
2022-01-14 10:26             ` Jon Eskin
2022-01-14 20:28               ` Dmitry Gutov
2022-01-15  9:55                 ` Jon Eskin
2022-01-15 18:30                   ` Juri Linkov
2022-01-16  3:02                     ` Dmitry Gutov
2022-01-16 17:58                       ` Juri Linkov
2022-01-17  0:19                         ` Dmitry Gutov
2022-01-17  1:15                           ` Dmitry Gutov
2022-01-17  8:17                             ` Juri Linkov
2022-01-21  3:06                               ` Dmitry Gutov
2022-01-31 18:25                                 ` Juri Linkov
2022-02-01  2:10                                   ` Dmitry Gutov
2022-02-01 20:09                                     ` Juri Linkov
2022-02-01 22:07                                       ` Dmitry Gutov
2022-02-02 19:51                                         ` Juri Linkov
2022-02-02 21:09                                           ` Dmitry Gutov
2022-01-15 18:41                   ` Jon Eskin
2022-01-16 17:55                     ` Juri Linkov
2022-01-17  1:41                   ` Dmitry Gutov
2022-01-17  6:36                     ` Jon Eskin
2022-01-12  3:42 ` Dmitry Gutov
2022-01-12  8:03   ` Jon Eskin
2022-01-12 19:43     ` Dmitry Gutov
2022-01-12 19:56       ` Juri Linkov
2022-01-12 22:12         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4b8783d-803e-7d74-a0f6-d6a1fd127c71@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=eskinjp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).