From: martin rudalics <rudalics@gmx.at>
To: 路客 <luke.yx.lee@gmail.com>
Cc: Juri Linkov <juri@linkov.net>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: [ELPA] Brief v5.90: neighboring window merge on deletion
Date: Mon, 25 Mar 2024 10:40:54 +0100 [thread overview]
Message-ID: <f48aff6f-2873-40f0-91b7-c03eba92f012@gmx.at> (raw)
In-Reply-To: <CAA=xLRNh-iMRJpv5M21ZsubpCzd_7u72XLRpP=opfY-vvi9rkA@mail.gmail.com>
>> This means that buffer overlays with a 'window' property will not work
>> correctly in any of the new ones.
>
> Overlay is a good point, but can be saved before reconstruction and
> restored afterwards in the affected windows. My code try to restore as
> many window properties as possible but the overlay is surely a missed
> one. It will be taken care of in my next release.
The problem is not a new one - it's been present in 'window-state-put'
ever since. It could be easily mitigated with the help of the
'clone-of' window parameter which would have to be processed here in
xdisp.c's load_overlay_strings
Lisp_Object window = Foverlay_get (overlay, Qwindow);
if (WINDOWP (window) && XWINDOW (window) != it->w)
continue;
but I never got around to do that.
>> Moreover, if such windows were stored in Lisp variables, they would be
>> considered dead although they apparently still exist like the ones in
>> the lower part of your frame.
>
> If some code store windows in variables, Emacs native window deletion
> will also make it dead,
Right - but IIUC your code pretends that such a window is alive, yet
with another identity. Still, the same problem exists with
configurations produced by 'window-state-put' and the only remedy I see
is to use the 'clone-of' parameter and maybe some special function like
'windows-equal-p' that would handle it.
> besides, Emacs does not seem to provide a hook
> for deleting windows
'window-state-change-functions' is called in such case but it does not
provide you with a list of the windows that have been deleted. The
Elisp manual says:
Note that window change functions provide no information about which
windows have been deleted since the last time they were run. If
necessary, applications should remember any window showing a specific
buffer in a local variable of that buffer and update it in a function
run by the default values of any of the hooks that are run when a window
buffer change was detected.
We could provide a frame-based 'window-old-window-list' though if you
think it's needed.
> thus codes that store windows in variables should
> always consider the possibility if a window is dead. I know the point
> is that my window reconstruction makes it appear to be still alive. As
> with most other features, it can be configured to default OFF and switch
> back to native Emacs window deletion behavior when causing problems.
> But so far I haven't met such a problem yet. If there is such a case I
> hope the designers who store windows in variables provide hooks so that
> I can add support on this.
martin
next prev parent reply other threads:[~2024-03-25 9:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 11:23 [ELPA] Brief v5.90: neighboring window merge on deletion 路客
2024-03-22 13:22 ` Emanuel Berg
2024-03-23 18:33 ` Juri Linkov
2024-03-24 5:13 ` 路客
2024-03-24 9:54 ` martin rudalics
2024-03-24 15:51 ` 路客
2024-03-25 9:40 ` martin rudalics [this message]
2024-03-26 2:31 ` 路客
2024-03-26 9:57 ` martin rudalics
2024-03-26 12:51 ` Eli Zaretskii
2024-03-27 7:35 ` martin rudalics
-- strict thread matches above, loose matches on Subject: below --
2024-03-24 3:25 路客
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f48aff6f-2873-40f0-91b7-c03eba92f012@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=luke.yx.lee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).