From: Trevor Spiteri <tspiteri@ieee.org>
To: emacs-devel@gnu.org
Subject: Re: patch for bug#34068 on emacs-26 branch
Date: Mon, 14 Jan 2019 23:17:13 +0100 [thread overview]
Message-ID: <f420c99a-7452-f223-5adc-58705cc757fd@ieee.org> (raw)
In-Reply-To: <b1167404-4a68-03f8-6368-e2e7fd1fc0eb@ieee.org>
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
> This is a patch for bug#34068, which I think was introduced in commit
> 644cdd1aa0. The patch is against the emacs-26 branch.
>
> Regards.
>
> Trevor Spiteri
Ugh, Thunderbird mangled my patch. Here I go again:
diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
index df8cb3da7e..08a5db25ab 100644
--- a/lisp/progmodes/grep.el
+++ b/lisp/progmodes/grep.el
@@ -389,7 +389,7 @@ grep-regexp-alist
(when grep-highlight-matches
(let* ((beg (match-end 0))
(end (save-excursion (goto-char beg) (line-end-position)))
- (mbeg (text-property-any beg end 'font-lock-face 'grep-match-face)))
+ (mbeg (text-property-any beg end 'font-lock-face grep-match-face)))
(when mbeg
(- mbeg beg)))))
.
@@ -397,7 +397,7 @@ grep-regexp-alist
(when grep-highlight-matches
(let* ((beg (match-end 0))
(end (save-excursion (goto-char beg) (line-end-position)))
- (mbeg (text-property-any beg end 'font-lock-face 'grep-match-face))
+ (mbeg (text-property-any beg end 'font-lock-face grep-match-face))
(mend (and mbeg (next-single-property-change mbeg 'font-lock-face nil end))))
(when mend
(- mend beg))))))
[-- Attachment #2: Type: text/html, Size: 1653 bytes --]
prev parent reply other threads:[~2019-01-14 22:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 22:10 patch for bug#34068 on emacs-26 branch Trevor Spiteri
2019-01-14 22:17 ` Trevor Spiteri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f420c99a-7452-f223-5adc-58705cc757fd@ieee.org \
--to=tspiteri@ieee.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).