unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Justin Burkett <justin@burkett.cc>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Patch for fit-window-to-buffer
Date: Thu, 5 Mar 2020 10:12:57 +0100	[thread overview]
Message-ID: <f4164777-3f78-4f23-e8d8-03f9241eb0a6@gmx.at> (raw)
In-Reply-To: <CAF5dqNLUQp0jpXKVBH7nhSzGn0LcKowRfWON73WGNvx+XPERag@mail.gmail.com>

 > I think the (point-max) is unnecessary here actually. According to the
 > docstring for window-text-pixel-size, nil should work here, no?

It should work.

 >> Finally, the (frame-pixel-width) argument looks fishy too - it should
 >> probably be (frame-pixel-width (window-frame window)).  Can you verify
 >> that as well?
 >
 > Yes, I made that change and the previous one in the patch attached. Both
 > work with my test case.

Applied to Emacs-27 (without asking for Eli's permission because the
bugs were all to obvious).

Thanks, martin



  reply	other threads:[~2020-03-05  9:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  3:16 Patch for fit-window-to-buffer Justin Burkett
2020-03-04 17:31 ` martin rudalics
2020-03-04 20:49   ` Justin Burkett
2020-03-05  9:12     ` martin rudalics [this message]
2020-03-05  9:39       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4164777-3f78-4f23-e8d8-03f9241eb0a6@gmx.at \
    --to=rudalics@gmx.at \
    --cc=emacs-devel@gnu.org \
    --cc=justin@burkett.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).