From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: marginalia Date: Wed, 2 Jun 2021 17:07:54 +0200 Message-ID: References: <5146817f-4b3f-8a7e-edce-f34a9a10f805@daniel-mendler.de> <871r9qk9el.fsf@mail.linkov.net> <92c218f7-1168-a7f4-3861-04f64a37eec9@daniel-mendler.de> <874kehcnl6.fsf@mail.linkov.net> <87pmx42ukl.fsf@subst.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18299"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: "Jens C. Jensen" , Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 02 17:09:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loSUz-0004ZB-3p for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 17:09:37 +0200 Original-Received: from localhost ([::1]:55842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loSUx-0006TO-VT for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 11:09:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loSTi-0003vZ-9a for emacs-devel@gnu.org; Wed, 02 Jun 2021 11:08:18 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:44235 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loSTf-0003BT-Pt for emacs-devel@gnu.org; Wed, 02 Jun 2021 11:08:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=v3mI4voRoXBypB0ezxPRw/VFnrblyElxHl9gb6QdRnM=; b=kd4KFA11A5T02QFHWoM9htxpdQ R7TnHm62z5RF7k776RSKc7pDeHCKG1OcmIc8q6NcFgFQK+RsjJ0fnqYAUcodUcisZdnt8tNr67gXe ZxHCsLMm8uqyAKcyVuYbRFYQL9fXxhSKOqb07ijIg/1srHjfGIVzaPOcEm97LW9X2f9U=; In-Reply-To: <87pmx42ukl.fsf@subst.net> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270298 Archived-At: On 6/2/21 4:46 PM, Jens C. Jensen wrote: > I ended up with something like: > #+begin_src emacs-lisp > (cond > ((commandp sym) 'command) > ((macrop sym) 'macro) > ((functionp sym) 'function) > ((booleanp sym) 'boolean) > ((keywordp sym) 'keyword) > ((keymapp (symbol-value sym)) 'keymap) > ((facep sym) 'face) > ((boundp sym) 'variable) > ((symbolp sym) 'symbol)) > #+end_src > > It has worked fine for my use-case thus far, but is neither complete nor robust enough for documentation, as Daniel pointed out emacs-lisp is a Lisp-2 - the above code completely misses this point. Yes exactly, such a classifier should return a list of types. The Marginalia symbol annotator gets this right and annotates each symbol with multiple characters. I like this annotation functionality when doing Elisp hacking. Also `marginalia-annotate-variable` is quite useful. Jens, where are you using this classifier in your configuration? Daniel