From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.devel Subject: Re: contributing to Emacs Date: Sun, 18 Jun 2023 13:57:54 +0300 Message-ID: References: <83v8fnslfz.fsf@gnu.org> <87v8fnh1h2.fsf@web.de> <83mt0zs9rc.fsf@gnu.org> <0a968a4e1b267c0f15dd237e6ea12a709fc06d5e.camel@yandex.ru> <838rcisj7o.fsf@gnu.org> <6537fa5fa5c1fe8437ed99ee0988e35895f5a54b.camel@yandex.ru> <8423a35750d8d8e0437c7708f6b4d0bbdfdb7fe0.camel@yandex.ru> <87wn01drad.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29978"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.48.2 Cc: eliz@gnu.org, luangruo@yahoo.com, emacs-devel@gnu.org To: "Dr. Arne Babenhauserheide" , "Alfred M. Szmidt" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 18 12:58:26 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAq6z-0007at-VQ for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Jun 2023 12:58:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAq6d-0002vC-08; Sun, 18 Jun 2023 06:58:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAq6a-0002ul-TL for emacs-devel@gnu.org; Sun, 18 Jun 2023 06:58:00 -0400 Original-Received: from forward501c.mail.yandex.net ([178.154.239.209]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAq6Y-00025g-TS; Sun, 18 Jun 2023 06:58:00 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:810d:0:640:1587:0]) by forward501c.mail.yandex.net (Yandex) with ESMTP id 124425E84A; Sun, 18 Jun 2023 13:57:56 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id svc8qxUDYqM0-UP6XBo8H; Sun, 18 Jun 2023 13:57:55 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1687085875; bh=NCaO5qljBeiwr2mAZ5S1LOeg4xkrtfZbmRYC0VKkaqI=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=PyHiXdvcMuIdBAXQHULNLnB93wKNENzOsnzoZ63QHhKEY8WGSqGsNtNb4KhRgOEoX +AyohsP5YOldJsM9mDYXsi/QjrewwBHorAvqRnDXB8a52EiX235kh5lYqiPmCH2RdH DNYMIaKaZ2gd6vS7GKndH8j8CSAYfy6iqlXhRpxw= Authentication-Results: mail-nwsmtp-smtp-production-main-22.iva.yp-c.yandex.net; dkim=pass header.i=@yandex.ru In-Reply-To: <87wn01drad.fsf@web.de> Received-SPF: pass client-ip=178.154.239.209; envelope-from=hi-angel@yandex.ru; helo=forward501c.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306962 Archived-At: On Sun, 2023-06-18 at 11:26 +0200, Dr. Arne Babenhauserheide wrote: > ------ ------ ------ ------ ------ ------ > > To contribute patches please make them easy to use for maintainers: > > - patch format: Send patches with explanation in a single email as MIME > =C2=A0 attachment or inline. Create your patches with diff -u (with the o= ld > =C2=A0 version as first version) or with ~git format-patch master~ (for > =C2=A0 commited changes) or ~git diff~ (for uncommited changes). While at it, I think it may be worth to improve this a bit as well. I presu= me the "old version as first version" refers to Emacs before it started using = git? I think there's no point to mention it because if you contribute to a proje= ct, you always need the very latest code, in which case there's git support. So= I think `diff -u` mention may be removed. Perhaps: - patch format: Send patches with explanation in a single email as MIME= attachment or inline. Create your patches with with ~git format-patch master~ (for = commited changes) or ~git diff~ (for uncommited changes). And I'm also wondering if there's any point mentioning `git diff` as well. = I think it's reasonable to expect most people know how to use git and they probably= have made commits, so the `git format-patch` is the way to go. But even is a person is complete newbie, having to `git-diff` and then to w= rite commit message manually is uncomfortable, because you have to write the mes= sage anew every time you address a review. It may be better to just suggest to do `gi= t format-patch` instead.