From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 4) Date: Sun, 9 May 2021 20:50:04 +0200 Message-ID: References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> <87sg2ymq6j.fsf@mail.linkov.net> <78bb0663-80ef-a68f-c582-cd7cc0436c29@daniel-mendler.de> <069cec7d-db2c-8628-69fb-a2aee4ee5074@daniel-mendler.de> <6ac36d0f-bf5b-2124-1f70-69644bb40218@daniel-mendler.de> <871rafrdny.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15423"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , "emacs-devel@gnu.org" , Stefan Monnier , Dmitry Gutov To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 09 20:51:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfoWW-0003u2-2G for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 20:51:28 +0200 Original-Received: from localhost ([::1]:50430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfoWV-0007MT-5t for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 14:51:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfoVa-0006G9-4q for emacs-devel@gnu.org; Sun, 09 May 2021 14:50:30 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:52135 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfoVX-0001zJ-Gb for emacs-devel@gnu.org; Sun, 09 May 2021 14:50:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VC75Ct4YTWxGMkOloYkgKyjA/y8A/Qvg5OADbK/+UAU=; b=reB0YZ7XImxp2OmnIfZH/LmFFW +KEBKjnD5jRHhwwap3e/fzQrHJimH+kBPlSm736fA7nNiguAxHGyILdIjiyesf5M5n/kESxwc18kw wPSBNmsXCNlI92sZYy8cPGCyezvGTwIXbWBKxCt2IiQ6/vzsuMwguuq3BliLeNw1+YM8=; In-Reply-To: <871rafrdny.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269091 Archived-At: On 5/9/21 7:59 PM, Juri Linkov wrote: >>> I attached the current set of patches. The last patch >>> "0005-group-function-Implement-generalized-action-argument.patch" >>> implements the generalized action argument. The other patches (1-4) do >>> not differ from the previously sent patches. I send them for completeness. > > Thanks, I tested it with mule--ucs-names-group, and everything works well. So what is the plan regarding the patch? Use the variant which has the action argument (title, transform, sort) or use the variant with the boolean transform argument, which does not allow sorting of the groups? Stefan stated in his mail that letting the UI decide if the groups should be sorted alphabetically is also a possibility. We can implement this proposal by adding a `completions-sort` variable to minibuffer.el, which is respected by the *Completions* buffer. If the variable is non-nil, the groups are sorted alphabetically, otherwise the candidate order determines the order of the groups. Daniel