unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: emacs-24 r116830: Fix bug#16873
       [not found] <E1WRHWl-0006Yn-3N@vcs.savannah.gnu.org>
@ 2014-03-23  0:18 ` Glenn Morris
  2014-03-23  3:31   ` Dmitry Gutov
  0 siblings, 1 reply; 2+ messages in thread
From: Glenn Morris @ 2014-03-23  0:18 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: emacs-devel


This change seems to cause a test failure. See
http://hydra.nixos.org/build/9751908
http://hydra.nixos.org/build/9751908/log/raw

Also, remember that test/ changes also need ChangeLog entries.



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: emacs-24 r116830: Fix bug#16873
  2014-03-23  0:18 ` emacs-24 r116830: Fix bug#16873 Glenn Morris
@ 2014-03-23  3:31   ` Dmitry Gutov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Gutov @ 2014-03-23  3:31 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

On 23.03.2014 02:18, Glenn Morris wrote:
>
> This change seems to cause a test failure. See
> http://hydra.nixos.org/build/9751908
> http://hydra.nixos.org/build/9751908/log/raw

Thanks, should be fixed now. It was due to this kind of buttons being 
rendered with different text in non-graphical mode.

> Also, remember that test/ changes also need ChangeLog entries.

Thanks for the reminder, added.

I usually don't add log entries when adding cases to 
test/indent/ruby.rb, though. Is that okay?



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-23  3:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1WRHWl-0006Yn-3N@vcs.savannah.gnu.org>
2014-03-23  0:18 ` emacs-24 r116830: Fix bug#16873 Glenn Morris
2014-03-23  3:31   ` Dmitry Gutov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).