From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master d879c40f68c: * etc/NEWS: Mention it. Date: Mon, 9 Sep 2024 14:40:30 +0300 Message-ID: References: <172563947472.4957.18260024928108489506@vcs2.savannah.gnu.org> <20240906161755.0CEECC2BC7A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33520"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Spencer Baugh To: Eshel Yaron , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 09 13:41:32 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1snclv-0008W5-AU for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Sep 2024 13:41:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sncl9-00013P-E0; Mon, 09 Sep 2024 07:40:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sncl5-0000pX-HP for emacs-devel@gnu.org; Mon, 09 Sep 2024 07:40:39 -0400 Original-Received: from fout6-smtp.messagingengine.com ([103.168.172.149]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sncl3-0001rU-Mq for emacs-devel@gnu.org; Mon, 09 Sep 2024 07:40:39 -0400 Original-Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfout.phl.internal (Postfix) with ESMTP id CC5E91380289; Mon, 9 Sep 2024 07:40:34 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-07.internal (MEProxy); Mon, 09 Sep 2024 07:40:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1725882034; x=1725968434; bh=dKZM/8QAhB7tPaXhMeJX36n/aR2N/O1qD74+5TmBtEc=; b= HOH1/FZDFA4StvXxHZObLDy/4tS0Mv4GgGrc/8KdNQbOOBbnJCNupUxIXYIuOY7n VF3r+pWaodqt2ZFBAWYo4wG5WNLiq6XF6LSSmIabOgT8qZQ2oN5MZOD/ixYanCqT HOmexE01zInZNxjeXbpG4AVtt0Xy9EBTXH7VKezKhdU2rqGfjLdpZr+aexYToRoI Q/zFdZBNJYyKeD2iMGpkqBDOw3DUzlJCvZQNMwBodGAYg8gElId0JVSY2EqadPPo UcDyDU4gc6iGodmPUKLXEpfyGWfW2LMdfEwOADDbZFknjpjdWcnmoFz5huKdUf7K JNbY1WyJ88c08Miss4jz1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725882034; x= 1725968434; bh=dKZM/8QAhB7tPaXhMeJX36n/aR2N/O1qD74+5TmBtEc=; b=X oZS/c6/bFM+CA81BDgpP+9j7RoinEa+OFuP8dvi8msk7Kk0YSoa08LorrUA2NH1v 22jVSigCTPkDzUxKhii8zFMZNGzeqaYyU1UhG8B3gqzdoiFe3eDyvUaP+Btjw0eo Z3oRhX6kA6izQVkzeg2QJSblkDpme2ftCtSrTaC+a1c9Ft3jhsvVyjxdsdHF/Uu3 IwZCLEyj93v8NnvG1W/SHQFnuafkEBNLC65Jv5eaFcURkunHZG9xCy0Q72kYSyjg jnhWqaArxWqDe1xh6kY31Um96UkhqJCG4sZo4ODA17Q5CfnGORmrBKQKTbNWSTPM UpgTl7JO2Kn64+J9GQVxw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeijedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieekueef tddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehmvgesvghshhgvlhihrghroh hnrdgtohhmpdhrtghpthhtohepvghmrggtshdquggvvhgvlhesghhnuhdrohhrghdprhgt phhtthhopehssggruhhghhesjhgrnhgvshhtrhgvvghtrdgtohhm X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 Sep 2024 07:40:33 -0400 (EDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=103.168.172.149; envelope-from=dmitry@gutov.dev; helo=fout6-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323514 Archived-At: On 09/09/2024 11:42, Eshel Yaron wrote: > Nitpick: I find the use of call-interactively with a constant argument > slightly awkward. What do y'all think about a revision along the > following lines? Yeah, I think that works too (the only real duplication is the call to confirm-nonexistent-file-or-buffer, that's minor). > --8<---------------cut here---------------start------------->8--- > ;;;###autoload > (defun project-find-file-in-root (filename) > "Edit file FILENAME. > Interactively, prompt for FILENAME, defaulting to the root directory of > the current project." > (declare (interactive-only find-file)) > (interactive > (list (read-file-name "Find project file: " Maybe "Find in root: "? The command variant doesn't necessarily show all project files, or only project files. > (project-root (project-current t)) nil > (confirm-nonexistent-file-or-buffer)))) > (find-file filename t))