From: Dmitry Gutov <dmitry@gutov.dev>
To: Eshel Yaron <me@eshelyaron.com>, emacs-devel@gnu.org
Cc: Spencer Baugh <sbaugh@janestreet.com>
Subject: Re: master d879c40f68c: * etc/NEWS: Mention it.
Date: Mon, 9 Sep 2024 14:40:30 +0300 [thread overview]
Message-ID: <f1c1998e-0cdd-4225-9ef3-9414165c5a61@gutov.dev> (raw)
In-Reply-To: <m1ttepi5fc.fsf@dazzs-mbp.home>
On 09/09/2024 11:42, Eshel Yaron wrote:
> Nitpick: I find the use of call-interactively with a constant argument
> slightly awkward. What do y'all think about a revision along the
> following lines?
Yeah, I think that works too (the only real duplication is the call to
confirm-nonexistent-file-or-buffer, that's minor).
> --8<---------------cut here---------------start------------->8---
> ;;;###autoload
> (defun project-find-file-in-root (filename)
> "Edit file FILENAME.
> Interactively, prompt for FILENAME, defaulting to the root directory of
> the current project."
> (declare (interactive-only find-file))
> (interactive
> (list (read-file-name "Find project file: "
Maybe "Find in root: "? The command variant doesn't necessarily show all
project files, or only project files.
> (project-root (project-current t)) nil
> (confirm-nonexistent-file-or-buffer))))
> (find-file filename t))
next prev parent reply other threads:[~2024-09-09 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172563947472.4957.18260024928108489506@vcs2.savannah.gnu.org>
[not found] ` <20240906161755.0CEECC2BC7A@vcs2.savannah.gnu.org>
2024-09-09 8:42 ` master d879c40f68c: * etc/NEWS: Mention it Eshel Yaron
2024-09-09 11:40 ` Dmitry Gutov [this message]
2024-09-09 16:03 ` Spencer Baugh
2024-09-09 17:52 ` Eshel Yaron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1c1998e-0cdd-4225-9ef3-9414165c5a61@gutov.dev \
--to=dmitry@gutov.dev \
--cc=emacs-devel@gnu.org \
--cc=me@eshelyaron.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).