From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alexander Shukaev Newsgroups: gmane.emacs.devel Subject: Re: Performance degradation from long lines Date: Fri, 26 Oct 2018 18:50:06 +0200 Message-ID: References: <3717982b-8f1b-2e2b-b213-59aeb62bbb93@Alexander.Shukaev.name> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1540572504 23281 195.159.176.226 (26 Oct 2018 16:48:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 26 Oct 2018 16:48:24 +0000 (UTC) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 26 18:48:20 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gG5HU-0005so-EK for ged-emacs-devel@m.gmane.org; Fri, 26 Oct 2018 18:48:16 +0200 Original-Received: from localhost ([::1]:33043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG5Ja-00035H-Ii for ged-emacs-devel@m.gmane.org; Fri, 26 Oct 2018 12:50:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG5JS-000358-2A for emacs-devel@gnu.org; Fri, 26 Oct 2018 12:50:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gG5JO-0008MS-1t for emacs-devel@gnu.org; Fri, 26 Oct 2018 12:50:17 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:41477) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gG5JN-0008Kl-MV for emacs-devel@gnu.org; Fri, 26 Oct 2018 12:50:13 -0400 X-Originating-IP: 188.107.67.248 Original-Received: from [192.168.2.109] (dslb-188-107-067-248.188.107.pools.vodafone-ip.de [188.107.67.248]) (Authenticated sender: forum@alexander.shukaev.name) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id A3769E0009; Fri, 26 Oct 2018 16:50:07 +0000 (UTC) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.70.183.196 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230717 Archived-At: On 10/26/18 6:18 PM, Stefan Monnier wrote: >> (let ((inhibit-field-text-motion t)) >> (catch 'break >> (while (not (eobp)) >> (when (> (- (line-end-position 1) (point)) >> global-longlines-threshold) >> (throw 'break t)) >> (forward-line 1))))))))) > > I think you can speed this up with the code below (I'd expect a speed up > of about a factor 2 since (line-end-position 1) does about the same as > (forward-line 1)): > > (catch 'break > (while > (unless (eobp) > (or (> (+ (point) global-longlines-threshold) > (progn (forward-line 1) (point))) > (throw 'break t))))) Thanks for the tip! > >> (defun inhibit-set-auto-mode-line-number-display-limit-function () >> (and (integerp line-number-display-limit) >> (> (buffer-size) line-number-display-limit))) >> (add-hook 'inhibit-set-auto-mode-functions >> #'inhibit-set-auto-mode-line-number-display-limit-function) > > Hmm... there seems to be a discrepancy between the identifier and the > code: it seems unrelated to line-number(s). Maybe some left-over from > a previous version of the code? > > > Stefan > > You are right, sorry about `line-number-display-limit', it should of course be something more reasonable, e.g. (8 * 1024 * 1024) for 8GiG cap.