From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master 72ec233: Ignore pending_signals when checking for quits. Date: Mon, 25 Feb 2019 17:47:20 -0800 Organization: UCLA Computer Science Department Message-ID: References: <20190224215115.3364.94205@vcs0.savannah.gnu.org> <20190224215116.2B65D209A5@vcs0.savannah.gnu.org> <98bm2z7cdb.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------E18E21681DA909A58D8988D9" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="52976"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 Cc: Philipp Stephani To: Glenn Morris , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 26 02:47:36 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gyRqI-000DfP-IK for ged-emacs-devel@m.gmane.org; Tue, 26 Feb 2019 02:47:34 +0100 Original-Received: from localhost ([127.0.0.1]:46723 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyRqH-0002Hv-JS for ged-emacs-devel@m.gmane.org; Mon, 25 Feb 2019 20:47:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyRqA-0002He-Sf for emacs-devel@gnu.org; Mon, 25 Feb 2019 20:47:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyRq9-0004GK-89 for emacs-devel@gnu.org; Mon, 25 Feb 2019 20:47:26 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:50236) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gyRq8-0004F0-Ub; Mon, 25 Feb 2019 20:47:25 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 440651613FC; Mon, 25 Feb 2019 17:47:22 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YF0iOUrPm2HH; Mon, 25 Feb 2019 17:47:21 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 178ED1613F7; Mon, 25 Feb 2019 17:47:21 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id XtPCQxowRlUv; Mon, 25 Feb 2019 17:47:20 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id EDDBF1600AE; Mon, 25 Feb 2019 17:47:20 -0800 (PST) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <98bm2z7cdb.fsf@fencepost.gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233619 Archived-At: This is a multi-part message in MIME format. --------------E18E21681DA909A58D8988D9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 2/25/19 2:05 PM, Glenn Morris wrote: > Ref: https://hydra.nixos.org/build/89511758 I reproduced that problem on Fedora 29 and fixed it by installed the attached patch. Not sure it's the best way to fix it, but at least now the test works for me. --------------E18E21681DA909A58D8988D9 Content-Type: text/x-patch; name="0001-Fix-mod-test-build-failure.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-mod-test-build-failure.patch" >From b5ebfbfdee2d486269f6ad5c57f27edbb1d919b7 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 25 Feb 2019 17:44:46 -0800 Subject: [PATCH] Fix mod-test build failure Problem reported by Glenn Morris in: https://lists.gnu.org/r/emacs-devel/2019-02/msg00739.html * test/Makefile.in (HYBRID_MALLOC, LIBEGNU_ARCHIVE): New macros, taken from ../src/Makefile.in. (MODULE_CFLAGS): Add -I$(srcdir)/../lib. ($(test_module)): Link $(LIBEGNU_ARCHIVE) too. --- test/Makefile.in | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/test/Makefile.in b/test/Makefile.in index 4eddb676d4..ce6ce04b8b 100644 --- a/test/Makefile.in +++ b/test/Makefile.in @@ -254,17 +254,21 @@ FPIC_CFLAGS = FPIC_CFLAGS = -fPIC endif +HYBRID_MALLOC = @HYBRID_MALLOC@ +LIBEGNU_ARCHIVE = ../lib/lib$(if $(HYBRID_MALLOC),e)gnu.a + # Note: emacs-module.h is generated from emacs-module.h.in, hence we # look in ../src, not $(srcdir)/../src. -MODULE_CFLAGS = -I../src $(FPIC_CFLAGS) $(PROFILING_CFLAGS) \ +MODULE_CFLAGS = -I../src -I$(srcdir)/../lib \ + $(FPIC_CFLAGS) $(PROFILING_CFLAGS) \ $(WARN_CFLAGS) $(WERROR_CFLAGS) $(CFLAGS) test_module = $(test_module_dir)/mod-test${SO} src/emacs-module-tests.log: $(test_module) -$(test_module): $(test_module:${SO}=.c) ../src/emacs-module.h +$(test_module): $(test_module:${SO}=.c) ../src/emacs-module.h $(LIBEGNU_ARCHIVE) $(AM_V_at)${MKDIR_P} $(dir $@) $(AM_V_CCLD)$(CC) -shared $(CPPFLAGS) $(MODULE_CFLAGS) $(LDFLAGS) \ - -o $@ $< + -o $@ $< $(LIBEGNU_ARCHIVE) endif ## Check that there is no 'automated' subdirectory, which would -- 2.20.1 --------------E18E21681DA909A58D8988D9--