From: Ravi Desai <ravi@ravidesai.com>
To: emacs-devel@gnu.org
Subject: EMACS_INT to EMACS_UINT
Date: Sun, 4 Dec 2016 18:16:17 -0500 [thread overview]
Message-ID: <f11769f9-b67e-a129-964a-65b32079129c@ravidesai.com> (raw)
Hello all,
I've been trying to familiarize myself with the emacs source at the
C-level, and while I was looking at src/lisp.h I noticed that while 'XLI
(a)' should return an EMACS_INT, we expect it to be a EMACS_UINT in the
definition of 'XTYPE'.
---
/* Extract A's type. */
INLINE enum Lisp_Type
XTYPE (Lisp_Object a)
{
EMACS_UINT i = XLI (a); // <---- This seems strange to me.
return USE_LSB_TAG ? i & ~VALMASK : i >> VALBITS;
}
---
Is this something that we should change? The code is working, so I don't
know if its a big enough deal.
next reply other threads:[~2016-12-04 23:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 23:16 Ravi Desai [this message]
2016-12-05 2:00 ` EMACS_INT to EMACS_UINT Paul Eggert
2016-12-05 13:56 ` Ravi Desai
2016-12-05 17:23 ` Paul Eggert
2016-12-05 17:47 ` Daniel Colascione
2016-12-05 18:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f11769f9-b67e-a129-964a-65b32079129c@ravidesai.com \
--to=ravi@ravidesai.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).