From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Pierre-Yves Luyten Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] open bookmark in other frame Date: Fri, 12 Oct 2018 21:45:39 +0200 Message-ID: References: <9d4a9ab3-d802-447e-3c74-81373b7e6101@luyten.fr> <9f2ed5a8-96c0-aa6c-b9c8-3b0f73f20aa6@luyten.fr> <357cd187-ad96-4cc6-9c01-cca87282f165@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------B466252DD1A9B339D0F0C33B" X-Trace: blaine.gmane.org 1539373428 6796 195.159.176.226 (12 Oct 2018 19:43:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 12 Oct 2018 19:43:48 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 To: Drew Adams , emacs-devel@gnu.org, Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 12 21:43:44 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gB3Lb-0001fu-KF for ged-emacs-devel@m.gmane.org; Fri, 12 Oct 2018 21:43:43 +0200 Original-Received: from localhost ([::1]:42397 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gB3Ni-0002qt-3B for ged-emacs-devel@m.gmane.org; Fri, 12 Oct 2018 15:45:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gB3Nb-0002qc-7o for emacs-devel@gnu.org; Fri, 12 Oct 2018 15:45:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gB3NY-0007fj-1R for emacs-devel@gnu.org; Fri, 12 Oct 2018 15:45:47 -0400 Original-Received: from 14.mo6.mail-out.ovh.net ([46.105.56.113]:56503) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gB3NX-0007f5-Lq for emacs-devel@gnu.org; Fri, 12 Oct 2018 15:45:43 -0400 Original-Received: from player759.ha.ovh.net (unknown [10.109.143.223]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id EB1D51891DF for ; Fri, 12 Oct 2018 21:45:41 +0200 (CEST) Original-Received: from [192.168.4.20] (85-170-98-108.rev.numericable.fr [85.170.98.108]) (Authenticated sender: py@luyten.fr) by player759.ha.ovh.net (Postfix) with ESMTPSA id 963676400B1; Fri, 12 Oct 2018 21:45:39 +0200 (CEST) In-Reply-To: <357cd187-ad96-4cc6-9c01-cca87282f165@default> Content-Language: en-US-large X-Ovh-Tracer-Id: 18006798688766963843 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrvddugdduudejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 46.105.56.113 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230357 Archived-At: This is a multi-part message in MIME format. --------------B466252DD1A9B339D0F0C33B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 10/12/18 12:04 AM, Drew Adams wrote >> >> So here is the new version of the patch >> 1. Use pop-up-frames variable to avoid a read-only mode on new frame. >> I also had to use (other-frame 1) to ensure new frame is raised. > > 1. `pop-up-frames' has nothing to do with read-only. Sure, i meant i now use pop-up-frames instead of view-buffer-other-frame, which was the issue. > If you use `bookmark-jump-other-window' instead of `bookmark-jump' then you don't need to also use `(other-frame 1)'. See the code I sent. Great, so i attach a new version of the patch that get rid of (other-frame 1) and still works. Thanks for the help. > 2. I don't think you need to include this in the doc string: > > , so the bookmark menu bookmark remains visible in its window. > I agree this might be too obvious. So i also removed useless verbiage in this version. Regards Pierre-Yves --------------B466252DD1A9B339D0F0C33B Content-Type: text/x-patch; name="0001-lisp-bookmark.el-bookmark-jump-other-frame-new-funct.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-lisp-bookmark.el-bookmark-jump-other-frame-new-funct.pa"; filename*1="tch" >From 9c3f6774413f9c9316eceafde98f1829e5c06dbd Mon Sep 17 00:00:00 2001 From: Pierre-Yves Luyten Date: Fri, 12 Oct 2018 21:32:45 +0200 Subject: [PATCH 1/2] * lisp/bookmark.el (bookmark-jump-other-frame): new function Add bookmark-jump-other-frame Bind to bookmark-map --- lisp/bookmark.el | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 58a279473d..9d55c4aada 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -209,6 +209,7 @@ A non-nil value may result in truncated bookmark names." (define-key map "j" 'bookmark-jump) (define-key map "g" 'bookmark-jump) ;"g"o (define-key map "o" 'bookmark-jump-other-window) + (define-key map "5" 'bookmark-jump-other-frame) (define-key map "i" 'bookmark-insert) (define-key map "e" 'edit-bookmarks) (define-key map "f" 'bookmark-insert-location) ;"f"ind @@ -1124,6 +1125,13 @@ DISPLAY-FUNC would be `switch-to-buffer-other-window'." bookmark-current-bookmark))) (bookmark-jump bookmark 'switch-to-buffer-other-window)) +(defun bookmark-jump-other-frame (bookmark) + "Jump to BOOKMARK in another frame. See `bookmark-jump' for more." + (interactive + (list (bookmark-completing-read "Jump to bookmark (in another frame)" + bookmark-current-bookmark))) + (let ((pop-up-frames t)) + (bookmark-jump-other-window bookmark))) (defun bookmark-jump-noselect (bookmark) "Return the location pointed to by BOOKMARK (see `bookmark-jump'). -- 2.19.0 --------------B466252DD1A9B339D0F0C33B Content-Type: text/x-patch; name="0002-lisp-bookmark.el-bookmark-bmenu-other-frame-new-func.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0002-lisp-bookmark.el-bookmark-bmenu-other-frame-new-func.pa"; filename*1="tch" >From 31ede454672c727c079b5576053e52639ba94fcc Mon Sep 17 00:00:00 2001 From: Pierre-Yves Luyten Date: Fri, 12 Oct 2018 21:35:45 +0200 Subject: [PATCH 2/2] * lisp/bookmark.el (bookmark-bmenu-other-frame):new function Add bookmark-bmenu-other-frame Bind to bookmark-bmenu-mode-map --- lisp/bookmark.el | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 9d55c4aada..7f73c22267 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -1569,6 +1569,7 @@ unique numeric suffixes \"<2>\", \"<3>\", etc." (set-keymap-parent map special-mode-map) (define-key map "v" 'bookmark-bmenu-select) (define-key map "w" 'bookmark-bmenu-locate) + (define-key map "5" 'bookmark-bmenu-other-frame) (define-key map "2" 'bookmark-bmenu-2-window) (define-key map "1" 'bookmark-bmenu-1-window) (define-key map "j" 'bookmark-bmenu-this-window) @@ -1710,6 +1711,7 @@ Bookmark names preceded by a \"*\" have annotations. \\[bookmark-bmenu-this-window] -- select this bookmark in place of the bookmark menu buffer. \\[bookmark-bmenu-other-window] -- select this bookmark in another window, so the bookmark menu bookmark remains visible in its window. +\\[bookmark-bmenu-other-frame] -- select this bookmark in another frame. \\[bookmark-bmenu-switch-other-window] -- switch the other window to this bookmark. \\[bookmark-bmenu-rename] -- rename this bookmark (prompts for new name). \\[bookmark-bmenu-relocate] -- relocate this bookmark's file (prompts for new file). @@ -1979,6 +1981,13 @@ With a prefix arg, prompts for a file to save them in." (bookmark--jump-via bookmark 'switch-to-buffer-other-window))) +(defun bookmark-bmenu-other-frame () + "Select this line's bookmark in other frame." + (interactive) + (let ((bookmark (bookmark-bmenu-bookmark)) + (pop-up-frames t)) + (bookmark-jump-other-window bookmark))) + (defun bookmark-bmenu-switch-other-window () "Make the other window select this line's bookmark. The current window remains selected." -- 2.19.0 --------------B466252DD1A9B339D0F0C33B--