From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jared Finder Newsgroups: gmane.emacs.devel Subject: Re: master 9ccd459e845: Enable xterm-mouse-mode by default in xterm Date: Fri, 13 Dec 2024 21:03:59 -0800 Message-ID: References: <173400071920.1603224.9897683501673718041@vcs3.savannah.gnu.org> <20241212105159.B81A566E610@vcs3.savannah.gnu.org> <87wmg49dtr.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_84f9d89c0fec249697e7804f16405c8b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25905"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 14 06:05:07 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tMKKv-0006YJ-Cp for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Dec 2024 06:05:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMKK7-0007BK-FT; Sat, 14 Dec 2024 00:04:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMKK4-0007B3-VW for emacs-devel@gnu.org; Sat, 14 Dec 2024 00:04:12 -0500 Original-Received: from greenhill.hpalace.com ([192.155.80.58]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMKJw-0004wV-T7 for emacs-devel@gnu.org; Sat, 14 Dec 2024 00:04:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1734152639; bh=TKepRDkRwTHJdiwwczHNZYdL92rHefTYrxHj5IbLuj0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wkVMnf1adpYRIheg+009k0HJHSMtLXdY0NFyJwYLwuhB/Q5UcFXpKmEudhE9gSFyt +w4cYir9lK9cCT2ujjMopLa1bNJsCHyZTg2YWEw5GIDQj3eJ77IN8GQzL10heMRnbC n8FVPO0EH8DH+fflUbQ/UwqyzahaQbQ+ROmV4BxPv5XN2LZxhtIhNDE8k0m3ncxpFw FxCbX9c1wIo7HbSvAZGg7m0OoulQkYdufAAXL3VuXact0h5Z4UDQPIo0nVexdUzEmG o5zN8yObnu1Tvujr8q/SSsi7FRPjWq37ahxAi2LRHomz/JfnwvIhmHLgeErr6qz+IO PQeI751pzPQJg== Original-Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id A23FB1844; Sat, 14 Dec 2024 05:03:59 +0000 (UTC) In-Reply-To: <87wmg49dtr.fsf@gmx.de> X-Sender: jared@finder.org Received-SPF: pass client-ip=192.155.80.58; envelope-from=jared@finder.org; helo=greenhill.hpalace.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326465 Archived-At: --=_84f9d89c0fec249697e7804f16405c8b Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2024-12-13 00:39, Michael Albinus wrote: > Eli Zaretskii writes: > > Hi, > >> branch: master >> commit 9ccd459e8452cc9e6e81e53f26bbeef20d2d5bb7 >> Author: Jared Finder >> Commit: Eli Zaretskii >> >> Enable xterm-mouse-mode by default in xterm >> >> * lisp/xt-mouse.el (xterm-mouse-mode): Change default value of >> xterm-mouse-mode to t. >> * lisp/term/xterm.el (xterm--init): Enable xterm-mouse-mode if >> the default value is still set. >> * etc/NEWS: Document new behavior. > > This fails xt-mouse-tests: > > --8<---------------cut here---------------start------------->8--- > # make -C test xt-mouse-tests.log > > Ran 3 tests, 0 results as expected, 3 unexpected (2024-12-13 > 09:35:08+0100, 1.359088 sec) > > 3 unexpected results: > FAILED xt-mouse-tracking-basic > FAILED xt-mouse-tracking-sgr > FAILED xt-mouse-tracking-utf-8 > --8<---------------cut here---------------end--------------->8--- Apologies for that. Attached is a fix for the test. Unfortunately, for some reason I don't quite understand xt-mouse-tests.el does not work when called inside a running Emacs session. It only works when called in batch mode. This limitation predates turning xterm-mouse-mode on by default, so I just added a FIXME for that. -- MJF --=_84f9d89c0fec249697e7804f16405c8b Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Fix-for-xt-mouse-tests.el-broken-in-prior-commit.patch Content-Disposition: attachment; filename=0001-Fix-for-xt-mouse-tests.el-broken-in-prior-commit.patch; size=2640 RnJvbSAwZjQxNDNkMjZiODA1ZjgzYzFkZDQ3YTg3MjBmMmRiNDI2ODAwYTA1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXJlZCBGaW5kZXIgPGphcmVkQGZpbmRlci5vcmc+CkRhdGU6 IEZyaSwgMTMgRGVjIDIwMjQgMjA6NTk6NTAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBGaXggZm9y IHh0LW1vdXNlLXRlc3RzLmVsIGJyb2tlbiBpbiBwcmlvciBjb21taXQKCnh0LW1vdXNlLXRlc3Rz IG5vdCB0dXJuaW5nIG9uIHh0ZXJtLW1vdXNlLW1vZGUgaWYgaXQgd2FzIGFscmVhZHkKb24gZGlk IG5vdCB3b3JrIHdpdGggeHRlcm0tbW91c2UtbW9kZSBiZWluZyBzZXQgdG8gdCBieSBkZWZhdWx0 LgpJdCB0dXJucyBvdXQgdGhhdCB4dC1tb3VzZS10ZXN0cyBhbHJlYWR5IGRvZXMgbm90IHJlcG9y dCBwcm9wZXIKcmVzdWx0cyB3aGVuIGNhbGxlZCBpbnNpZGUgYSBydW5uaW5nIEVtYWNzIHNlc3Np b24gc28gdGhlIGNvZGUKcGF0aCBpcyBub3QgdXNlZnVsIGFueXdheXMuCgoqIHRlc3QvbGlzcC94 dC1tb3VzZS10ZXN0cy5lbCAod2l0aC14dGVybS1tb3VzZS1tb2RlKTogQWx3YXlzCnR1cm4gb24g eHRlcm0tbW91c2UtbW9kZSwgZXZlbiBpZiBpdCBpcyBhbHJlYWR5IG9uLgotLS0KIHRlc3QvbGlz cC94dC1tb3VzZS10ZXN0cy5lbCB8IDI0ICsrKysrKysrKysrKy0tLS0tLS0tLS0tLQogMSBmaWxl IGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L3Rlc3QvbGlzcC94dC1tb3VzZS10ZXN0cy5lbCBiL3Rlc3QvbGlzcC94dC1tb3VzZS10ZXN0cy5l bAppbmRleCBjZmM4MDQyZjc5Ni4uZjY0YjNhZWQ3M2UgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC94 dC1tb3VzZS10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AveHQtbW91c2UtdGVzdHMuZWwKQEAgLTI1 LDYgKzI1LDggQEAKIAogKHJlcXVpcmUgJ3h0LW1vdXNlKQogCis7OyBGSVhNRTogdGhpcyBkb2Vz bid0IHdvcmsgd2hlbiBjYWxsZWQgaW5zaWRlIGEgbm9uLWJhdGNoIG1vZGUgRW1hY3MKKzs7IHNl c3Npb24uCiAoZGVmbWFjcm8gd2l0aC14dGVybS1tb3VzZS1tb2RlICgmcmVzdCBib2R5KQogICAi UnVuIEJPRFkgd2l0aCBgeHRlcm0tbW91c2UtbW9kZScgdGVtcG9yYXJpbHkgZW5hYmxlZC4iCiAg IChkZWNsYXJlIChpbmRlbnQgMCkpCkBAIC00MiwxOCArNDQsMTYgQEAgd2l0aC14dGVybS1tb3Vz ZS1tb2RlCiAgICAgICAgICAgICAgICAgICAgICAoKHRlcm1pbmFsLXBhcmFtZXRlciBuaWwgJ3h0 ZXJtLW1vdXNlLXkpIG5pbCkKICAgICAgICAgICAgICAgICAgICAgICgodGVybWluYWwtcGFyYW1l dGVyIG5pbCAneHRlcm0tbW91c2UtbGFzdC1kb3duKSBuaWwpCiAgICAgICAgICAgICAgICAgICAg ICAoKHRlcm1pbmFsLXBhcmFtZXRlciBuaWwgJ3h0ZXJtLW1vdXNlLWxhc3QtY2xpY2spIG5pbCkp Ci0gICAgICAgICAgICAgKGlmIHh0ZXJtLW1vdXNlLW1vZGUKLSAgICAgICAgICAgICAgICAgLCht YWNyb2V4cC1wcm9nbiBib2R5KQotICAgICAgICAgICAgICAgKHVud2luZC1wcm90ZWN0Ci0gICAg ICAgICAgICAgICAgICAgKHByb2duCi0gICAgICAgICAgICAgICAgICAgICA7OyBgeHRlcm0tbW91 c2UtbW9kZScgZG9lc24ndCB3b3JrIGluIHRoZSBpbml0aWFsCi0gICAgICAgICAgICAgICAgICAg ICA7OyB0ZXJtaW5hbC4gIFNpbmNlIHdlIGNhbid0IGNyZWF0ZSBhIHNlY29uZAotICAgICAgICAg ICAgICAgICAgICAgOzsgdGVybWluYWwgaW4gYmF0Y2ggbW9kZSwgZmFrZSBpdCB0ZW1wb3Jhcmls eS4KLSAgICAgICAgICAgICAgICAgICAgIChjbC1sZXRmICgoKHN5bWJvbC1mdW5jdGlvbiAndGVy bWluYWwtbmFtZSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxhbWJkYSAoJm9w dGlvbmFsIF90ZXJtaW5hbCkgImZha2UtdGVybWluYWwiKSkpCi0gICAgICAgICAgICAgICAgICAg ICAgICh4dGVybS1tb3VzZS1tb2RlKSkKLSAgICAgICAgICAgICAgICAgICAgICxAYm9keSkKLSAg ICAgICAgICAgICAgICAgKHh0ZXJtLW1vdXNlLW1vZGUgMCkpKSkpCisgICAgICAgICAgICAgKHVu d2luZC1wcm90ZWN0CisgICAgICAgICAgICAgICAgIChwcm9nbgorICAgICAgICAgICAgICAgICAg IDs7IGB4dGVybS1tb3VzZS1tb2RlJyBkb2Vzbid0IHdvcmsgaW4gdGhlIGluaXRpYWwKKyAgICAg ICAgICAgICAgICAgICA7OyB0ZXJtaW5hbC4gIFNpbmNlIHdlIGNhbid0IGNyZWF0ZSBhIHNlY29u ZAorICAgICAgICAgICAgICAgICAgIDs7IHRlcm1pbmFsIGluIGJhdGNoIG1vZGUsIGZha2UgaXQg dGVtcG9yYXJpbHkuCisgICAgICAgICAgICAgICAgICAgKGNsLWxldGYgKCgoc3ltYm9sLWZ1bmN0 aW9uICd0ZXJtaW5hbC1uYW1lKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxhbWJk YSAoJm9wdGlvbmFsIF90ZXJtaW5hbCkgImZha2UtdGVybWluYWwiKSkpCisgICAgICAgICAgICAg ICAgICAgICAoeHRlcm0tbW91c2UtbW9kZSAxKSkKKyAgICAgICAgICAgICAgICAgICAsQGJvZHkp CisgICAgICAgICAgICAgICAoeHRlcm0tbW91c2UtbW9kZSAwKSkpKQogICAgICAgIChzZXQtZnJh bWUtd2lkdGggbmlsIHdpZHRoKQogICAgICAgIChzZXQtZnJhbWUtaGVpZ2h0IG5pbCBoZWlnaHQp KSkpCiAKLS0gCjIuMzkuNQoK --=_84f9d89c0fec249697e7804f16405c8b--