From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: vc-modify-change-comment for "modern" backend fix Date: Thu, 19 May 2022 12:25:47 +0300 Message-ID: References: <9f1b5ce9-270a-2cb4-d958-f7545fd7d373@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3199"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: "Alfred M. Szmidt" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 19 11:26:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrcQh-0000kC-RO for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 11:26:47 +0200 Original-Received: from localhost ([::1]:33138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrcQg-0001HS-IW for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 05:26:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrcPr-0000aP-7k for emacs-devel@gnu.org; Thu, 19 May 2022 05:25:55 -0400 Original-Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:42710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrcPo-0007Q0-MT; Thu, 19 May 2022 05:25:54 -0400 Original-Received: by mail-ed1-x52f.google.com with SMTP id s3so6221732edr.9; Thu, 19 May 2022 02:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rAsN/jpDAVvf4lKksYUKdkNHMO1xTMnHYGgJcztHoYs=; b=hewU/EIaymWvtYnu7Q2vSv8PdjjtIU2qS2r6io4vW13re4YekxbLV6Fh7+h+9eo/iR /6UzEsqOT1lOUElRGQCJOJYMslLpdI3AWx1Rexpf1N0Q8yX0jo5xPo39PFU9kukbqzHP aNYbnZpmm3DbaU6hEuVrCW6qucRlcbHLSk2O6CU5h8CRvBKXoEIB81BbUqGNtpXSNhYG 1vIm8OPAOVQD6H6CdgOs4Wdz2WhKtV5Uw9FIla/v4OOMEWaQ6cOXC5ks+cjqaiqCu23n cTc8l2Nxkv66xzmR9bR4+ypxPpzSv1nU2i6ibJa8O55YWOMvOoe4J4qy1lC3mNMFSkCX yg5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rAsN/jpDAVvf4lKksYUKdkNHMO1xTMnHYGgJcztHoYs=; b=h0L/20MKc9Ba03oBNbFdwG5u9wuVDYWJ7pxLdFP8LFG015vf/8PVibLg8CYQwDcrDC 7TTJGA//Me/EjoHrGUOSG2yStUikQVd9FK6VCW3I082Q4o2VnD7BxXV675srYgOepzUj V76uqRKKq0AL/2Xgu9k557UPZZtNVyDTQs4ur7GQzJFV+bPKriIdWYRcnE2u5zGaP6bf nv7RJ4raRAubg7DMTVsKRU/Tj9OgKZe4jmC86Z2HYf0ZI5CNsOIsAzc3ywKq7DSPOfp4 aRvw9qCgp6wTjyT+vCbUt7EN7mPJkVquHvdrIEKwh2hfwhOGm5XBHzK25sgT9VBZNOo+ pKmw== X-Gm-Message-State: AOAM533yYO2G++hYS/G7gSbcy0xD59mHh2x8MAetlhoctxy2nl/yvcPS SWd3V4xi9BF589MH5bhpNLtDFB62UaQ= X-Google-Smtp-Source: ABdhPJzcfdc21LB3QxLHI78pDACo2UPZ5aIqzKlX+gUeZdmd0JOhiPP75ryOJkOP7A1jXen5Qof25w== X-Received: by 2002:aa7:dad0:0:b0:42a:b250:f078 with SMTP id x16-20020aa7dad0000000b0042ab250f078mr4265691eds.21.1652952350829; Thu, 19 May 2022 02:25:50 -0700 (PDT) Original-Received: from [192.168.236.48] ([173.237.64.48]) by smtp.googlemail.com with ESMTPSA id j22-20020aa7ca56000000b0042acc78178bsm2537783edt.93.2022.05.19.02.25.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 02:25:50 -0700 (PDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=raaahh@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289956 Archived-At: On 19.05.2022 09:11, Alfred M. Szmidt wrote: > On 18.05.2022 09:34, Alfred M. Szmidt wrote: > > + "Extract the commit message for the current file." > > + (vc-call-backend log-view-vc-backend > > + 'get-log-entry > > + (log-view-current-file) > > + (log-view-current-tag))) > > Why not customize the extraction function only for backends that need it? > > This does that, no? If you don't have get-log-entry, then things work > as previously. Yeah, ok. But see the other recommendations. > The backend command could be called 'extract-comment'. Which is somewhat > different from "log entry" because the latter seems to include the > headers, in VC parlance. > > > And you haven't explained thus far your plan for implementing > 'modify-change-comment' for e.g. Git. > > I have no plans on implementing such functionality for git. Okay, but how will this work in fossil? Similar to editing a single commit during a rebase?