From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Erik Martin-Dorel" Newsgroups: gmane.emacs.devel Subject: =?utf-8?q?Re=3A?= [nongnu] elpa/opam-switch-mode 8b8670ca8b =?utf-8?q?1/3=3A?==?utf-8?q?_feat(opam-switch-mode-lighter)=3A?= Show the switch name in the mode-bar Date: Wed, 12 Jul 2023 14:13:13 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6010"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 12 14:42:33 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJZAv-0001Lw-4Y for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Jul 2023 14:42:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJZA4-0003kr-Gd; Wed, 12 Jul 2023 08:41:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJYih-0000m9-CA for emacs-devel@gnu.org; Wed, 12 Jul 2023 08:13:23 -0400 Original-Received: from smtp1.irit.fr ([141.115.24.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJYic-0000RA-1N for emacs-devel@gnu.org; Wed, 12 Jul 2023 08:13:23 -0400 Original-Received: by wwwap4r8.irit.fr (Postfix, from userid 986) id AB156C09386; Wed, 12 Jul 2023 14:13:13 +0200 (CEST) In-Reply-To: X-Forward: 172.17.52.39 Received-SPF: pass client-ip=141.115.24.2; envelope-from=Erik.Martin-Dorel@irit.fr; helo=smtp1.irit.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 12 Jul 2023 08:41:37 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307788 Archived-At: Salut Stefan ! On Wednesday, July 12, 2023 00:09 CEST, Stefan Monnier wrote: > > While `force-mode-line-update` only deals with the current buffer, > > and `(force-mode-line-update t)` just seems to deal with all buffer= s from the current frame. > > Do you confirm? >=20 > No, `(force-mode-line-update t)` should apply to all frames. OK! > > given no subexpression of the current (opam-switch-mode-lighter) > > involves any external system call, I'd say it is not that inefficie= nt/costly=E2=80=A6 >=20 > It's not too bad, admittedly. >=20 > > https://github.com/ocaml/merlin/blob/4f6c7cfee2344dd75e9568f25c0c15= 76521ec049/emacs/merlin.el#L2046 > > Are you OK with that point? >=20 > It's up to you. OK ;) so, given your optimization works very well and stays simple, I've applied it just now, and pushed a new release: https://github.com/ProofGeneral/opam-switch-mode/compare/1.4...1.5 Thanks again, Erik --=20 =C3=89rik Martin-Dorel, PhD Ma=C3=AEtre de Conf=C3=A9rences, Lab. IRIT, Univ. Toulouse 3 erik.martin-dorel@irit.fr erik.martin-dorel@master-developpement-logiciel.fr https://www.irit.fr/~Erik.Martin-Dorel/