From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: Mark custom function for interactive use only Date: Mon, 25 Nov 2013 15:11:37 +0200 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="52934c89_41b71efb_16016" X-Trace: ger.gmane.org 1385385119 28848 80.91.229.3 (25 Nov 2013 13:11:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 Nov 2013 13:11:59 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Sebastian Wiesner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 25 14:12:04 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VkvxD-0006l7-B2 for ged-emacs-devel@m.gmane.org; Mon, 25 Nov 2013 14:11:55 +0100 Original-Received: from localhost ([::1]:52570 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkvxC-00054C-QG for ged-emacs-devel@m.gmane.org; Mon, 25 Nov 2013 08:11:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vkvx4-0004x4-Bn for emacs-devel@gnu.org; Mon, 25 Nov 2013 08:11:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vkvwz-00012g-Bn for emacs-devel@gnu.org; Mon, 25 Nov 2013 08:11:46 -0500 Original-Received: from mail-ea0-x22d.google.com ([2a00:1450:4013:c01::22d]:42181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vkvwy-00010v-N6 for emacs-devel@gnu.org; Mon, 25 Nov 2013 08:11:41 -0500 Original-Received: by mail-ea0-f173.google.com with SMTP id g15so2362407eak.32 for ; Mon, 25 Nov 2013 05:11:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type; bh=0buj9oUMF2BA9TPp5TqEyvtdutPqA5pmNb/hhbwifJ4=; b=09L0LDoGNZB0meBNPv15froJSfAGD86bO0LDsqX6aYgdLENN4O/pQ6lnrDGm1ruOK6 re++vi/V32qlk4sUY88KBiO1ntKCLh3ILlUwqLauCs12sK0UaLB+gdnIhToyrypBKbye 39DmYHPUmacWifLG4bS6eAkfZpd2tJKfSxbZRs7+WtG0+mSiCOXs75JqwyTb5WZfKcsS j2iKKouag6UHSoiQ65mStXg4oR1miBWjZr5zfZW6n0ELGOlw/r2tVRQ94VDLGWpoSAVl mujlUZBXB5eD9xhjE7BeUUoPBk5ISQVoT1l1H2ByDolHogFN1akGRePEhjQwTTsPZ4M0 mjkA== X-Received: by 10.14.206.194 with SMTP id l42mr102279eeo.116.1385385099999; Mon, 25 Nov 2013 05:11:39 -0800 (PST) Original-Received: from Bozhidars-MacBook-Pro.local ([95.87.231.111]) by mx.google.com with ESMTPSA id a45sm77181700eem.6.2013.11.25.05.11.38 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 25 Nov 2013 05:11:39 -0800 (PST) In-Reply-To: X-Mailer: Airmail (211) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165694 Archived-At: --52934c89_41b71efb_16016 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline No problem. If Stefan is OK with the patch I=E2=80=99ll install it myself= and add whatever else is necessary. --=C2=A0 Cheers, Bozhidar On November 25, 2013 at 1:34:44 PM, Sebastian Wiesner (lunaryorn=40gmail.= com) wrote: 2013/11/25 Bozhidar Batsov : =20 > The changes look good to me. Once they are approved by Stefan make sure= to =20 > mention them in the NEWS. =20 Uhm, sorry, what am I supposed to do=3F I am not familiar with Emacs' =20 development process and policies, and thus have no clue what you mean. =20 Besides, I have no intention to get deeply involved, so I'd prefer if =20 someone else did all this organizational stuff. =20 > -- =20 > Cheers, =20 > Bozhidar =20 > =20 > On November 25, 2013 at 12:43:14 PM, Sebastian Wiesner (lunaryorn=40gma= il.com) =20 > wrote: =20 > =20 > 2013/11/25 Sebastian Wiesner : =20 >> 2013/11/25 Stefan Monnier : =20 >>>> I presume I'd just patch =60byte-compile-form' in bytecomp.el to als= o =20 >>>> look at a corresponding property, e.g. =60interactive-use-only=60. =20 >>>> Anything else=3F =20 >>> =20 >>> We should also make byte-compile-interactive-only-functions obsolete = and =20 >>> default it to nil (i.e. move its contents to symbol properties). =20 >> =20 >> Attached is a patch to Emacs trunk, which introduces a =20 >> =60interactive-only' symbol property as either a string with a =22use = =20 >> instead=22 message or just t, sets this property on all functions from= =20 >> byte-compile-interactive-only-functions, and makes =20 >> byte-compile-interactive-only-functions as obsolete. =20 >> =20 >> Documentation and tests are missing. If you can point me to the =20 >> proper places and tell me how to run the Emacs tests, I can add these = =20 >> as well. =20 > =20 > Ok, *now* it's attached. Sorry =20 > =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F= =5F=5F=5F=5F=5F=5F=5F=5F =20 > - interactive-only-property.patch, 9 KB =20 --52934c89_41b71efb_16016 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
No problem. If Ste= fan is OK with the patch I=E2=80=99ll install it myself and add whatever = else is necessary.

-- 
Cheers,
Bozhidar

On November 25, 2013 at 1:34:44 PM, Sebastian Wies= ner (lunaryorn=40gmail.com= ) wrote:

<= span>
2013/11/25 Bozhidar Batsov <bozhidar=40batsov.com>:
> The changes look good to me. Once they are approved by Stefan ma= ke sure to
> mention them in the NEWS.

Uhm, sorry, what am I supposed to do=3F I am not familiar with Emacs= '
development process and policies, and thus have no clue what you mean= .
Besides, I have no intention to get deeply involved, so I'd prefer i= f
someone else did all this organizational stuff.

> --
> Cheers,
> Bozhidar
>
> On November 25, 2013 at 12:43:14 PM, Sebastian Wiesner (lunaryor= n=40gmail.com)
> wrote:
>
> 2013/11/25 Sebastian Wiesner <lunaryorn=40gmail.com>:
>> 2013/11/25 Stefan Monnier <monnier=40iro.umontreal.ca>= :
>>>> I presume I'd just patch =60byte-compile-form' in by= tecomp.el to also
>>>> look at a corresponding property, e.g. =60interactiv= e-use-only=60.
>>>> Anything else=3F
>>>
>>> We should also make byte-compile-interactive-only-functi= ons obsolete and
>>> default it to nil (i.e. move its contents to symbol prop= erties).
>>
>> Attached is a patch to Emacs trunk, which introduces a
>> =60interactive-only' symbol property as either a string with= a =22use
>> instead=22 message or just t, sets this property on all func= tions from
>> byte-compile-interactive-only-functions, and makes
>> byte-compile-interactive-only-functions as obsolete.
>>
>> Documentation and tests are missing. If you can point me to = the
>> proper places and tell me how to run the Emacs tests, I can = add these
>> as well.
>
> Ok, *now* it's attached. Sorry
> =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F= =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F
> - interactive-only-property.patch, 9 KB
--52934c89_41b71efb_16016--