From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: Mark custom function for interactive use only Date: Mon, 25 Nov 2013 12:54:46 +0200 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="52932c76_507ed7ab_16016" X-Trace: ger.gmane.org 1385376903 29734 80.91.229.3 (25 Nov 2013 10:55:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 Nov 2013 10:55:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier , Sebastian Wiesner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 25 11:55:08 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vktop-00009p-PB for ged-emacs-devel@m.gmane.org; Mon, 25 Nov 2013 11:55:07 +0100 Original-Received: from localhost ([::1]:51662 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vktop-00038B-Cb for ged-emacs-devel@m.gmane.org; Mon, 25 Nov 2013 05:55:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vktof-0002y9-Dh for emacs-devel@gnu.org; Mon, 25 Nov 2013 05:55:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VktoZ-0008Te-U5 for emacs-devel@gnu.org; Mon, 25 Nov 2013 05:54:57 -0500 Original-Received: from mail-we0-x22a.google.com ([2a00:1450:400c:c03::22a]:63870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VktoZ-0008TL-Jz for emacs-devel@gnu.org; Mon, 25 Nov 2013 05:54:51 -0500 Original-Received: by mail-we0-f170.google.com with SMTP id w61so3692961wes.15 for ; Mon, 25 Nov 2013 02:54:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type; bh=tzzeoA2d0DWnFe5NDSAuEsnZhtsiM75uf3lZxmxJg0A=; b=ISbSTSutvSdimlawXh2DVnVkLslnIAg3ttTdEOEsYftKUP1cDBm6axuxGaGtA0cbdb GNFWc279sF8NaNkwk6oq+rtNQFaQYYOdSvKWw7wLzu/Ro9pUwDjJ3DJMlXgRqmL1mo9J jk/7z4Jdklj/FYBkkGzMKDjGLI9r7yitM6cYMPOzkdW444Sa1xkpD2ZYexBTWue6dGMS VXB0ci0SHGXsZ0ynnnDt7lSnzSxtxBUBc1aENfIXOxobsGeOAAIH6qP2V2gj9O/4ZH8l p1b9/VMyF8pTGM2duifNbr+tucJC+0zNznKNCZO+Oat0HEXU9dMjaO44ERKnaGiIUeuA wLdA== X-Received: by 10.180.75.235 with SMTP id f11mr13094058wiw.27.1385376890224; Mon, 25 Nov 2013 02:54:50 -0800 (PST) Original-Received: from Bozhidars-MacBook-Pro.local ([95.87.231.111]) by mx.google.com with ESMTPSA id a19sm48683536wib.1.2013.11.25.02.54.48 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 25 Nov 2013 02:54:49 -0800 (PST) In-Reply-To: X-Mailer: Airmail (211) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165687 Archived-At: --52932c76_507ed7ab_16016 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline The changes look good to me. Once they are approved by Stefan make sure t= o mention them in the NEWS. --=C2=A0 Cheers, Bozhidar On November 25, 2013 at 12:43:14 PM, Sebastian Wiesner (lunaryorn=40gmail= .com) wrote: 2013/11/25 Sebastian Wiesner : =20 > 2013/11/25 Stefan Monnier : =20 >>> I presume I'd just patch =60byte-compile-form' in bytecomp.el to also= =20 >>> look at a corresponding property, e.g. =60interactive-use-only=60. =20 >>> Anything else=3F =20 >> =20 >> We should also make byte-compile-interactive-only-functions obsolete a= nd =20 >> default it to nil (i.e. move its contents to symbol properties). =20 > =20 > Attached is a patch to Emacs trunk, which introduces a =20 > =60interactive-only' symbol property as either a string with a =22use =20 > instead=22 message or just t, sets this property on all functions from = =20 > byte-compile-interactive-only-functions, and makes =20 > byte-compile-interactive-only-functions as obsolete. =20 > =20 > Documentation and tests are missing. If you can point me to the =20 > proper places and tell me how to run the Emacs tests, I can add these =20 > as well. =20 Ok, *now* it's attached. Sorry =20 - interactive-only-property.patch, 9 KB --52932c76_507ed7ab_16016 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
The changes look g= ood to me. Once they are approved by Stefan make sure to mention them in = the NEWS.

-- 
Cheers,
Bozhidar

On November 25, 2013 at 12:43:14 PM, Sebastian Wiesner (lunaryorn=40gmail.com) wr= ote:

2013/11/25 Sebastian Wiesner <lunaryorn=40gmail.com>:
> 2013/11/25 Stefan Monnier <monnier=40iro.umontreal.ca>:
>>> I presume I'd just patch =60byte-compile-form' in byteco= mp.el to also
>>> look at a corresponding property, e.g. =60interactive-us= e-only=60.
>>> Anything else=3F
>>
>> We should also make byte-compile-interactive-only-functions = obsolete and
>> default it to nil (i.e. move its contents to symbol properti= es).
>
> Attached is a patch to Emacs trunk, which introduces a
> =60interactive-only' symbol property as either a string with a =22= use
> instead=22 message or just t, sets this property on all function= s from
> byte-compile-interactive-only-functions, and makes
> byte-compile-interactive-only-functions as obsolete.
>
> Documentation and tests are missing. If you can point me to the=
> proper places and tell me how to run the Emacs tests, I can add = these
> as well.

Ok, *now* it's attached. Sorry

- interactive-only-property.patch, 9 KB
<= /blockquote> --52932c76_507ed7ab_16016--