From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Niklas Eklund Newsgroups: gmane.emacs.devel Subject: Re: Add zuul.el package to ELPA Date: Wed, 31 Aug 2022 12:44:55 +0000 Message-ID: References: <874jxuj3q1.fsf@posteo.net> <87v8qaumrh.fsf@posteo.net> <87pmgh1pbf.fsf@posteo.net> <87edwx755s.fsf@posteo.net> <87wnao6566.fsf@posteo.net> <877d2o8w2r.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38992"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 31 14:58:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTNIb-0009ya-8r for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 14:58:29 +0200 Original-Received: from localhost ([::1]:54220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTNIa-00046Y-6q for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 08:58:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTN5e-0000V2-Ap for emacs-devel@gnu.org; Wed, 31 Aug 2022 08:45:06 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:54807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTN5b-0007xM-P9 for emacs-devel@gnu.org; Wed, 31 Aug 2022 08:45:06 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 813E1240029 for ; Wed, 31 Aug 2022 14:44:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661949897; bh=y4+rVc7P2TErJ047W1TULtAHpC43iD1zkUKya9L4PqY=; h=From:To:Cc:Subject:Date:From; b=UHy3OULr+WyqharyHQp/LpoJh38jl7yWQQol4t/ZBhu7Tqf9fyYpHmqHNKjpyGpzZ uj5EtAz4/qZbQizviJfDv40jOntCwUtonGsHlL89FaJ57Ls8o+AqgdEVu3d5lwU000 7whe2uHRHBJWb4NYmBnXn046ecIery9s0+gW2IT92EVN/oHbcUNtxK/OuYypnyWI6P v3kVe1CjXWwKZTqctTjuJfLpntglcaKjlhvInqGReC3LPjUuLtlqV9IX5DF418pKBJ uAQvHjEOXfvPJzTuzoQYpTBsrVBJyH8Jga5UbFuO54P6H1Y1v45hIpCn4oHRCS9F0m KKKJujdJc1Eyg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MHkQw0F7Jz9rxS; Wed, 31 Aug 2022 14:44:55 +0200 (CEST) In-Reply-To: <877d2o8w2r.fsf@posteo.net> Received-SPF: pass client-ip=185.67.36.65; envelope-from=niklas.eklund@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 31 Aug 2022 08:54:22 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294429 Archived-At: Philip Kaludercic writes: > Niklas Eklund writes: > >> Philip Kaludercic writes: >> >>> Niklas Eklund writes: >>> >>>> Niklas Eklund writes: >>>> >>>>> Philip Kaludercic writes: >>>>> >>>>>> Niklas Eklund writes: >>>>>> >>>>>>>> I believe if you used compat, you can reduce the minimal version of >>>>>>>> Emacs down to 26.1, and the only hard dependency appears to be >>>>>>>> project.el? >>>> >>>> One other thing I saw that package lint complained about, and that I >>>> couldn't find in the compat package was with-connection-local-variables? >>>> >>>> 486:3: error: You should depend on (emacs "27.1") if you need >>>> `with-connection-local-variables'. >>>> >>>> I see in the manual that it doesn't seem to be supported >>>> https://git.sr.ht/~pkal/compat/tree/master/compat.texi#L1753. So I guess >>>> I can lower it to 27.1 the most, but that would be a good win over 28.1 :) >>> >>> True, that is missing, but reading through the source in files-x.el, it >>> *might* be possible to add that functionality in a backwards >>> way? But if not, 27.1 is still a considerable improvement considering >>> that Debian Stable is currently distributing that version. >> >> Absolutely, a great improvement! :) If that is added in the future that >> would be even better of course, seems like that's the only thing >> blocking the package from supporting 26. >> >> Once you have released a new version of compat I'll try to depend on >> that. Would this patch be sufficient you think? (given that I update the >> version of compat to the latest) >> >> From a698110e477a1e640b851f912601c67e19bea6b7 Mon Sep 17 00:00:00 2001 >> From: Niklas Eklund >> Date: Wed, 31 Aug 2022 13:38:06 +0200 >> Subject: [PATCH] Use compat package to support older Emacs version >> >> This patch lowers the required Emacs version from 28.1 to 27.1. This >> is done by using the compat package in combination with an explicit >> dependency to the project package. >> --- >> zuul.el | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/zuul.el b/zuul.el >> index f2b146c..34d4bf7 100644 >> --- a/zuul.el >> +++ b/zuul.el >> @@ -5,7 +5,7 @@ >> ;; Author: Niklas Eklund >> ;; URL: https://git.sr.ht/~niklaseklund/zuul.el >> ;; Version: 0.3 >> -;; Package-Requires: ((emacs "28.1")) >> +;; Package-Requires: ((emacs "27.1") (compat "2.1.2.2") (project "0.8.1")) >> ;; Keywords: convenience tools >> >> ;; This file is not part of GNU Emacs. >> @@ -41,6 +41,9 @@ >> >> (require 'ansi-color) >> (require 'comint) >> +(require 'compat) >> +(require 'compat-27) >> +(require 'compat-28) > > These two require statements aren't required, unless you depend on some > function that has been updated between versions (e.g. assoc used to only > take two arguments, and now takes 3, so to avoid overriding the old call > compat provides a prefixed alternative "compat-assoc"). Alright, so only (require 'compat) then, and it will figure out that it needs functions from compat-27 or compat-28 internally? >> (require 'project) >> (eval-when-compile (require 'rx)) >> (require 'subr-x) >> @@ -770,7 +773,7 @@ Optionally provide extra parameters PARAMS, PARSER, METHOD, BUFFER or HEADERS." >> "Parse the output of a json build." >> (let ((build (zuul--request-json-parser))) >> (string-join >> - (flatten-list >> + (flatten-tree >> (seq-map #'zuul--build-playbook-output build)) >> "\n")))