From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Niklas Eklund Newsgroups: gmane.emacs.devel Subject: Re: Add zuul.el package to ELPA Date: Wed, 31 Aug 2022 09:54:37 +0000 Message-ID: References: <874jxuj3q1.fsf@posteo.net> <87v8qaumrh.fsf@posteo.net> <87pmgh1pbf.fsf@posteo.net> <87edwx755s.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23770"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 31 12:56:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTLOh-000611-7J for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 12:56:39 +0200 Original-Received: from localhost ([::1]:49618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTLOf-0003Zm-MX for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 06:56:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTKQp-00045L-Ht for emacs-devel@gnu.org; Wed, 31 Aug 2022 05:54:47 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:36565) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTKQm-0001dy-Uo for emacs-devel@gnu.org; Wed, 31 Aug 2022 05:54:47 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E3134240027 for ; Wed, 31 Aug 2022 11:54:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661939681; bh=W77oTvnC4NuJDtTA5TtIwYIAXFRojgRxJeRDGj2QrhU=; h=From:To:Cc:Subject:Date:From; b=j2HwFgfoVfP2qek11LjAfQ1EllP8C57SE9FlTP+T6AFHWELdTyIipE3YkfwyHS8z8 oI0nmoj0q5sCeOShzIb8UM4gNdelts+vFM87S5cWuJDtXulR/lv225tDy8A9HdEyoU YMcUNWd1V3Oz/SfuCX0Z5SsdnHOsBu3jrrafO3P/D2PadAGzdZmT/sBCoDRcj1b0Wv QrN5413CkQx3CcTv1kmMHfcSJA2VYUnjsyyyHSqdlx8fqsvHBANWq0waNzG5YaUfza SPEP6JZFK7MfZ5DEKGD/cQissDl2l/9gA+L59prm5RU8YPtdvGTR8fsoGx6mAGMdR5 VFqHcZj90oHyg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MHffQ0PBKz6tnf; Wed, 31 Aug 2022 11:54:38 +0200 (CEST) In-Reply-To: Received-SPF: pass client-ip=185.67.36.65; envelope-from=niklas.eklund@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 31 Aug 2022 06:54:23 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294413 Archived-At: Niklas Eklund writes: > Philip Kaludercic writes: > >> Niklas Eklund writes: >> >>>> I believe if you used compat, you can reduce the minimal version of >>>> Emacs down to 26.1, and the only hard dependency appears to be >>>> project.el? One other thing I saw that package lint complained about, and that I couldn't find in the compat package was with-connection-local-variables? 486:3: error: You should depend on (emacs "27.1") if you need `with-connection-local-variables'. I see in the manual that it doesn't seem to be supported https://git.sr.ht/~pkal/compat/tree/master/compat.texi#L1753. So I guess I can lower it to 27.1 the most, but that would be a good win over 28.1 :) /Niklas >>> I wasn't familiar with the compat library. But if I have a dependency to >>> project.el which package-lint tells me I need to have Emacs 28.1 for, is >>> the proper way to add project to Package-Requires to circumvent the >>> need? Should I then do the same for e.g. seq or does compat provide >>> functionality for that library? >> >> No, compat does not automatically add other dependencies. If you need >> some other core package that is also available from ELPA, you will need >> to add the dependency to the "Package-Requires" list yourself. > > Alright, then I understand. I'll look into that. > >> But I have noticed that compat is missing `text-property-search-forward' >> and `text-property-search-backward'. If you are interested in using >> compat, I've already implemented the code and could publish a release >> with these functions added. > > I am interested in adding support for compat, would be good to not > provide a package that only works for the most recent Emacs. Let me know > when the new release is available :) > >>>> I'd also recommend using more specific custom types for your user >>>> options. See (elisp) Composite Types. >>> >>> Thanks for the suggestion, I wasn't aware about these composite types! >> >> This is also useful since the new `setopt' macro can use this for >> type-checking! > > That's neat! > > /Niklas > >>>> It also appears you should be able to use defconst and defvar-local in >>>> your private variable section. >>> >>> defvar-local I didn't know about. >>> >>>> Keywords (:foo) do not have to be quoted to prevent evaluation. >>>> >>>> I believe, but I might be mistaken, that it is advised to require rx in >>>> a `eval-when-compile' block. >>> >>> Make sense. >>> >>>> (mapconcat #'identity ...) should do the same as `string-join' >>> >>> Yeah this becomes clearer. >>> >>>> Defining a map like zuul-log-mode-map is usually done using defvar >>>> >>>> (defvar foo-map >>>> (let ((map (make-sparse-keymap))) >>>> (define-key map ...) >>>> ... >>>> map)) >>> >>> I have taken your suggestions and made them into the following commits: >>> - Add defvar to zuul-log-mode-map >>> - Replace mapconcat with string-join >>> - Require rx at compilation >>> - Use defconst and defvar-local in private vars >>> - Use composite types for defcustom variables >>> https://git.sr.ht/~niklaseklund/zuul.el/log >>> >>> /Niklas >>> >>>>> The package allows users to access build logs from the Zuul, >>>>> https://zuul-ci.org/, CI system. Users uses the completion interface of >>>>> Emacs to select a specific build and a buffer is then opened with the >>>>> build log. >>>>> >>>>> The package utilizes Emacs compilation mode to navigate between errors >>>>> in the logs. It also lets the user configure where projects can be found >>>>> on the local machine so that navigating to the source code of an error >>>>> works, even though the absolute path might not be found on the local >>>>> host. >>>>> >>>>> /Niklas Eklund >>>>> >>>>> From ed4201c73aa66b21b040169009dddb636ab76048 Mon Sep 17 00:00:00 2001 >>>>> From: Niklas Eklund >>>>> Date: Mon, 29 Aug 2022 20:26:35 +0200 >>>>> Subject: [PATCH] * elpa-packages (zuul): New package >>>>> >>>>> --- >>>>> elpa-packages | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/elpa-packages b/elpa-packages >>>>> index 4ae12a26ca..5ab182f93b 100644 >>>>> --- a/elpa-packages >>>>> +++ b/elpa-packages >>>>> @@ -810,4 +810,8 @@ >>>>> ("yasnippet-classic-snippets" :url nil) >>>>> ("zones" :url nil) ;https://www.emacswiki.org/emacs/zones.el >>>>> ("ztree" :url "https://github.com/fourier/ztree") >>>>> + ("zuul" :url "https://git.sr.ht/~niklaseklund/zuul.el" >>>>> + :news "CHANGELOG.org" >>>>> + :readme "README.md" >>>>> + :auto-sync t) >>>>> )