From: kobarity <kobarity@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Jack Kamm <jackkamm@gmail.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] python.el: Returning inferior Python output without inhibiting it
Date: Mon, 02 Oct 2023 21:42:43 +0900 [thread overview]
Message-ID: <eke7edidxkjg.wl-kobarity@gmail.com> (raw)
In-Reply-To: <837co58t8h.fsf@gnu.org>
Eli Zaretskii wrote:
>
> > From: Jack Kamm <jackkamm@gmail.com>
> > Cc: emacs-devel@gnu.org
> > Date: Sun, 01 Oct 2023 13:23:29 -0700
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > > I think instead of renaming (which then requires us to add an obsolete
> > > alias), it would be better to leave python-shell-send-string-no-output
> > > available, but just make it a thin wrapper around
> > > python-shell-send-string-return-output (which I would suggest to name
> > > python-shell-send-string-maybe-output instead). This way, we don't
> > > annoy Lisp programs that use python-shell-send-string-no-output with
> > > obsolescence warnings.
> >
> > Thanks for the feedback -- I've updated the patch accordingly (attached).
>
> Thanks. kobarity, any comments or suggestions?
I agree with leaving `python-shell-send-string-no-output' as it is.
The updated patch looks good to me.
next prev parent reply other threads:[~2023-10-02 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 16:05 [PATCH] python.el: Returning inferior Python output without inhibiting it Jack Kamm
2023-10-01 17:00 ` Eli Zaretskii
2023-10-01 20:23 ` Jack Kamm
2023-10-02 5:54 ` Eli Zaretskii
2023-10-02 12:42 ` kobarity [this message]
2023-10-02 16:10 ` Eli Zaretskii
2023-10-16 0:27 ` Jack Kamm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eke7edidxkjg.wl-kobarity@gmail.com \
--to=kobarity@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jackkamm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).