From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.devel Subject: Re: Fwd: vc-svn.el and "the underscore hack" Date: Wed, 08 Nov 2006 14:23:43 -0700 Organization: IHS Message-ID: References: <17735.25691.286000.488074@gargle.gargle.HOWL> <17744.49420.800000.339491@gargle.gargle.HOWL> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1163021131 3556 80.91.229.2 (8 Nov 2006 21:25:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 8 Nov 2006 21:25:31 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 08 22:25:30 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GhuvG-0005tn-Ee for ged-emacs-devel@m.gmane.org; Wed, 08 Nov 2006 22:25:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GhuvF-0004QS-RH for ged-emacs-devel@m.gmane.org; Wed, 08 Nov 2006 16:25:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ghuug-0004Cc-Ga for emacs-devel@gnu.org; Wed, 08 Nov 2006 16:24:50 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ghuuf-0004Bj-Uk for emacs-devel@gnu.org; Wed, 08 Nov 2006 16:24:50 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ghuuf-0004Bf-JE for emacs-devel@gnu.org; Wed, 08 Nov 2006 16:24:49 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Ghuue-0002Bh-RG for emacs-devel@gnu.org; Wed, 08 Nov 2006 16:24:49 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GhuuX-0005is-1o for emacs-devel@gnu.org; Wed, 08 Nov 2006 22:24:41 +0100 Original-Received: from 207.167.42.206 ([207.167.42.206]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 08 Nov 2006 22:24:41 +0100 Original-Received: from ihs_4664 by 207.167.42.206 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 08 Nov 2006 22:24:41 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 41 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 207.167.42.206 User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) In-Reply-To: <17744.49420.800000.339491@gargle.gargle.HOWL> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61964 Archived-At: AriT93 wrote: > As I mentioned earlier I have made a different change utilizing the > defun from psvn.el since that seemed a cleaner solution that what I > had done previously. > > As described before this patch addresses the > issue that vc-svn does not recognize svn repositories on win32 systems > that use the "underscore hack" and have the svn admin directory as > "_svn" instead of ".svn" > > In testing this morning i noticed that in order for make bootstrap to > work with the change I had to mark it as an autoload. I understand > the reason but is this the correct way for the defuns to be used. I > guess I'm unclear on why vc-svn-registered needs an autoload. I made > svn-wc-adm-dir-name an autoload as it is used in vc-svn-registered. > > I have included text attributing the chage to the work done in psvn.el > I hope that I have done it in a way that is acceptable. Would that > text be better suited to the Commentary section? If so let me now and > I'll move it and resubmit the patch. Wouldn't it be simpler and more reliable to change (when (file-readable-p (expand-file-name ".svn" FILE)) ;; refer to (expand-file-name ".svn" FILE) here ...) to (let (svn-file) (cond ((file-readable-p (setq svn-file (expand-file-name ".svn" FILE)))) ((file-readable-p (setq svn-file (expand-file-name "_svn" FILE)))) (t (setq svn-file nil))) (when svn-file ;; refer to svn-file here ...)) and similarly for the file-directory-p and vc-insert-file calls? -- Kevin