From: Kevin Rodgers <ihs_4664@yahoo.com>
Subject: Re: Fwd: vc-svn.el and "the underscore hack"
Date: Wed, 08 Nov 2006 14:23:43 -0700 [thread overview]
Message-ID: <eithue$2o1$1@sea.gmane.org> (raw)
In-Reply-To: <17744.49420.800000.339491@gargle.gargle.HOWL>
AriT93 wrote:
> As I mentioned earlier I have made a different change utilizing the
> defun from psvn.el since that seemed a cleaner solution that what I
> had done previously.
>
> As described before this patch addresses the
> issue that vc-svn does not recognize svn repositories on win32 systems
> that use the "underscore hack" and have the svn admin directory as
> "_svn" instead of ".svn"
>
> In testing this morning i noticed that in order for make bootstrap to
> work with the change I had to mark it as an autoload. I understand
> the reason but is this the correct way for the defuns to be used. I
> guess I'm unclear on why vc-svn-registered needs an autoload. I made
> svn-wc-adm-dir-name an autoload as it is used in vc-svn-registered.
>
> I have included text attributing the chage to the work done in psvn.el
> I hope that I have done it in a way that is acceptable. Would that
> text be better suited to the Commentary section? If so let me now and
> I'll move it and resubmit the patch.
Wouldn't it be simpler and more reliable to change
(when (file-readable-p (expand-file-name ".svn" FILE))
;; refer to (expand-file-name ".svn" FILE) here
...)
to
(let (svn-file)
(cond ((file-readable-p (setq svn-file (expand-file-name ".svn" FILE))))
((file-readable-p (setq svn-file (expand-file-name "_svn" FILE))))
(t (setq svn-file nil)))
(when svn-file
;; refer to svn-file here
...))
and similarly for the file-directory-p and vc-insert-file calls?
--
Kevin
next prev parent reply other threads:[~2006-11-08 21:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 6:54 [arit93@yahoo.com: vc-svn.el and "the underscore hack"] Richard Stallman
2006-10-31 14:57 ` AriT93
2006-11-01 2:14 ` Richard Stallman
2006-11-01 16:29 ` Fwd: vc-svn.el and "the underscore hack" Stefan Monnier
2006-11-01 21:02 ` AriT93
2006-11-02 4:43 ` Richard Stallman
2006-11-05 19:23 ` Richard Stallman
2006-11-07 17:23 ` AriT93
2006-11-08 16:58 ` Richard Stallman
2006-11-08 21:23 ` Kevin Rodgers [this message]
2006-11-08 21:32 ` AriT93
2006-11-09 1:00 ` David Kastrup
2006-11-09 1:56 ` Chong Yidong
2006-11-09 2:01 ` David Kastrup
2006-11-09 2:06 ` Juanma Barranquero
2006-11-09 2:55 ` David Kastrup
2006-11-09 3:18 ` AriT93
2006-11-09 23:27 ` Richard Stallman
2006-11-09 3:18 ` Chong Yidong
2006-11-09 3:23 ` AriT93
2006-11-09 16:23 ` AriT93
[not found] ` <17735.25421.968000.773096@gargle.gargle.HOWL>
2006-11-01 2:14 ` [arit93@yahoo.com: vc-svn.el and "the underscore hack"] Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eithue$2o1$1@sea.gmane.org' \
--to=ihs_4664@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).