Re: GNU Emacs no longer honours top and left parameters to make-frame

[Ralf Angeli <angeli@caeruleus.net>]

[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]

* YAMAMOTO Mitsuharu (2006-09-22) writes:

>>>>>> On Thu, 21 Sep 2006 22:30:47 +0200, Ralf Angeli <angeli@caeruleus.net> said:
>
>> Does anybody know if there is another variable where the (top and
>> left) values given to `make-frame' are stored and which could be
>> used by w32_createwindow to look them up?
>
> f->top_pos and f->left_pos, which are set in x_figure_window_size.
>
> As I said in http://lists.gnu.org/archive/html/emacs-devel/2006-07/msg01367.html,
> whether we should honor these variables has something to do with size
> hints.  Maybe you can simply check f->size_hint_flags, which is also
> set in x_figure_window_size, against USPosition and PPosition to
> decide that.

Thanks for the hint.  The attached patch checks the value of
f->size_hint_flags in order to decide if the f->left_pos and
f->top_pos values should be used.

With the patch applied stuff like (make-frame '((top . 10))) works
now.  The only drawback is that the value of f->size_hint_flags does
not allow to determine if both top and left positions or only one is
set.  That means in case of the make-frame call above, for example,
the frame is horizontally positioned at the left edge of the desktop,
as the default value for f->left_pos is 0.

Here is a change log entry:

2006-10-07  Ralf Angeli  <angeli@caeruleus.net>

	* w32fns.c (w32_createwindow): Honour left and top positions if
	supplied explicitely.

-- 
Ralf

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: w32fns.patch --]
[-- Type: text/x-patch, Size: 707 bytes --]

Index: w32fns.c
===================================================================
RCS file: /sources/emacs/emacs/src/w32fns.c,v
retrieving revision 1.277
diff -u -r1.277 w32fns.c
--- w32fns.c	24 Sep 2006 09:04:56 -0000	1.277
+++ w32fns.c	7 Oct 2006 19:15:59 -0000
@@ -2108,7 +2108,12 @@
 	}
     }
 
-  if (EQ (left, Qunbound) && EQ (top, Qunbound))
+  if (f->size_hint_flags & USPosition || f->size_hint_flags & PPosition)
+    {
+      XSETINT (left, f->left_pos);
+      XSETINT (top, f->top_pos);
+    }
+  else if (EQ (left, Qunbound) && EQ (top, Qunbound))
     {
       /* When called with RES_TYPE_NUMBER, w32_get_arg will return zero
 	 for anything that is not a number and is not Qunbound.  */

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel