Emacs HEAD broken with XPM option in 1b492fa

Emacs HEAD broken with XPM option in 1b492fa

[Ashish SHUKLA]

[-- Attachment #1: Type: text/plain, Size: 4051 bytes --]

Hi,

I came across following build error in configure script, while building Emacs
git revision 1b492fa[1] on FreeBSD 11.1 amd64:

--8<---------------cut here---------------start------------->8---
checking tiffio.h presence... yes                                                                                              
checking for tiffio.h... yes                                                                                                                                                                                                     
checking for TIFFGetVersion in -ltiff... yes                                                          
checking gif_lib.h usability... yes                                                                      
checking gif_lib.h presence... yes                               
checking for gif_lib.h... yes                                                                                            
checking for GifMakeMapObject in -lgif... yes                          
configure: error: The following required libraries were not found:   
    libXpm                                                     
Maybe some development libraries/packages are missing?                                                                   
If you don't want to link with them give                                                                                 
    --with-xpm=no                                                                               
as options to configure                                                                            
--8<---------------cut here---------------end--------------->8---

Following is the configure line:

--8<---------------cut here---------------start------------->8---
./configure --with-gameuser=games:games --enable-acl --with-dbus --with-gnutls \
 --with-modules --with-threads --with-x --with-xml2 \
 --with-file-notification=kqueue --with-sound=oss --with-x-toolkit=gtk3 \
 --without-cairo --with-gif --with-jpeg --with-imagemagick --with-png \
 --with-rsvg --with-tiff --with-xpm --with-gconf --with-gsettings \
 --with-m17n-flt --with-libotf --with-toolkit-scroll-bars --with-xft --with-xim \
 --with-xwidgets --x-libraries=/usr/local/lib --x-includes=/usr/local/include \
 --prefix=/usr/local --localstatedir=/var --mandir=/usr/local/man \
 --disable-silent-rules --infodir=/usr/local/share/emacs/info/ \
 --build=amd64-portbld-freebsd11.1
--8<---------------cut here---------------end--------------->8---

The complete log is available from:
https://people.freebsd.org/~ashish/emacs-devel-1b492fa-config.log

It seems like in e88bbd22[2], author (cc'ed) typo-ed (s/X11/noX/):

--8<---------------cut here---------------start------------->8---
@@ -3372,18 +3365,18 @@ if test "${HAVE_X11}" = "yes"; then
     AC_CHECK_HEADER(X11/xpm.h,
       [AC_CHECK_LIB(Xpm, XpmReadFileToPixmap, HAVE_XPM=yes, , -lX11)])
     if test "${HAVE_XPM}" = "yes"; then
-      AC_MSG_CHECKING(for XpmReturnAllocPixels preprocessor define)
-      AC_EGREP_CPP(no_return_alloc_pixels,
-      [#include "X11/xpm.h"
+      AC_CACHE_CHECK([for XpmReturnAllocPixels preprocessor define],
+      [emacs_cv_cpp_xpm_return_alloc_pixels],
+      [AC_EGREP_CPP(no_return_alloc_pixels,
+      [#include "noX/xpm.h"
--8<---------------cut here---------------end--------------->8---

After updating the last line, configure script run finishes as expected
without any issue.

Happy to file a bug report, if it's reproducible elsewhere too.

Could you please look at this ?

References:
[1]  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1b492fa
[2]  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e88bbd22

Thanks!
-- 
Ashish SHUKLA

“…one of  the main causes  of the fall of  the Roman Empire  was that,
lacking zero,  they had no  way to indicate successful  termination of
their C programs.”
                                                          (Robert Firth)

Sent from my Emacs

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Emacs HEAD broken with XPM option in 1b492fa

[Paul Eggert]

Ashish SHUKLA wrote:

> checking for GifMakeMapObject in -lgif... yes
> configure: error: The following required libraries were not found:
>      libXpm
> Maybe some development libraries/packages are missing?
> If you don't want to link with them give
>      --with-xpm=no
> as options to configure

> It seems like in e88bbd22[2], author (cc'ed) typo-ed (s/X11/noX/):

A comment before that line says:

### The Cygwin-w32 build uses <noX/xpm.h> instead of <X11/xpm.h>, so
### we need to set LDFLAGS accordingly.

so presumably the noX is intentional. Perhaps this depends on Cygwin versions? 
Sorry, I can't be of much help here since I don't use Cygwin.

Re: Emacs HEAD broken with XPM option in 1b492fa

[Eli Zaretskii]

> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Mon, 4 Sep 2017 10:50:37 -0700
> Cc: Noam Postavsky <npostavs@gmail.com>
> 
> > It seems like in e88bbd22[2], author (cc'ed) typo-ed (s/X11/noX/):
> 
> A comment before that line says:
> 
> ### The Cygwin-w32 build uses <noX/xpm.h> instead of <X11/xpm.h>, so
> ### we need to set LDFLAGS accordingly.
> 
> so presumably the noX is intentional. Perhaps this depends on Cygwin versions? 
> Sorry, I can't be of much help here since I don't use Cygwin.

The OP was evidently compiling for FreeBSD, so I wonder how that
compilation ends up in a Cygwin-specific part of the configure
script.  I guess some configure-time logic misfires on FreeBSD?

The relevant part of config.log is this:

  configure:14996: checking X11/xpm.h presence
  configure:14996: cpp -I/usr/local/include    conftest.c
  configure:14996: $? = 0
  configure:14996: result: yes
  configure:14996: checking for X11/xpm.h
  configure:14996: result: yes
  configure:14998: checking for XpmReadFileToPixmap in -lXpm
  configure:15023: cc -o conftest -I/usr/local/include -O2 -g -fstack-protector -fno-strict-aliasing -I/usr/local/include/librsvg-2.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/libpng16 -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/libdrm -D_THREAD_SAFE -pthread  -I/usr/local/include     -Wl,-rpath=/usr/local/lib -fstack-protector -L/usr/local/lib conftest.c -lXpm -lX11 -lX11 -lutil  >&5 
  configure:15023: $? = 0
  configure:15032: result: yes
  configure:15042: checking for XpmReturnAllocPixels preprocessor define
  conftest.c:152:10: fatal error: 'noX/xpm.h' file not found
  #include "noX/xpm.h"
	   ^~~~~~~~~~~
  1 error generated.
  configure:15064: result: no

Re: Emacs HEAD broken with XPM option in 1b492fa

[Ashish SHUKLA]

[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]

On Mon, 04 Sep 2017 21:30:13 +0300, Eli Zaretskii <eliz@gnu.org> said:
|| From: Paul Eggert <eggert@cs.ucla.edu>
|| Date: Mon, 4 Sep 2017 10:50:37 -0700
|| Cc: Noam Postavsky <npostavs@gmail.com>
|| 
|| > It seems like in e88bbd22[2], author (cc'ed) typo-ed (s/X11/noX/):
|| 
|| A comment before that line says:
|| 
|| ### The Cygwin-w32 build uses <noX/xpm.h> instead of <X11/xpm.h>, so
|| ### we need to set LDFLAGS accordingly.
|| 
|| so presumably the noX is intentional. Perhaps this depends on Cygwin versions? 
|| Sorry, I can't be of much help here since I don't use Cygwin.

| The OP was evidently compiling for FreeBSD, so I wonder how that
| compilation ends up in a Cygwin-specific part of the configure
| script.  I guess some configure-time logic misfires on FreeBSD?

Well, if you look carefully, there are two checks involving "noX/xpm.h" code
snippet, one is for Windows/non-X11, and another is for X11. And,
unfortunately both of those checks check for "noX/xpm.h", which I think is
unintentional, and typo on author's part.

-- 
Ashish SHUKLA

“Progress doesn't  come from early risers  – progress is made  by lazy
men looking for easier ways to do things.”
                                              (Robert A. Heinlein, 1973)

Sent from my Emacs

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: Emacs HEAD broken with XPM option in 1b492fa

[Ashish SHUKLA]

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]

On Tue, 05 Sep 2017 00:48:21 +0530, ashish.is@lostca.se (Ashish SHUKLA) said:
| On Mon, 04 Sep 2017 21:30:13 +0300, Eli Zaretskii <eliz@gnu.org> said:
| || From: Paul Eggert <eggert@cs.ucla.edu>
| || Date: Mon, 4 Sep 2017 10:50:37 -0700
| || Cc: Noam Postavsky <npostavs@gmail.com>
| || 
| || > It seems like in e88bbd22[2], author (cc'ed) typo-ed (s/X11/noX/):
| || 
| || A comment before that line says:
| || 
| || ### The Cygwin-w32 build uses <noX/xpm.h> instead of <X11/xpm.h>, so
| || ### we need to set LDFLAGS accordingly.
| || 
| || so presumably the noX is intentional. Perhaps this depends on Cygwin versions? 
| || Sorry, I can't be of much help here since I don't use Cygwin.

| | The OP was evidently compiling for FreeBSD, so I wonder how that
| | compilation ends up in a Cygwin-specific part of the configure
| | script.  I guess some configure-time logic misfires on FreeBSD?

| Well, if you look carefully, there are two checks involving "noX/xpm.h" code
| snippet, one is for Windows/non-X11, and another is for X11. And,
| unfortunately both of those checks check for "noX/xpm.h", which I think is
| unintentional, and typo on author's part.

At following lines to be precise:

http://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac#n3326

http://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac#n3356

-- 
Ashish SHUKLA

“Nuclear war can ruin your whole compile.”
                                                     ("Karl Lehenbauer")

Sent from my Emacs

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: Emacs HEAD broken with XPM option in 1b492fa

[Ken Brown]

On 9/4/2017 3:23 PM, Ashish SHUKLA wrote:
> On Tue, 05 Sep 2017 00:48:21 +0530, ashish.is@lostca.se (Ashish SHUKLA) said:
> | On Mon, 04 Sep 2017 21:30:13 +0300, Eli Zaretskii <eliz@gnu.org> said:
> | || From: Paul Eggert <eggert@cs.ucla.edu>
> | || Date: Mon, 4 Sep 2017 10:50:37 -0700
> | || Cc: Noam Postavsky <npostavs@gmail.com>
> | ||
> | || > It seems like in e88bbd22[2], author (cc'ed) typo-ed (s/X11/noX/):
> | ||
> | || A comment before that line says:
> | ||
> | || ### The Cygwin-w32 build uses <noX/xpm.h> instead of <X11/xpm.h>, so
> | || ### we need to set LDFLAGS accordingly.
> | ||
> | || so presumably the noX is intentional. Perhaps this depends on Cygwin versions?
> | || Sorry, I can't be of much help here since I don't use Cygwin.
> 
> | | The OP was evidently compiling for FreeBSD, so I wonder how that
> | | compilation ends up in a Cygwin-specific part of the configure
> | | script.  I guess some configure-time logic misfires on FreeBSD?
> 
> | Well, if you look carefully, there are two checks involving "noX/xpm.h" code
> | snippet, one is for Windows/non-X11, and another is for X11. And,
> | unfortunately both of those checks check for "noX/xpm.h", which I think is
> | unintentional, and typo on author's part.
> 
> At following lines to be precise:
> 
> http://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac#n3326

This use of "noX" is correct and is for the Cygwin-w32 build.

> http://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac#n3356

This one is wrong.  It's surprising that it hasn't been noticed until now.  I'll 
fix it shortly if no one beats me to it.

Ken

Re: Emacs HEAD broken with XPM option in 1b492fa

[Ken Brown]

On 9/4/2017 8:45 PM, Ken Brown wrote:
> On 9/4/2017 3:23 PM, Ashish SHUKLA wrote:
>> http://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac#n3326
> 
> This use of "noX" is correct and is for the Cygwin-w32 build.
> 
>> http://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac#n3356
> 
> This one is wrong.  It's surprising that it hasn't been noticed until now.  I'll 
> fix it shortly if no one beats me to it.

Done.

Ken