From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: "Why is emacs so square?" Date: Wed, 22 Apr 2020 11:17:04 -0400 Message-ID: References: <8wXYP4GY9hwW-9mYv6_LGMETZ8Vz3Ob1Bec6yh6kPT7yxjTkxA3V6dXY4ELra9tYiJUxJmgXKSIEX4w8HFiPRoeGVSQHDSoBVy1voj1e3Qo=@protonmail.com> <833694f29y.fsf@gnu.org> <4amRIW9fznS6sa3th4xPABzua9LQDlNPeIFxVsGYdq_wsg4-Ea1l9sEP-T6QrnO5QMV3jhgrnAspk2mSIC7COlodqr04koAcIPYPLLmPHFM=@protonmail.com> <83imhzecc5.fsf@gnu.org> <83y2qvcjv6.fsf@gnu.org> <83k12ed20s.fsf@gnu.org> <83blnqctyj.fsf@gnu.org> <9341072a-cf53-9092-2211-aa97c946e5b1@yandex.ru> <838sinfygb.fsf@gnu.org> <16fad982-e95b-7df1-25d0-1c666a6f8120@gmail.com> <83tv1begq5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="69758"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 22 17:19:07 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRH9W-000I0Q-TS for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Apr 2020 17:19:07 +0200 Original-Received: from localhost ([::1]:52562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRH9V-00089F-Th for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Apr 2020 11:19:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33248) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRH7e-0006GS-AE for emacs-devel@gnu.org; Wed, 22 Apr 2020 11:17:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRH7d-0007Km-Eb for emacs-devel@gnu.org; Wed, 22 Apr 2020 11:17:10 -0400 Original-Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]:32955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRH7c-0007Dn-QU; Wed, 22 Apr 2020 11:17:08 -0400 Original-Received: by mail-qk1-x744.google.com with SMTP id s188so1940977qkf.0; Wed, 22 Apr 2020 08:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VzdTvFHHKDZpMpXC+LK/HLsaQM+RQFadNGNsWIt7A0I=; b=a8HF3Y0m2DCeumF2hQa95HunkC8Ok0Tk9aP2Bqv1E/Dx2bqYKcQtFLys9lHMsGi7+a vVV6OEN9gFgh+LqpUNT5KVbcmJ7ELnZfLDjfaAX7M6LY7LrCkduseZ6SWWHEOxJRcUQr ijpSnqD2JwnxKr/GBMdbqZrIng1eEjnh37EaLnoQ9c6N2L3l0Yx6Bmj9nOOAFUwZd2z4 FRTBFZSw7I2bDp0Mcgkr5yUgS9diaG7LuU2tn1PShnnu6uMm39OERjA9GCNO+H4LhxOy ZigOLocke78JXc/5VrshxN5W7cRvCAEdeB6UJdpBgGTlCsXazAD51/qTe1g8rjq4EE4m oTgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VzdTvFHHKDZpMpXC+LK/HLsaQM+RQFadNGNsWIt7A0I=; b=f9q+OVKxo+040RfgyavcOQHUoLMwq6Vg4pPwNeTBa+GFaxjj9PFcr4U0TcQqGjg9Tq dZLLC2EPGCNUTNqG1zxuWcUc7qpGhLSXggsXygP4+LJctgyJTrgvasGI8Lpr0McD2jCD KhXd6eSuUzPcvTC52KWwBvlCT1gMA2YEZ10rOsS63X5e8ojlwEChqf+9pxoqr8cdpRw1 QTURzjWV3wvyWoaph4zKsVTA1r7VqdTxdWJ9adHMwlWIpEEubWQF+9kBmISzs4lc2jE1 Vi2fy/1Ewm51zsYpGn9hGVXZ/v71MCWMwL+gpJrI8FGncGkxe+4+yZRi0lh3ByttyrpM Etlw== X-Gm-Message-State: AGi0Pua6SFo88rDpcBvIFtdJ01tph8cj+BZbaqPS1bJd70tJslOGpSHs c3h+JFHd/cmvuBFV2yQAyFra58gz X-Google-Smtp-Source: APiQypLgoUPEM8jAU+nEdvPh44EdvdkyGa5lZtgktzOkjEbhv1qaouvEXihZLCRnhSZstUQPXvH57w== X-Received: by 2002:a05:620a:125c:: with SMTP id a28mr8825081qkl.122.1587568626031; Wed, 22 Apr 2020 08:17:06 -0700 (PDT) Original-Received: from ?IPv6:2601:184:4180:66e7:40b5:9c78:223e:9420? ([2601:184:4180:66e7:40b5:9c78:223e:9420]) by smtp.googlemail.com with ESMTPSA id m40sm4440511qtc.33.2020.04.22.08.17.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2020 08:17:05 -0700 (PDT) In-Reply-To: <83tv1begq5.fsf@gnu.org> Content-Language: en-GB Received-SPF: pass client-ip=2607:f8b0:4864:20::744; envelope-from=cpitclaudel@gmail.com; helo=mail-qk1-x744.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2607:f8b0:4864:20::744 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247519 Archived-At: On 22/04/2020 10.29, Eli Zaretskii wrote: >> From: Clément Pit-Claudel >> Date: Wed, 22 Apr 2020 10:05:15 -0400 >> >>> I don't think I follow. Where can I find this "GNOME theme"? It's >>> not part of the Emacs release tarball, is it? >> >> It's shipped by GNU/Linux distributions, typically. > > Any chance of getting a URL that I could explore? Yes, of course. Here is the theme used on my machine, for example: https://github.com/linuxmint/mint-y-icons strace-ing `emacs -Q' on my machine suggests that it loads the following icons for the default tool-bar: 13718:openat(AT_FDCWD, "/usr/share/icons/Mint-Y/actions/22/document-new.svg", O_RDONLY) = 15 13728:openat(AT_FDCWD, "/usr/share/icons/Mint-Y/actions/22/document-open.svg", O_RDONLY) = 15 13747:openat(AT_FDCWD, "/usr/share/icons/Mint-Y/actions/22/window-close.svg", O_RDONLY) = 15 13752:openat(AT_FDCWD, "/usr/share/icons/Mint-Y/actions/22/document-save.svg", O_RDONLY) = 15 13757:openat(AT_FDCWD, "/usr/share/icons/Mint-Y/actions/22/edit-undo.svg", O_RDONLY) = 15 13762:openat(AT_FDCWD, "/usr/share/icons/Mint-Y/actions/22/edit-cut.svg", O_RDONLY) = 15 13767:openat(AT_FDCWD, "/usr/share/icons/Mint-Y/actions/22/edit-copy.svg", O_RDONLY) = 15 13772:openat(AT_FDCWD, "/usr/share/icons/Mint-Y/actions/22/edit-paste.svg", O_RDONLY) = 15 13777:openat(AT_FDCWD, "/usr/share/icons/Mint-Y/actions/22/edit-find.svg", O_RDONLY) = 15 The icon naming spec is here: https://developer.gnome.org/icon-naming-spec/ >>> What exactly do you mean by "icons follow the theme"? how does a theme >>> affect icons? >> >> In GTK builds (the default in Debian, and probably others), the toolbar uses icons from the current GTK icon theme. I believe this is done in update_frame_tool_bar in gtkutil.c. > > Then I don't understand the complaint. The icons that don't change > are our private icons that aren't taken from GTK. So how can they > "follow the theme", if they are absent there? IIUC, the claim is that there (likely) are standard icons close to the ones we use, and that using the corresponding icon names would give us good-looking icons by default on Gtk. Concretely, for the actions shown in the message toolbar, this would be these: mail-attachment document-send or mail-send tools-check-spelling mail-mark-important The spec doesn't seem to have actions for marking an email unimportant or requesting an email receipt. >>>> Perhaps the solution, at least for the GTK builds, would be to find the >>>> standard icons (more concretely, icon names) that can be used for these >>>> buttons >> >>> AFAIR, last time we made such an effort, we indeed took icons from GTK >>> or GNOME or from some similar collection. But that was a long time >>> ago, and in particular the two rightmost icons you see in Message mode >>> were not part of that set, they were added by someone later. >> >> It should be enough to change the name of the icons on the toolbar. No need to take icons from GTK (if that means copying files into the Emacs repo). > > That would only help GTK users. I thought we wanted to improve the > Emacs appearance on more than just one toolkit, especially since that > toolkit is troubled and many users avoid building with it for that > reason. Sure, importing icons is also a good idea. But the OP was making the point that we can easily improve the situation without bikeshedding a specific icon choice by respecting existing user themes. Clément.