From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Florian Rommel Newsgroups: gmane.emacs.devel Subject: Re: Support fullscreen values fullheight and fullwidth on pgtk Date: Fri, 03 Jun 2022 20:42:53 +0200 Message-ID: References: <87r1477ggj.fsf@yahoo.com> <87sfom5f64.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-UTh2qZlIhB07CffoQlzz" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="671"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.44.2 Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 03 21:13:53 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nxCk5-000AX5-EB for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Jun 2022 21:13:53 +0200 Original-Received: from localhost ([::1]:45982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxCk4-00023o-2s for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Jun 2022 15:13:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxCGL-0006OO-Tz for emacs-devel@gnu.org; Fri, 03 Jun 2022 14:43:11 -0400 Original-Received: from read.uberspace.de ([185.26.156.133]:52838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxCGH-0002iK-9m for emacs-devel@gnu.org; Fri, 03 Jun 2022 14:43:09 -0400 Original-Received: (qmail 10599 invoked by uid 990); 3 Jun 2022 18:43:02 -0000 Authentication-Results: read.uberspace.de; auth=pass (plain) In-Reply-To: <87sfom5f64.fsf@yahoo.com> X-Rspamd-Bar: - X-Rspamd-Report: BAYES_HAM(-2.913952) MIME_GOOD(-0.1) MIME_BASE64_TEXT_BOGUS(1) MIME_BASE64_TEXT(0.1) X-Rspamd-Score: -1.913952 Original-Received: from unknown (HELO unkown) (::1) by read.uberspace.de (Haraka/2.8.28) with ESMTPSA; Fri, 03 Jun 2022 20:43:02 +0200 Received-SPF: pass client-ip=185.26.156.133; envelope-from=mail@florommel.de; helo=read.uberspace.de X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 03 Jun 2022 15:12:56 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290635 Archived-At: --=-UTh2qZlIhB07CffoQlzz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2022-06-03 at 16:23 +0800, Po Lu wrote: > > Okay, I removed the version check. >=20 > Thanks, but you forgot to adjust this check in configure.ac: >=20 > if test "${window_system}" =3D "x11"; then > GTK_REQUIRED=3D3.10 > else > GTK_REQUIRED=3D3.20 > fi >=20 > and the announcement in etc/NEWS. Thank you, I fixed it. >=20 > > I am afraid that this is not possible because GTK does not seem to have > > a way for setting such states. As far as I can see, it is only > > possible to maximize a window and to set it to fullscreen (fullboth). >=20 > Too bad, I guess a footnote should be added in the node "Size > Parameters" in the Lisp reference manual. Currently, setting fullwidth or fullheight results in an temporary inconsistency till the next window_state_event arrives and resets the fullscreen parameter. In theory, we could reset the fullscreen parameter to the correct value directly in `set_fullscreen_state' by looking at the GtkWindow. But I'm not sure if that's a good idea. --=-UTh2qZlIhB07CffoQlzz Content-Disposition: attachment; filename*0=v3-0001-pgtk-Add-support-for-fullscreen-values-fullheight.pat; filename*1=ch Content-Type: text/x-patch; name="v3-0001-pgtk-Add-support-for-fullscreen-values-fullheight.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAyZTVjNzQyZjU3MmMwMGQxMTI2MzUyMGQxYTk3ZjRmM2NhMmFkZGJkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGbG9yaWFuIFJvbW1lbCA8bWFpbEBmbG9yb21tZWwuZGU+CkRh dGU6IEZyaSwgMyBKdW4gMjAyMiAwMzowMzowMyArMDIwMApTdWJqZWN0OiBbUEFUQ0ggdjNdIHBn dGs6IEFkZCBzdXBwb3J0IGZvciBmdWxsc2NyZWVuIHZhbHVlcyBmdWxsaGVpZ2h0IGFuZAogZnVs bHdpZHRoCgoqIHNyYy9wZ3RrdGVybS5jICh3aW5kb3dfc3RhdGVfZXZlbnQpOiBTdXBwb3J0IHZh bHVlcyBmdWxsaGVpZ2h0IGFuZApmdWxsd2lkdGggZm9yIHRoZSBmdWxsc2NyZWVuIGZyYW1lLXBh cmFtZXRlcgoqIGRvYy9saXNwcmVmL2ZyYW1lcy50ZXhpIChTaXplIFBhcmFtZXRlcnMpOiBEb2N1 bWVudCBpbmFiaWxpdHkgdG8KYWN0aXZlbHkgc2V0IGh1bGxoZWlnaHQvZnVsbHdpZHRoIGZvciBQ R1RLIGZyYW1lcwoqIGNvbmZpZ3VyZS5hYzogQnVtcCBHVEsgdmVyc2lvbiBmb3IgUEdUSwoqIGV0 Yy9ORVdTOiBBbm5vdW5jZSBHVEsgdmVyc2lvbiBjaGFuZ2UgZm9yIFBHVEsKLS0tCiBjb25maWd1 cmUuYWMgICAgICAgICAgICB8ICAyICstCiBkb2MvbGlzcHJlZi9mcmFtZXMudGV4aSB8ICA4ICsr KysrLS0tCiBldGMvTkVXUyAgICAgICAgICAgICAgICB8ICAzICsrKwogc3JjL3BndGt0ZXJtLmMg ICAgICAgICAgfCAyNyArKysrKysrKysrKysrKysrKystLS0tLS0tLS0KIDQgZmlsZXMgY2hhbmdl ZCwgMjcgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvY29uZmln dXJlLmFjIGIvY29uZmlndXJlLmFjCmluZGV4IGVkOGVjODkwYWMuLmMyNWJjYjJkNjAgMTAwNjQ0 Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1cmUuYWMKQEAgLTI4NjQsNyArMjg2NCw3 IEBAIEFDX0RFRlVOCiAgICAgaWYgdGVzdCAiJHt3aW5kb3dfc3lzdGVtfSIgPSAieDExIjsgdGhl bgogICAgICAgR1RLX1JFUVVJUkVEPTMuMTAKICAgICBlbHNlCi0gICAgICBHVEtfUkVRVUlSRUQ9 My4yMAorICAgICAgR1RLX1JFUVVJUkVEPTMuMjIKICAgICBmaQogICAgIEdUS19NT0RVTEVTPSJn dGsrLTMuMCA+PSAkR1RLX1JFUVVJUkVEIGdsaWItMi4wID49ICRHTElCX1JFUVVJUkVEIgogCmRp ZmYgLS1naXQgYS9kb2MvbGlzcHJlZi9mcmFtZXMudGV4aSBiL2RvYy9saXNwcmVmL2ZyYW1lcy50 ZXhpCmluZGV4IDlmNzY2NmFjNjMuLjU2ODMyZTU4NWEgMTAwNjQ0Ci0tLSBhL2RvYy9saXNwcmVm L2ZyYW1lcy50ZXhpCisrKyBiL2RvYy9saXNwcmVmL2ZyYW1lcy50ZXhpCkBAIC0xNzQ2LDkgKzE3 NDYsMTEgQEAgU2l6ZSBQYXJhbWV0ZXJzCiBAaXRlbSBmdWxsc2NyZWVuCiBUaGlzIHBhcmFtZXRl ciBzcGVjaWZpZXMgd2hldGhlciB0byBtYXhpbWl6ZSB0aGUgZnJhbWUncyB3aWR0aCwgaGVpZ2h0 CiBvciBib3RoLiAgSXRzIHZhbHVlIGNhbiBiZSBAY29kZXtmdWxsd2lkdGh9LCBAY29kZXtmdWxs aGVpZ2h0fSwKLUBjb2Rle2Z1bGxib3RofSwgb3IgQGNvZGV7bWF4aW1pemVkfS4gIEEgQGRmbntm dWxsd2lkdGh9IGZyYW1lIGlzIGFzCi13aWRlIGFzIHBvc3NpYmxlLCBhIEBkZm57ZnVsbGhlaWdo dH0gZnJhbWUgaXMgYXMgdGFsbCBhcyBwb3NzaWJsZSwgYW5kCi1hIEBkZm57ZnVsbGJvdGh9IGZy YW1lIGlzIGJvdGggYXMgd2lkZSBhbmQgYXMgdGFsbCBhcyBwb3NzaWJsZS4gIEEKK0Bjb2Rle2Z1 bGxib3RofSwgb3IgQGNvZGV7bWF4aW1pemVkfS5AZm9vdG5vdGV7T24gUEdUSyBmcmFtZXMsIHNl dHRpbmcKK3RoZSB2YWx1ZXMgQGNvZGV7ZnVsbGhlaWdodH0gYW5kIEBjb2Rle2Z1bGx3aWR0aH0g aGFzIG5vIGVmZmVjdCwgb25seQorcmVhZGluZyBpcyBzdXBwb3J0ZWQufSAgQSBAZGZue2Z1bGx3 aWR0aH0gZnJhbWUgaXMgYXMgd2lkZSBhcworcG9zc2libGUsIGEgQGRmbntmdWxsaGVpZ2h0fSBm cmFtZSBpcyBhcyB0YWxsIGFzIHBvc3NpYmxlLCBhbmQgYQorQGRmbntmdWxsYm90aH0gZnJhbWUg aXMgYm90aCBhcyB3aWRlIGFuZCBhcyB0YWxsIGFzIHBvc3NpYmxlLiAgQQogQGRmbnttYXhpbWl6 ZWR9IGZyYW1lIGlzIGxpa2UgYSBgYGZ1bGxib3RoJycgZnJhbWUsIGV4Y2VwdCB0aGF0IGl0CiB1 c3VhbGx5IGtlZXBzIGl0cyB0aXRsZSBiYXIgYW5kIHRoZSBidXR0b25zIGZvciByZXNpemluZyBh bmQgY2xvc2luZwogdGhlIGZyYW1lLiAgQWxzbywgbWF4aW1pemVkIGZyYW1lcyB0eXBpY2FsbHkg YXZvaWQgaGlkaW5nIGFueSB0YXNrIGJhcgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVX UwppbmRleCA1NGJjNmQ4MGUxLi4xYWE1ZjdlOTZmIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysg Yi9ldGMvTkVXUwpAQCAtMjQsNiArMjQsOSBAQCBhcHBsaWVzLCBhbmQgcGxlYXNlIGFsc28gdXBk YXRlIGRvY3N0cmluZ3MgYXMgbmVlZGVkLgogDAogKiBJbnN0YWxsYXRpb24gQ2hhbmdlcyBpbiBF bWFjcyAyOS4xCiAKKysrKworKiogQnVpbGRpbmcgRW1hY3Mgd2l0aCBwdXJlIEdUSyBub3cgcmVx dWlyZXMgR1RLIDMuMjIuCisKICsrKwogKiogRW1hY3MgY2FuIGJlIGJ1aWx0IHdpdGggYnVpbHQt aW4gc3VwcG9ydCBmb3IgYWNjZXNzaW5nIFNRTGl0ZSBkYXRhYmFzZXMuCiBUaGlzIHVzZXMgdGhl IHBvcHVsYXIgc3FsaXRlMyBsaWJyYXJ5LCBhbmQgY2FuIGJlIGRpc2FibGVkIGJ5IHVzaW5nCmRp ZmYgLS1naXQgYS9zcmMvcGd0a3Rlcm0uYyBiL3NyYy9wZ3RrdGVybS5jCmluZGV4IGRhOTU4YTY2 NjQuLmI4MTZkZWJhMGEgMTAwNjQ0Ci0tLSBhL3NyYy9wZ3RrdGVybS5jCisrKyBiL3NyYy9wZ3Rr dGVybS5jCkBAIC01NDIwLDE1ICs1NDIwLDE4IEBAIHdpbmRvd19zdGF0ZV9ldmVudCAoR3RrV2lk Z2V0ICp3aWRnZXQsCiAJCSAgICBncG9pbnRlciAqdXNlcl9kYXRhKQogewogICBzdHJ1Y3QgZnJh bWUgKmYgPSBwZ3RrX2FueV93aW5kb3dfdG9fZnJhbWUgKGV2ZW50LT53aW5kb3dfc3RhdGUud2lu ZG93KTsKKyAgR2RrV2luZG93U3RhdGUgbmV3X3N0YXRlOwogICB1bmlvbiBidWZmZXJlZF9pbnB1 dF9ldmVudCBpbmV2OwogCisgIG5ld19zdGF0ZSA9IGV2ZW50LT53aW5kb3dfc3RhdGUubmV3X3dp bmRvd19zdGF0ZTsKKwogICBFVkVOVF9JTklUIChpbmV2LmllKTsKICAgaW5ldi5pZS5raW5kID0g Tk9fRVZFTlQ7CiAgIGluZXYuaWUuYXJnID0gUW5pbDsKIAogICBpZiAoZikKICAgICB7Ci0gICAg ICBpZiAoZXZlbnQtPndpbmRvd19zdGF0ZS5uZXdfd2luZG93X3N0YXRlICYgR0RLX1dJTkRPV19T VEFURV9GT0NVU0VEKQorICAgICAgaWYgKG5ld19zdGF0ZSAmIEdES19XSU5ET1dfU1RBVEVfRk9D VVNFRCkKIAl7CiAJICBpZiAoRlJBTUVfSUNPTklGSUVEX1AgKGYpKQogCSAgICB7CkBAIC01NDQ0 LDE3ICs1NDQ3LDI0IEBAIHdpbmRvd19zdGF0ZV9ldmVudCAoR3RrV2lkZ2V0ICp3aWRnZXQsCiAJ fQogICAgIH0KIAotICBpZiAoZXZlbnQtPndpbmRvd19zdGF0ZS5uZXdfd2luZG93X3N0YXRlCi0g ICAgICAmIEdES19XSU5ET1dfU1RBVEVfRlVMTFNDUkVFTikKKyAgaWYgKG5ld19zdGF0ZSAmIEdE S19XSU5ET1dfU1RBVEVfRlVMTFNDUkVFTikKICAgICBzdG9yZV9mcmFtZV9wYXJhbSAoZiwgUWZ1 bGxzY3JlZW4sIFFmdWxsYm90aCk7Ci0gIGVsc2UgaWYgKGV2ZW50LT53aW5kb3dfc3RhdGUubmV3 X3dpbmRvd19zdGF0ZQotCSAgICYgR0RLX1dJTkRPV19TVEFURV9NQVhJTUlaRUQpCisgIGVsc2Ug aWYgKG5ld19zdGF0ZSAmIEdES19XSU5ET1dfU1RBVEVfTUFYSU1JWkVEKQogICAgIHN0b3JlX2Zy YW1lX3BhcmFtIChmLCBRZnVsbHNjcmVlbiwgUW1heGltaXplZCk7CisgIGVsc2UgaWYgKChuZXdf c3RhdGUgJiBHREtfV0lORE9XX1NUQVRFX1RPUF9USUxFRCkKKwkgICAmJiAobmV3X3N0YXRlICYg R0RLX1dJTkRPV19TVEFURV9CT1RUT01fVElMRUQpCisJICAgJiYgIShuZXdfc3RhdGUgJiBHREtf V0lORE9XX1NUQVRFX1RPUF9SRVNJWkFCTEUpCisJICAgJiYgIShuZXdfc3RhdGUgJiBHREtfV0lO RE9XX1NUQVRFX0JPVFRPTV9SRVNJWkFCTEUpKQorICAgIHN0b3JlX2ZyYW1lX3BhcmFtIChmLCBR ZnVsbHNjcmVlbiwgUWZ1bGxoZWlnaHQpOworICBlbHNlIGlmICgobmV3X3N0YXRlICYgR0RLX1dJ TkRPV19TVEFURV9MRUZUX1RJTEVEKQorCSAgICYmIChuZXdfc3RhdGUgJiBHREtfV0lORE9XX1NU QVRFX1JJR0hUX1RJTEVEKQorCSAgICYmICEobmV3X3N0YXRlICYgR0RLX1dJTkRPV19TVEFURV9M RUZUX1JFU0laQUJMRSkKKwkgICAmJiAhKG5ld19zdGF0ZSAmIEdES19XSU5ET1dfU1RBVEVfUklH SFRfUkVTSVpBQkxFKSkKKyAgICBzdG9yZV9mcmFtZV9wYXJhbSAoZiwgUWZ1bGxzY3JlZW4sIFFm dWxsd2lkdGgpOwogICBlbHNlCiAgICAgc3RvcmVfZnJhbWVfcGFyYW0gKGYsIFFmdWxsc2NyZWVu LCBRbmlsKTsKIAotICBpZiAoZXZlbnQtPndpbmRvd19zdGF0ZS5uZXdfd2luZG93X3N0YXRlCi0g ICAgICAmIEdES19XSU5ET1dfU1RBVEVfSUNPTklGSUVEKQorICBpZiAobmV3X3N0YXRlICYgR0RL X1dJTkRPV19TVEFURV9JQ09OSUZJRUQpCiAgICAgU0VUX0ZSQU1FX0lDT05JRklFRCAoZiwgdHJ1 ZSk7CiAgIGVsc2UKICAgICB7CkBAIC01NDY0LDggKzU0NzQsNyBAQCB3aW5kb3dfc3RhdGVfZXZl bnQgKEd0a1dpZGdldCAqd2lkZ2V0LAogICAgICAgU0VUX0ZSQU1FX0lDT05JRklFRCAoZiwgZmFs c2UpOwogICAgIH0KIAotICBpZiAoZXZlbnQtPndpbmRvd19zdGF0ZS5uZXdfd2luZG93X3N0YXRl Ci0gICAgICAmIEdES19XSU5ET1dfU1RBVEVfU1RJQ0tZKQorICBpZiAobmV3X3N0YXRlICYgR0RL X1dJTkRPV19TVEFURV9TVElDS1kpCiAgICAgc3RvcmVfZnJhbWVfcGFyYW0gKGYsIFFzdGlja3ks IFF0KTsKICAgZWxzZQogICAgIHN0b3JlX2ZyYW1lX3BhcmFtIChmLCBRc3RpY2t5LCBRbmlsKTsK LS0gCjIuMzYuMQoK --=-UTh2qZlIhB07CffoQlzz--