From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: dash.el [was: Re: Imports / inclusion of s.el into Emacs] Date: Fri, 22 May 2020 21:39:55 +0300 Message-ID: References: <4e937898-ae46-710a-cbca-e452a1156fa1@yandex.ru> <96bf0b6e-3559-ed02-5596-6a6642188309@yandex.ru> <93a7bb1c-390f-440f-02cc-6cce39ea9431@yandex.ru> <87k1175sl3.fsf@gmail.com> <2a43cea0-8e00-3c22-3ddc-eff29fc9b2db@yandex.ru> <87d06y4kze.fsf@gmail.com> <712d7134-b8ef-b843-bb20-152717092497@yandex.ru> <87367s1bxu.fsf@gmail.com> <90325e25-7a44-0068-9294-91afda7ed953@yandex.ru> <87pnawyr9t.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="57719"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: Richard Stallman , joostkremers@fastmail.fm, emacs-devel , "Alfred M. Szmidt" , Stefan Monnier , =?UTF-8?B?7KGw7ISx67mI?= , Eli Zaretskii , Phillip Lord To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 22 20:40:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jcCb3-000EuZ-4d for ged-emacs-devel@m.gmane-mx.org; Fri, 22 May 2020 20:40:41 +0200 Original-Received: from localhost ([::1]:42052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcCb2-0005Pc-7F for ged-emacs-devel@m.gmane-mx.org; Fri, 22 May 2020 14:40:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcCaR-0004t6-EZ for Emacs-devel@gnu.org; Fri, 22 May 2020 14:40:03 -0400 Original-Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:43960) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcCaQ-00084u-AS; Fri, 22 May 2020 14:40:03 -0400 Original-Received: by mail-wr1-x443.google.com with SMTP id i15so11061267wrx.10; Fri, 22 May 2020 11:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7ibhIl/mm89fTRaxDbCSnqjPiqTgTnjvbVr1LEyI/Dk=; b=bhLDhyhk48nulXyo21CU2wVS3tQHSaHV2SN0A/s1R8xkw9aqd1fiyUY92pqwMCe1Lu ItQjr4guKMQHaDJmPi3sY/8MgWx03Nd7CQPxDawManA1zb5pg/2a+EMWSqiJH92Pooad Rvpwv5Of8DZOTSSpjH6XP5VqE1ogfRmndDDc92qMnBlR6Ti67k/SYTfanjISPvwfyIQp k3JOERzvog6mh+BqTfo6Z83Ty73OWKz9+IkYvOdKdhBjyzHVxRDG4bNzbe3jhpnxRIST YvlDxmnYN4CJZde0aV2EmM53tvWTN0o2rFrJuYuMMQi9HqPavW7UMdldiAtnMD0+tLI3 RySg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7ibhIl/mm89fTRaxDbCSnqjPiqTgTnjvbVr1LEyI/Dk=; b=n+5KrSCX5GHPgw6OYB2e6ULg9L4CNBawXxBi3e7UQRTpuVsvPpQobefkHF5cUWjvkC 8HxDwf1jmh4dVh2pzmk8QJMOGEe3dNH9AsGs/tjtvcUBPtL3Q5Hpw5R6l8N0G6btcpDy uo5fEnEF4BVSdmA9dLHXcwZs/7VXPuTNK4qFQMzl9SVCNfqa6Rh4JxOuTAMWQE3OBp8Q lRDQd7WPEm0yW+eyvG1BmkeRJx70KGHE5MC2BTD3k/VliJXXXExs3qHWEmrCNJi5db07 O5sxen+Iynd7Ovpu/+Egkf3i9gSBelL45I6LLeeFo4GCJxNgPr1lRK3AKtSGVquwmpLH tORA== X-Gm-Message-State: AOAM5307tSK7MDHHQ9hmIybCw0zIpJgY+MjEfSyqxS9ReA+br1wAin+r M7zxThlGcWco3ZbWbBvmweA9O3sW X-Google-Smtp-Source: ABdhPJwZ20zpObgOfuaYPUELvCuThyAGM7QFrAihgcevluhs347DU8LkYv+X1G2r4G25RB5vd+eVFg== X-Received: by 2002:a5d:4806:: with SMTP id l6mr4477585wrq.121.1590172799192; Fri, 22 May 2020 11:39:59 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id x22sm9931783wmi.32.2020.05.22.11.39.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2020 11:39:58 -0700 (PDT) In-Reply-To: <87pnawyr9t.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::443; envelope-from=raaahh@gmail.com; helo=mail-wr1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251236 Archived-At: On 22.05.2020 17:32, João Távora wrote: >>>> Meanwhile, lsp-mode developers will address similar reports directly, >>>> without footballing the users. >>> They regularly solve LSP server bugs in lsp-mode? Very bad >>> idea. Relying >>> on features is one thing, relying on bugs is another thing entirely. >> Did that report concern a bug in a language server? It didn't look >> that way to me. > I wasn't speaking of any particular one. I was telling how we work with > Eglot users that report server bugs to us. You talked about > "footballing users" and how lsp-mode adress them "directly". I assumed > that means they hack lsp-mode.el of lsp-foo.el to work around server > bugs, but I really have no idea. In fact I don't know what we're > talking about anymore, I have to admit. We're talking about this issue you mentioned: https://github.com/joaotavora/eglot/issues/363 The resolution there, it seems, is that the user must discover which data, and in which format, to add to eglot-workspace-configuration for stuff to work as expected. In the meantime (as I have just found out by doing a search), lsp-rust both contains this setting at a reasonable default: https://github.com/emacs-lsp/lsp-mode/blob/057e8789638a0bf493930637185694b6b09ea58e/lsp-rust.el#L267 ...and exposes the possible values of this setting in a well-documented user option: https://github.com/emacs-lsp/lsp-mode/blob/057e8789638a0bf493930637185694b6b09ea58e/lsp-rust.el#L185 So, which of these two approaches to development does look more "integrated" to you?