* Re: master 7d47651d01: project-buffers: Describe the default implementation
@ 2022-11-04 8:15 Eli Zaretskii
2022-11-04 10:41 ` Dmitry Gutov
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2022-11-04 8:15 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index ec453baf72..6d062aa8fa 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -353,7 +353,10 @@ Also quote LOCAL-FILES if `default-directory' is quoted."
> local-files))))
>
> (cl-defgeneric project-buffers (project)
> - "Return the list of all live buffers that belong to PROJECT."
> + "Return the list of all live buffers that belong to PROJECT.
> +
> +The default implementation matches the current open buffers to
> +PROJECT root using the value of `default-directory' in each one."
What does it mean "the current open buffers"? I don't think we use
the term "open buffer" in our documentation. Do you mean the
"existing buffers"? or maybe just "buffers"?
IOW, what aspects of buffers is the "current open" qualification
trying to capture?
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master 7d47651d01: project-buffers: Describe the default implementation
2022-11-04 8:15 master 7d47651d01: project-buffers: Describe the default implementation Eli Zaretskii
@ 2022-11-04 10:41 ` Dmitry Gutov
2022-11-04 11:49 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Dmitry Gutov @ 2022-11-04 10:41 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
On 04.11.2022 10:15, Eli Zaretskii wrote:
> What does it mean "the current open buffers"? I don't think we use
> the term "open buffer" in our documentation. Do you mean the
> "existing buffers"? or maybe just "buffers"?
I've changed that to "existing buffers". Thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master 7d47651d01: project-buffers: Describe the default implementation
2022-11-04 10:41 ` Dmitry Gutov
@ 2022-11-04 11:49 ` Eli Zaretskii
2022-11-04 11:51 ` Dmitry Gutov
2022-11-04 11:52 ` Dmitry Gutov
0 siblings, 2 replies; 8+ messages in thread
From: Eli Zaretskii @ 2022-11-04 11:49 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel
> Date: Fri, 4 Nov 2022 12:41:32 +0200
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
>
> On 04.11.2022 10:15, Eli Zaretskii wrote:
> > What does it mean "the current open buffers"? I don't think we use
> > the term "open buffer" in our documentation. Do you mean the
> > "existing buffers"? or maybe just "buffers"?
>
> I've changed that to "existing buffers". Thanks!
Thanks, but does that mean buffers created later will not be matched
according to their default-directory value? Why should we say
"existing" here?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master 7d47651d01: project-buffers: Describe the default implementation
2022-11-04 11:49 ` Eli Zaretskii
@ 2022-11-04 11:51 ` Dmitry Gutov
2022-11-04 12:13 ` Eli Zaretskii
2022-11-04 11:52 ` Dmitry Gutov
1 sibling, 1 reply; 8+ messages in thread
From: Dmitry Gutov @ 2022-11-04 11:51 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
On 04.11.2022 13:49, Eli Zaretskii wrote:
> Thanks, but does that mean buffers created later will not be matched
> according to their default-directory value? Why should we say
> "existing" here?
Later than what?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master 7d47651d01: project-buffers: Describe the default implementation
2022-11-04 11:51 ` Dmitry Gutov
@ 2022-11-04 12:13 ` Eli Zaretskii
2022-11-04 13:38 ` Dmitry Gutov
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2022-11-04 12:13 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel
> Date: Fri, 4 Nov 2022 13:51:58 +0200
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
>
> On 04.11.2022 13:49, Eli Zaretskii wrote:
> > Thanks, but does that mean buffers created later will not be matched
> > according to their default-directory value? Why should we say
> > "existing" here?
>
> Later than what?
Later than the call to this method.
IOW, I'm asking why do we have to mention "existing" at all. What is
wrong or inaccurate with saying
The default implementation matches each buffer to PROJECT root using
the buffer's value of `default-directory'.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master 7d47651d01: project-buffers: Describe the default implementation
2022-11-04 11:49 ` Eli Zaretskii
2022-11-04 11:51 ` Dmitry Gutov
@ 2022-11-04 11:52 ` Dmitry Gutov
1 sibling, 0 replies; 8+ messages in thread
From: Dmitry Gutov @ 2022-11-04 11:52 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
On 04.11.2022 13:49, Eli Zaretskii wrote:
> Why should we say
> "existing" here?
The flow of the sentence doesn't work as well without an adjective, I'd
say. But please feel free to remove it.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-04 13:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-04 8:15 master 7d47651d01: project-buffers: Describe the default implementation Eli Zaretskii
2022-11-04 10:41 ` Dmitry Gutov
2022-11-04 11:49 ` Eli Zaretskii
2022-11-04 11:51 ` Dmitry Gutov
2022-11-04 12:13 ` Eli Zaretskii
2022-11-04 13:38 ` Dmitry Gutov
2022-11-04 13:56 ` Eli Zaretskii
2022-11-04 11:52 ` Dmitry Gutov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).