unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Bozhidar Batsov" <bozhidar@batsov.dev>
To: "Emacs Devel" <emacs-devel@gnu.org>
Subject: Re: [PATCH] add outline regexp to ruby-mode
Date: Wed, 06 Jul 2022 10:04:49 +0300	[thread overview]
Message-ID: <ebe273b1-6f91-499d-9a0d-db08411550b7@www.fastmail.com> (raw)
In-Reply-To: <CAJddU=p6eqsD-7ttdJUM03ExcfFWsAwjXSyNDKGuhw6rv8axKw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3527 bytes --]

I like this suggestion, although I don't think that's the right regexp to use for an outline. Shouldn't it be limited to definitions only (similar to what imenu typically does)? 

On Wed, Jul 6, 2022, at 2:48 AM, Yilkal Argaw wrote:
> > Hello guys.
> > Some programming modes built into emacs provide outline-regexp to
> > allow for code folding and an example of this is python-mode.
> > "ruby-mode" on the other hand does does not have this feature. Since
> > it is a very handy feature to have it might be worth adding with the
> > following simple patch.
> >
> > diff --git a/lisp/progmodes/ruby-mode.el b/lisp/progmodes/ruby-mode.el
> > index a197724634..6437b84628 100644
> > --- a/lisp/progmodes/ruby-mode.el
> > +++ b/lisp/progmodes/ruby-mode.el
> > @@ -2447,6 +2447,7 @@ ruby--prettify-symbols-alist
> >      ("lambda" . ?λ))
> >    "Value for `prettify-symbols-alist' in `ruby-mode'.")
> >
> > +
> >  ;;;###autoload
> >  (define-derived-mode ruby-mode prog-mode "Ruby"
> >    "Major mode for editing Ruby code."
> > @@ -2465,7 +2466,8 @@ ruby-mode
> >                                     ((?_ . "w"))))
> >    (setq-local prettify-symbols-alist ruby--prettify-symbols-alist)
> >
> > -  (setq-local syntax-propertize-function #'ruby-syntax-propertize))
> > +  (setq-local syntax-propertize-function #'ruby-syntax-propertize)
> > +  (setq-local outline-regexp ruby-indent-beg-re))
> >
> >  ;;; Invoke ruby-mode when appropriate
> > Sorry I just noticed the extra line break after I pressed send. Here is the
> > patch without that line break.
> 
> diff --git a/lisp/progmodes/ruby-mode.el b/lisp/progmodes/ruby-mode.el
> index a197724634..7a62d72e06 100644
> --- a/lisp/progmodes/ruby-mode.el
> +++ b/lisp/progmodes/ruby-mode.el
> @@ -2465,7 +2465,8 @@ ruby-mode
>                                     ((?_ . "w"))))
>    (setq-local prettify-symbols-alist ruby--prettify-symbols-alist)
> 
> -  (setq-local syntax-propertize-function #'ruby-syntax-propertize))
> +  (setq-local syntax-propertize-function #'ruby-syntax-propertize)
> +  (setq-local outline-regexp ruby-indent-beg-re))
> 
> ;;; Invoke ruby-mode when appropriate
> 
> 
> 
> On Wed, Jul 6, 2022 at 2:28 AM Yilkal Argaw
> <yilkalargawworkneh@gmail.com> wrote:
> >
> > Hello guys.
> > Some programming modes built into emacs provide outline-regexp to
> > allow for code folding and an example of this is python-mode.
> > "ruby-mode" on the other hand does does not have this feature. Since
> > it is a very handy feature to have it might be worth adding with the
> > following simple patch.
> >
> > diff --git a/lisp/progmodes/ruby-mode.el b/lisp/progmodes/ruby-mode.el
> > index a197724634..6437b84628 100644
> > --- a/lisp/progmodes/ruby-mode.el
> > +++ b/lisp/progmodes/ruby-mode.el
> > @@ -2447,6 +2447,7 @@ ruby--prettify-symbols-alist
> >      ("lambda" . ?λ))
> >    "Value for `prettify-symbols-alist' in `ruby-mode'.")
> >
> > +
> >  ;;;###autoload
> >  (define-derived-mode ruby-mode prog-mode "Ruby"
> >    "Major mode for editing Ruby code."
> > @@ -2465,7 +2466,8 @@ ruby-mode
> >                                     ((?_ . "w"))))
> >    (setq-local prettify-symbols-alist ruby--prettify-symbols-alist)
> >
> > -  (setq-local syntax-propertize-function #'ruby-syntax-propertize))
> > +  (setq-local syntax-propertize-function #'ruby-syntax-propertize)
> > +  (setq-local outline-regexp ruby-indent-beg-re))
> >
> >  ;;; Invoke ruby-mode when appropriate
> 
> 

[-- Attachment #2: Type: text/html, Size: 5644 bytes --]

  reply	other threads:[~2022-07-06  7:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 23:28 [PATCH] add outline regexp to ruby-mode Yilkal Argaw
2022-07-05 23:48 ` Yilkal Argaw
2022-07-06  7:04   ` Bozhidar Batsov [this message]
2022-07-06  8:06     ` Juri Linkov
2022-07-08  1:12       ` Dmitry Gutov
2022-07-08  5:38         ` Bozhidar Batsov
2022-07-08  8:27           ` Yilkal Argaw
2022-07-08 17:18             ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebe273b1-6f91-499d-9a0d-db08411550b7@www.fastmail.com \
    --to=bozhidar@batsov.dev \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).