From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: master updated (5af5ed6c62 -> f07505d1ec) Date: Tue, 6 Sep 2022 11:41:56 -0700 Message-ID: References: <166233264971.21612.17042094685015365861@vcs2.savannah.gnu.org> <87fsh665fj.fsf@gnus.org> <87r10ox2xl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------81A81E1F8ADFD903B6581090" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30019"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 06 20:43:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVdXl-0007ep-CK for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Sep 2022 20:43:29 +0200 Original-Received: from localhost ([::1]:55982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVdXj-0003tS-KZ for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Sep 2022 14:43:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVdWU-00037B-Pn for emacs-devel@gnu.org; Tue, 06 Sep 2022 14:42:10 -0400 Original-Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:45984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVdWT-0006YY-2z for emacs-devel@gnu.org; Tue, 06 Sep 2022 14:42:10 -0400 Original-Received: by mail-pl1-x630.google.com with SMTP id u22so12112634plq.12 for ; Tue, 06 Sep 2022 11:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-language:in-reply-to:mime-version:date:message-id:from :references:cc:to:subject:from:to:cc:subject:date; bh=P8oFkwc/2Eeb+c4SykBiYVSLko88q/8riGplNtEBVrs=; b=LAlwl7OBUncymHdo8r0boi5r7GgL9VP27i7t/frj/KUBm2kbiw7dhFMA4R6k6O3uvF dnVD4bOX9zVvOaL3XMvOaqFKyiG0dZZtNMsEgXMrcctOobibhgPVL2GWqzYMAVEmblIe kq7YkeZBTBMgwD6WF08mJ32J65mWRKvVHrenG7XbFPa15HLbtiCj8vBSEaGxGtqbhpvI gHC6/wgiJtx+X7uY+uUp65v6o4c+Tc/8ntSzHP8F7ziGajZAQdzCUBR2VfbSk+WdWizc z0KArJqRc7DB1p+wDwwGRHcTsAKl9G3wBSO6HGTVL5bFgaE7PI0YhQxUoLDIdpMXhE+M OKWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:in-reply-to:mime-version:date:message-id:from :references:cc:to:subject:x-gm-message-state:from:to:cc:subject:date; bh=P8oFkwc/2Eeb+c4SykBiYVSLko88q/8riGplNtEBVrs=; b=bZhPRi4u6VAErncl1xGElyQKXiw+Yh6meoST4Mzgfq1q8vV17HuvuVBZZyI0xe+kj6 0K/s+mJZV4fZfotE2N9pTQblzZkNGHA4b7K+NL6aIGzYwVMANM/EXHRwujXZcaaCMkVv jOnsOzU4ZVRpXIFH1fyFI3Wqs+NZOFD2h4eBgnwUdf+9cMovao+QyjiFhghZHNscvTIH x3wGA6ARXrhHwIVHUmbM2aeV3Rr2b/7cU/Pnt2zeQULIJbqnBO3QiRfoJXaoJIOs+Xmd 6NBCT3XiY0LkR6FdLMFpz/7nlybljPQFwSXr2rVsLTzEQTczCCoe837mRd3i5u0gwwXf 4BUg== X-Gm-Message-State: ACgBeo3u/KKLQpcbINWIktiFQVzQ326iuFv+PhVAdi/WSskC0LAoZP1y B0gFw1n8zsNWAHVIRGq20KJ9AwJLAfc= X-Google-Smtp-Source: AA6agR6YwEa+qxhWBuBwh42aPcQmonjKPPDB+s0ZLxprrBIaCWHi8RbR1hNhOqyVH9WX2xaiHYxdow== X-Received: by 2002:a17:90b:3144:b0:1f5:2c6d:7dea with SMTP id ip4-20020a17090b314400b001f52c6d7deamr25671196pjb.220.1662489718781; Tue, 06 Sep 2022 11:41:58 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id v65-20020a622f44000000b00539aa7f0b53sm10458892pfv.104.2022.09.06.11.41.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Sep 2022 11:41:57 -0700 (PDT) In-Reply-To: <87r10ox2xl.fsf@gnus.org> Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294795 Archived-At: This is a multi-part message in MIME format. --------------81A81E1F8ADFD903B6581090 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 9/6/2022 2:33 AM, Lars Ingebrigtsen wrote: > Speaking of eshell tests -- this one seems to be failing on EMBA in > nativecomp: > > https://emba.gnu.org/emacs/emacs/-/jobs/53337 > > 1 unexpected results: > FAILED eshell-test/subcommand-reset-in-pipeline ((should (eshell-command-result--equal command (eshell-test-command-result command) result)) :form (eshell-command-result--equal "*cat $ | *cat" "first\n" "first") :value nil :explanation (nonequal-result (command "*cat $ | *cat") (result "first\n") (expected "first"))) > > I'm unable to reproduce the failure myself. Interesting; the test is outputting "first\n", but we don't expect the newline. Maybe this is because EMBA uses a different version of "cat"? I think something like the attached patch would fix things. Then the test won't care about whether there's a newline or not. --------------81A81E1F8ADFD903B6581090 Content-Type: text/plain; charset=UTF-8; name="0001-Improve-robustness-of-an-Eshell-regression-test.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Improve-robustness-of-an-Eshell-regression-test.patch" RnJvbSBiMjM5NDhmNDY0NWZhM2RiM2QzMDllMmYxMTk3ZmYzODkyNjRiOTdjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgNiBTZXAgMjAyMiAxMTozNjo1OCAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIEltcHJvdmUgcm9idXN0bmVzcyBvZiBhbiBFc2hlbGwgcmVncmVzc2lvbiB0ZXN0Cgoq IHRlc3QvbGlzcC9lc2hlbGwvZXNoZWxsLXRlc3RzLmVsCihlc2hlbGwtdGVzdC9zdWJjb21t YW5kLXJlc2V0LWluLXBpcGVsaW5lKTogVXNlCidlc2hlbGwtbWF0Y2gtY29tbWFuZC1vdXRw dXQnIHRvIGNoZWNrIHJlc3VsdC4KClJlZjogaHR0cHM6Ly9saXN0cy5nbnUub3JnL2FyY2hp dmUvaHRtbC9lbWFjcy1kZXZlbC8yMDIyLTA5L21zZzAwMzE0Lmh0bWwKLS0tCiB0ZXN0L2xp c3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbCB8IDI1ICsrKysrKysrKysrKystLS0tLS0tLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbCBiL3Rlc3Qv bGlzcC9lc2hlbGwvZXNoZWxsLXRlc3RzLmVsCmluZGV4IGQ1MTEyMTQ2YzIuLjJkYzk5NmU5 MjMgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lc2hlbGwvZXNoZWxsLXRlc3RzLmVsCisrKyBi L3Rlc3QvbGlzcC9lc2hlbGwvZXNoZWxsLXRlc3RzLmVsCkBAIC04MywxOCArODMsMTkgQEAg ZXNoZWxsLXRlc3Qvc3ViY29tbWFuZC1yZXNldC1pbi1waXBlbGluZQogICAoZG9saXN0ICh0 ZW1wbGF0ZSAnKCJlY2hvIHslc30gfCAqY2F0IgogICAgICAgICAgICAgICAgICAgICAgICJl Y2hvICR7JXN9IHwgKmNhdCIKICAgICAgICAgICAgICAgICAgICAgICAiKmNhdCAkPCVzPiB8 ICpjYXQiKSkKLSAgICAoZXNoZWxsLWNvbW1hbmQtcmVzdWx0LWVxdWFsCi0gICAgIChmb3Jt YXQgdGVtcGxhdGUgImVjaG8gJGVzaGVsbC1pbi1waXBlbGluZS1wIikKLSAgICAgbmlsKQot ICAgIChlc2hlbGwtY29tbWFuZC1yZXN1bHQtZXF1YWwKLSAgICAgKGZvcm1hdCB0ZW1wbGF0 ZSAiZWNobyB8IGVjaG8gJGVzaGVsbC1pbi1waXBlbGluZS1wIikKLSAgICAgImxhc3QiKQot ICAgIChlc2hlbGwtY29tbWFuZC1yZXN1bHQtZXF1YWwKLSAgICAgKGZvcm1hdCB0ZW1wbGF0 ZSAiZWNobyAkZXNoZWxsLWluLXBpcGVsaW5lLXAgfCBlY2hvIikKLSAgICAgImZpcnN0IikK LSAgICAoZXNoZWxsLWNvbW1hbmQtcmVzdWx0LWVxdWFsCi0gICAgIChmb3JtYXQgdGVtcGxh dGUgImVjaG8gfCBlY2hvICRlc2hlbGwtaW4tcGlwZWxpbmUtcCB8IGVjaG8iKQotICAgICAi dCIpKSkKKyAgICAod2l0aC10ZW1wLWVzaGVsbAorICAgICAoZXNoZWxsLW1hdGNoLWNvbW1h bmQtb3V0cHV0CisgICAgICAoZm9ybWF0IHRlbXBsYXRlICJlY2hvICRlc2hlbGwtaW4tcGlw ZWxpbmUtcCIpCisgICAgICAiXFxgXFwnIikKKyAgICAgKGVzaGVsbC1tYXRjaC1jb21tYW5k LW91dHB1dAorICAgICAgKGZvcm1hdCB0ZW1wbGF0ZSAiZWNobyB8IGVjaG8gJGVzaGVsbC1p bi1waXBlbGluZS1wIikKKyAgICAgICJcXGBsYXN0IikKKyAgICAgKGVzaGVsbC1tYXRjaC1j b21tYW5kLW91dHB1dAorICAgICAgKGZvcm1hdCB0ZW1wbGF0ZSAiZWNobyAkZXNoZWxsLWlu LXBpcGVsaW5lLXAgfCBlY2hvIikKKyAgICAgICJcXGBmaXJzdCIpCisgICAgIChlc2hlbGwt bWF0Y2gtY29tbWFuZC1vdXRwdXQKKyAgICAgIChmb3JtYXQgdGVtcGxhdGUgImVjaG8gfCBl Y2hvICRlc2hlbGwtaW4tcGlwZWxpbmUtcCB8IGVjaG8iKQorICAgICAgIlxcYHQiKSkpKQog CiAoZXJ0LWRlZnRlc3QgZXNoZWxsLXRlc3QvbGlzcC1yZXNldC1pbi1waXBlbGluZSAoKQog ICAiQ2hlY2sgdGhhdCBpbnRlcnBvbGF0ZWQgTGlzcCBmb3JtcyByZXNldCBgZXNoZWxsLWlu LXBpcGVsaW5lLXAnLiIKLS0gCjIuMjUuMQoK --------------81A81E1F8ADFD903B6581090--