From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Tue, 1 Jun 2021 17:41:04 +0200 Message-ID: References: <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87y2c5nhsr.fsf@mail.linkov.net> <87h7irss50.fsf@mail.linkov.net> <43d1599e-2ba9-2efb-45c3-76c67d29a69d@daniel-mendler.de> <87tumrgqrb.fsf@gmail.com> <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <875yyxaoxp.fsf@gmail.com> <76b5aee4-8eec-7998-23d1-d63d86e4b956@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37053"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 01 17:41:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lo6Wk-0009RS-KF for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Jun 2021 17:41:58 +0200 Original-Received: from localhost ([::1]:52002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo6Wj-0006RT-Mh for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Jun 2021 11:41:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo6W0-0005Sw-2X for emacs-devel@gnu.org; Tue, 01 Jun 2021 11:41:12 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:58473 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo6Vx-0003E2-As for emacs-devel@gnu.org; Tue, 01 Jun 2021 11:41:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ioktosN59hX34sqnqUiGFLJt+qfrSFUQAwMOfKLimsU=; b=Ni/t3Vfv1Tpydh9gDToKMCJMp6 FYOpb4I7+0YXwlr/de8E/2AWl3rAmhqkukHvCgLhchy33D/Un00ftItPBaMIrcGB8vaMN/aS1CQV4 G08tATtvkmCD1vqgsuI7WRRyyBa5olWsdsuMBh6SsncdykFOMfwsOt4hVRd8kDz/chbM=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270211 Archived-At: On 6/1/21 5:33 PM, Gregory Heytings wrote: > >>> And as I said users might want to display these annotations with their >>> own formatting, e.g. to display only some but not all of them in the >>> minibuffer. >> >> This is not a good idea in my opinion, at least for the >> `annotation-functions`. Annotations are only strings, there is not much >> formatting the user can do here. >> > > That's your opinion. Some users might want to display only the prefix, or > only the suffix, or the prefix and the suffix after the completion > candidate, or display the suffix with only one space between the candidate > and the suffix, or filter prefixes and suffixes (IOW display only some but > not all of them), and so forth. The annotation function only supports suffixes. Allowing the user to decide to display or filter the annotations is not a reasonable use case. I've written numerous commands relying on annotations/affixations and so far I've not heard this request of yours. This means that there is no wide demand for such an override feature and there is no need to offer this configuration option. But you can of course implement this in your own user configuration by overwriting the `annotation/affixation-function`. If you want to convince me, please present an example command where you want to filter/modify the annotations as a user and which modification you want to apply. If there is a reasonable use case, I am not against offering tweaking capabilities. But if it is a very special fringe use case or otherwise heavy customization, you can already use advices. You may have seen our Marginalia package? This package does exactly that, it overwrites the annotation function with a more advanced version, which shows much more data and wastes more CPU cycles ;) The question is really if we need something on the level of the user configuration or if the existing Elisp facilities suffice. Since all these overrides you have in mind are of course already possible. Daniel