From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] Wrong dependency headers for Ement v0.4 Date: Thu, 27 Oct 2022 12:46:37 -0500 Message-ID: References: <85sfjfa7v0.fsf@elpa.gnu.org> <75b04605-f880-cfd3-3ee2-48603e741fab@alphapapa.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------FN1w2WYRHGIj7eZbsgU60sGQ" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40286"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 27 19:47:42 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo6yj-000AEk-JV for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Oct 2022 19:47:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo6y4-00053x-PP; Thu, 27 Oct 2022 13:47:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo6xt-0004Mf-NG for emacs-devel@gnu.org; Thu, 27 Oct 2022 13:46:51 -0400 Original-Received: from fossa.birch.relay.mailchannels.net ([23.83.209.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo6xq-0003RC-BB for emacs-devel@gnu.org; Thu, 27 Oct 2022 13:46:49 -0400 X-Sender-Id: dreamhost|x-authsender|inbox@alphapapa.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 230118C163E; Thu, 27 Oct 2022 17:46:39 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a210 (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A736A8C1876; Thu, 27 Oct 2022 17:46:38 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1666892798; a=rsa-sha256; cv=none; b=jqV+MCd35ndPaoLMzrGSKm6yv4qeSt04eoF9ozt0yRMNU9DgtxEH8rwDmo+a7ELVzbG+fi QsqYPoYbW6a8OamfgOvGy5VeSpmxGc1j/D6OUSwlcg+buzwD6gBnI9hkVegfEEBI/uxxCW idXM0nG18szTmV6ISrrNquIVeIVw+Gs6B0PhaDIPrFLzANo+Je9DRYYaUlxO2cy+KxrBwJ sdH/uPiQ2/nC5t3zDnZdaS/8sxx+NpGbqNCDKR5X5tg2GVQr6j9VApCLOE+FjZxe3I7NUn rgqITF9HLy1MkR4swxs4CWBULOsVcz45REnyor9e8lprjDaBA3JLQh05MOdOxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1666892798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+SUJnC10V4rzOg6ka+/9Bql7Xr30knJBD+1bKG08QP8=; b=yUZwsmZRMn6SuXD4KPpDG5ftvitLjAFKifrAV9PFWSh1wL2Xzs5YX9LEJHjOh0jy94J91r GGLnckdJOk/+2qJUlsM4FHaWENKKpNUyxOCpRFGXtC43i8FpoJf21NJw9+4gk/5ap1UCLU gFcawRY0qEMrYU74fBN4dfYR/eAG1So3TNiSS6wzY1e0nrJNTUVGpOsdC0Q5B9uu/c/bew XlPCaNsxN0qdfKJwda3beohKVjW1gxGJHkvKzx3DNlZdrj81TYyaRuiokQMf918fwuedDs 05wLTi58+c77IKEXPqfZwMAE7DEAxxs4NzlWJ70zxw1L5znuwHBBTR7kcf/diw== ARC-Authentication-Results: i=1; rspamd-6955c7cd5b-q6q8p; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|inbox@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|inbox@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Interest-Tank: 15c6d73971a93197_1666892798968_2799649009 X-MC-Loop-Signature: 1666892798968:1676141616 X-MC-Ingress-Time: 1666892798967 Original-Received: from pdx1-sub0-mail-a210 (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.119.144.180 (trex/6.7.1); Thu, 27 Oct 2022 17:46:38 +0000 Original-Received: from [10.188.0.46] (unknown [193.56.117.21]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: inbox@alphapapa.net) by pdx1-sub0-mail-a210 (Postfix) with ESMTPSA id 4MytQk0Rgkz92; Thu, 27 Oct 2022 10:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1666892798; bh=+SUJnC10V4rzOg6ka+/9Bql7Xr30knJBD+1bKG08QP8=; h=Content-Type:Date:Subject:To:Cc:From; b=m2pzqfG7FFcSK2XLhoCMFFQjSJq1Q1BXnxmVGkweg0W+EbsZ88hJgDNtRi5rUy+8x F74JX3gImmtQ2z197Au5w8z2B/6QIcJGsXldHutE4u/T8k7oa+Yud5SXcut6cxTWLs +4KsgatRG0itdEfylRJe2k93PRmVdXEkXvCvKKzyjolRoG6NQjOfconaUnG6+OuiR5 RAmuMCVb4zL+x9Q0giDXARNHMzcGnzTjwZ4LpEnjpcZ745ymQWn1QIg8bUigZ1hLFx oWHX6IAp6+GgIOADcG6C7UmPz1cZGHpvhSueNJ+kLxk9djkrZjUjjvPoy0pXab0NbE ogrUsx2PXARqQ== Content-Language: en-US In-Reply-To: Received-SPF: neutral client-ip=23.83.209.62; envelope-from=adam@alphapapa.net; helo=fossa.birch.relay.mailchannels.net X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298634 Archived-At: This is a multi-part message in MIME format. --------------FN1w2WYRHGIj7eZbsgU60sGQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefan, On 10/24/22 15:51, Stefan Monnier wrote: > Hmm... this seems to clearly point to a bug in `elpa-admin.el`. > > I wonder how we end up generating a `ement-pkg.el` that contains this > Git revision id, with a `0.4` version, the correct files, but the wrong > set of requires. > > [... reading the code...] > > Hmm... it looks like we get most of the metadata for `-pkg.el` from > the HEAD before we select the actual revision from which we'll build the > tarball :-( > > This is ugly. It probably messed up several existing tarballs, actually > (just in a way sufficiently "harmless" that noone complained loudly > enough yet). Well, it's good that it was finally discovered. :) >> Aside: This is one way in which MELPA is a bit easier to work with: although >> MELPA Stable is generally not recommended for use (due to various issues), >> it builds packages from version tags rather than git master (regular MELPA >> builds from git master); if ELPA worked the same way, I could easily tag >> a v0.4.1 independently of what's on the master branch. > > We can actually do something similar currently by adding > a `:version-map` in the `elpa-packages` spec to make a release > from an arbitrary Git commit (it's better avoided but was introduced to > handle cases where the upstream doesn't have any `Version:` header, as > well as to allow building a new tarball with a different version number > in case the original build was broken for some reason, as in our case). > >> Given that, would it be possible to have ELPA build from a separate branch? >> That's how I organize some of my other packages, with a "stable" branch and >> a master branch. If ELPA pulled from a "stable" branch, I could push a fix >> to that while the next major version is still in development. > > We can also do that, yes, using the `:release-branch`. Okay, that sounds good to me. Please see the attached patch to elpa-packages, which sets the release-branch to "stable". I've already pushed such a branch to the repo, at the v0.4 commit. Will this patch cause the package to be rebuilt for v0.4, or do I need to make a v0.4.1 release to trigger that? Thanks, Adam --------------FN1w2WYRHGIj7eZbsgU60sGQ Content-Type: text/x-patch; charset=UTF-8; name="0001-elpa-packages-ement-Set-release-branch.patch" Content-Disposition: attachment; filename="0001-elpa-packages-ement-Set-release-branch.patch" Content-Transfer-Encoding: base64 RnJvbSBiMjMyMzc4YzY4YzM2NjM0YTljMjVlMTFlYzAzNWIwZDg4MjBjYmZkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFBvcnRlciA8YWRhbUBhbHBoYXBhcGEubmV0 PgpEYXRlOiBUaHUsIDI3IE9jdCAyMDIyIDEyOjQzOjA5IC0wNTAwClN1YmplY3Q6IFtQQVRD SF0gKiBlbHBhLXBhY2thZ2VzIChlbWVudCk6IFNldCA6cmVsZWFzZS1icmFuY2gKCi0tLQog ZWxwYS1wYWNrYWdlcyB8IDEgKwogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpk aWZmIC0tZ2l0IGEvZWxwYS1wYWNrYWdlcyBiL2VscGEtcGFja2FnZXMKaW5kZXggMDI0MjUz ZTVjMC4uNGQwNjNkMTc5MCAxMDA2NDQKLS0tIGEvZWxwYS1wYWNrYWdlcworKysgYi9lbHBh LXBhY2thZ2VzCkBAIC0yODYsNiArMjg2LDcgQEAKICAgOmlnbm9yZWQtZmlsZXMgKCJlbWJh cmsuZWwiICJlbWJhcmsudGV4aSIgImF2eS1lbWJhcmstY29sbGVjdC5lbCIpCiAgIDphdXRv LXN5bmMgdCkKICAoImVtZW50IgkJOnVybCAiaHR0cHM6Ly9naXRodWIuY29tL2FscGhhcGFw YS9lbWVudC5lbC5naXQiCisgIDpyZWxlYXNlLWJyYW5jaCAic3RhYmxlIgogICA6ZG9jICJS RUFETUUub3JnIgogICA6YXV0by1zeW5jIHQpCiAgKCJlbW1zIgkJOnVybCAiaHR0cHM6Ly9n aXQuc2F2YW5uYWguZ251Lm9yZy9naXQvZW1tcy5naXQiCi0tIAoyLjM0LjAKCg== --------------FN1w2WYRHGIj7eZbsgU60sGQ--