From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master 8c81818673a 6/7: Tune volatile in read_char Date: Sun, 18 Aug 2024 15:03:44 -0700 Organization: UCLA Computer Science Department Message-ID: References: <172386820621.30556.15409337288904485218@vcs2.savannah.gnu.org> <20240817041648.A6687C2BC66@vcs2.savannah.gnu.org> <87f24fac-aa71-499f-a398-2bad70a0ca42@cs.ucla.edu> <87bk1p8pfv.fsf@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3086"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Andrea Corallo , emacs-devel@gnu.org To: Sam James Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 19 00:04:50 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sfo13-0000gP-G5 for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Aug 2024 00:04:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfo0I-0008LS-T8; Sun, 18 Aug 2024 18:04:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfo0H-0008Kx-1e for emacs-devel@gnu.org; Sun, 18 Aug 2024 18:04:01 -0400 Original-Received: from mail.cs.ucla.edu ([131.179.128.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfo04-0003BA-BO; Sun, 18 Aug 2024 18:04:00 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 8AA5C3C011BDD; Sun, 18 Aug 2024 15:03:45 -0700 (PDT) Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id exd8Y9ohHxvG; Sun, 18 Aug 2024 15:03:44 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 85C933C011BDE; Sun, 18 Aug 2024 15:03:44 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 85C933C011BDE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1724018624; bh=f/WPSrWT3GIPsjS+FNjl/kD8NR2SCtndIcni/7sS0gM=; h=Message-ID:Date:MIME-Version:To:From; b=WPTKvedHFP5nYa+lMB0tj22Q5klcuaxtJuR07u9orzicpQPw53WLauD1qXm3gNo9i cFWVe4UIZGG78EXjYcFTBXhbxFqc4kdxmygc3Y6J/ezVWlPZNBhmr8tlHJQwjDieKA bR8iuIR6/OCsmipQ1gKOh6wHP9pY/nV8GBUbD2xwct4VgQ2FYQGTnXeL/BiV26k9xA PYJh4J8TwZOH5A1JrDZee0J2rT6wdLHSy5uEAQOVq8Delwp4T1ZVxU7UA+NLGjZiBr Fx+bsOCHPdY+/lgHJG0873Ss8I/bdpHoMoOK3KMwLCmHn2/KJD5+OWSU0HpKqrztOZ 5T8xgwIL+8ppA== X-Virus-Scanned: amavis at mail.cs.ucla.edu Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id SsH4Vmwb4gfE; Sun, 18 Aug 2024 15:03:44 -0700 (PDT) Original-Received: from [192.168.254.12] (unknown [47.150.137.250]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 6A1863C011BDD; Sun, 18 Aug 2024 15:03:44 -0700 (PDT) Content-Language: en-US In-Reply-To: <87bk1p8pfv.fsf@gentoo.org> Received-SPF: pass client-ip=131.179.128.66; envelope-from=eggert@cs.ucla.edu; helo=mail.cs.ucla.edu X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322906 Archived-At: On 2024-08-18 14:57, Sam James wrote: > Paul Eggert writes: > >> On 2024-08-18 00:39, Andrea Corallo wrote: >>> Has this optimization any measurable effect? >> >> On my platform (Ubuntu 24.04 LTS, x86-64, gcc -O2) it shrinks the size >> of read_char's machine code by 5%. > > Could you include that information in the commit message in future? Although I'll try to remember, to be honest I hadn't bothered to compute that number until you asked, as it was so obvious that the patch was a performance win (admittedly small). I don't always have the time to measure performance of such patches.