From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: A project-files implementation for Git projects Date: Tue, 17 Sep 2019 13:46:19 +0300 Message-ID: References: <8736h9rdc4.fsf@gnu.org> <87mufcfz1u.fsf@gnu.org> <87tv9kz2x6.fsf@gnu.org> <87a7bbjdwe.fsf@gnu.org> <87a7ba8uvx.fsf@gnu.org> <87pnk2zvvy.fsf@gnu.org> <838sqpx9eq.fsf@gnu.org> <83y2yow9dy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="267068"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 17 12:57:42 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iABAx-0017Lf-Od for ged-emacs-devel@m.gmane.org; Tue, 17 Sep 2019 12:57:39 +0200 Original-Received: from localhost ([::1]:44078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iABAw-0007C8-L1 for ged-emacs-devel@m.gmane.org; Tue, 17 Sep 2019 06:57:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48957) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAB07-0004ZG-QF for emacs-devel@gnu.org; Tue, 17 Sep 2019 06:46:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAB06-0003aw-Is for emacs-devel@gnu.org; Tue, 17 Sep 2019 06:46:27 -0400 Original-Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:35825) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iAB04-0003ZX-KA; Tue, 17 Sep 2019 06:46:25 -0400 Original-Received: by mail-lj1-x230.google.com with SMTP id m7so2301252lji.2; Tue, 17 Sep 2019 03:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8CvagcYsX8aFC3NiOOusVRJgLfCdibnTLR+KNZjW8lg=; b=mArPZnv37SVr/42pwPm1bm468MDOCSK96RLj2IvU+MTw8G0hhTT4DOc7KzjrdIDEms 4LnACXPA3BzAER6t5j8LqptYm7B86zgiPxYiMbL6BwjsPw3QMtdL9l4mEw4icZbPZnLx hHj02oheMFF64ZCBIUq+0n8rne9N5ne4OHG1uiuH+Urej3KdrpEAWiaR/nTzRgg5pIEr PGA9LDx6GbyKVqlr789ygbbogFVuYYB0r33L88v5KeouvRLBIz+hf5ekybG955OtgAmZ 1poIZO/2CslMl3+nXFI+xHr7BL63YnLYjBXdFssndavJUggq+08eH5NtpGKftndfd08k 8WFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8CvagcYsX8aFC3NiOOusVRJgLfCdibnTLR+KNZjW8lg=; b=WlAD/1UKYVeJUrWII4X8/8wJxagynpQuJ3mrautZMzECDKb/6F44LGNNrhJ9xxZwCd BgQc6mZlv6oUuPQ0hqxc3BHvRZWfRRPzi9Dn8DlWVR3bbolij54sXuMO4s95Kn70Uml2 YQ9T2hIhCom++p5ld0uIhCLbZjTnuGBhRFua1499WULUI18nnxvMbFogFtKnRkcTpb1I g3DBi2gMC1pzuUdyTq/D/y2sc6lKqd1fbpID1JZ9Ht7oz98LvAVLZYG+nDQEPE0oCk5c 3oJQVw3v6bRadMfDrBdN0m/7kCwSE2bFZYEj7oMfJsOPhjwV5mPrgHFfspgtP8qHVI8w HPwQ== X-Gm-Message-State: APjAAAWhADbXGdQC6ePRinLG0CiiX3QcsqSdx/FPEqUIMTUV5/UyceS9 Ua6x80WAjCIwBhpvQr8OqfAf/+ZQOvE= X-Google-Smtp-Source: APXvYqxZ6sX80KOTqGCdjJTSAJJak9akHN3jwzl6xzAM63owlHIj/H0/DaqdgTRo8HwAFpnk3xSbWA== X-Received: by 2002:a2e:8594:: with SMTP id b20mr1402851lji.232.1568717182308; Tue, 17 Sep 2019 03:46:22 -0700 (PDT) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id t22sm358056lfg.91.2019.09.17.03.46.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 03:46:21 -0700 (PDT) In-Reply-To: <83y2yow9dy.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240102 Archived-At: On 16.09.2019 18:25, Eli Zaretskii wrote: >> Should we sacrifice some correctness for speed? > > No, but it was never my intent to say otherwise. What is "correct" > here? E.g., 'find' will find _all_ the files, including the ignored > one -- is that "correct"? 'find' can handle an arbitrary list of ignores, including whitelisting entries (a feature which I've yet to add, but still). Not every file that's registered in a VCS should be seen as part of the project, and some of the unregistered (and gitignore-d) still should be (e.g. config files that are created by every developer individually but still should be editable by them through Emacs and project-find-file). >> If backends other than Git (and maybe Hg) can't return untracked >> files > > Which backend cannot do that? Bzr can (you just need to call it > twice), and the other two also can. So I think we have no problem > here. Tassilo said that Bzr can't, I haven't checked. There was also talk of SVN, so "the other two" might mean "the other three". >> We could make up some performance using filenotify and caching, so that >> 'find', though slower, would at least be called infrequently. > > That's over-engineering, I think. Really? Consider: we have to maintain the find-based approach anyway since not everyone uses Git/Hg/Bzr. And the filenotify-based cache would do one job. Conceptually, at least, it should be simpler than coercing several VC systems into doing the job of 'find' with ignore/whitelist entries not exactly matching VCS's view of the repository.