From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: master ca47390: image-dired: Report when a necessary executable is not found Date: Mon, 5 Sep 2016 11:48:15 -0400 Message-ID: References: <20160904134431.30494.94659@vcs.savannah.gnu.org> <20160904134431.7513F220140@vcs.savannah.gnu.org> <9ba96760-15da-e7f5-a4e5-4a93ecd49f7a@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rJp6oFDGjMmiMvR4oE9HPaLsQNhmWgTbx" X-Trace: blaine.gmane.org 1473090618 28394 195.159.176.226 (5 Sep 2016 15:50:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Sep 2016 15:50:18 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 Cc: Emacs developers To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 05 17:50:12 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgw9t-0006E7-Fk for ged-emacs-devel@m.gmane.org; Mon, 05 Sep 2016 17:50:05 +0200 Original-Received: from localhost ([::1]:55497 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgw9r-0007KG-AS for ged-emacs-devel@m.gmane.org; Mon, 05 Sep 2016 11:50:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgw8L-0006o2-IZ for emacs-devel@gnu.org; Mon, 05 Sep 2016 11:48:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgw8G-0002Qk-OM for emacs-devel@gnu.org; Mon, 05 Sep 2016 11:48:28 -0400 Original-Received: from mout.kundenserver.de ([212.227.17.13]:50309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgw8G-0002Qe-Du for emacs-devel@gnu.org; Mon, 05 Sep 2016 11:48:24 -0400 Original-Received: from [18.189.118.169] ([18.189.118.169]) by mrelayeu.kundenserver.de (mreue104) with ESMTPSA (Nemesis) id 0MgNZW-1bTF0C3Hk6-00NftJ; Mon, 05 Sep 2016 17:48:22 +0200 In-Reply-To: X-Provags-ID: V03:K0:ygTSAb/wsClMZHBhimMkygdVAvAziJLF1J8Bt/sU4RxkMOLv44G y7aVLCyHF73+NkCbh+HUxi/6glKQUoN1ks4h1f9GsUs0l0vA2+IQd3pRUUpXJZ3fRmTmvD6 rc/K01oYYZHWuyQTSlw5sEGJUlhhOjUO/mHCGT/EEfS0GmejEOwqH5fgHtpEfFA04a+NjEn E3q8BIcaVY/3bAcTdpuDw== X-UI-Out-Filterresults: notjunk:1;V01:K0:KtwNR4KFCjM=:Q3zFHgkprm+AvB5Zs7GNWw 4RbR3JZXqnRBHGsOPletANhp4iATwavRG35DSvvKVOxklzI2yE39p40xtQRqHdpmaKLV6Vb8M HVxgy9t8fFXq1+2+ECFgQtsREbTyaGErWWZqiXcZ3oO+ujClihu666EnwCIrh3cPMZ+2BbFtl SxYx2vWgqBWlNb9TR3WnWHyuvD8vNIwux3jt5qE3D8Oqh4hqUWhdAfiD/6TYH+hjiuIfyqqIJ PUnjfb2q/nPWpkcVpezkGbJzq4CxVJT8klNqQBJf6XjS/LCTHY4bbegg/JfCDHxyKaLDK2Nxk PpK7mD2RGTb22QNHrUz6FoXSs9RZBJ78JMJr8Fg6C9n7Si+WWF1E56vV/vESbBQonCJ+ZTu2/ PLaXqD/SGDzfQWd4tLfTlk1CspUwpYNw27CpiKdNLzrWoFTlHKUnElMn3Wid39FR54xVegqEd +KpEuVPCfO1wi3NCP+rdefta+ikZ1h154qQLJA9Zz2vdTC/5mI0sBwyQsUdZliIKfMsfgoFp0 KKiBaf0BcS/TQQBj19nNPPR6XdDY2xSmpe/WWq5DVkewesjCOxAMzlskUdr8KgVDyNcrH+SyZ YkD61+bY2Y/9jPwodOZlZHuSTwcXgphMGgVwRQecUB7KaJ4Hx1o8Vu1sfmJI7DAohXuQp0aR8 efIxYVQj/grpoJ6mzjPaeotUgtMcmPQmznqMGlQUe9SXLskk4+A5kAo/dscUX6yzlS5A= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.13 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207197 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rJp6oFDGjMmiMvR4oE9HPaLsQNhmWgTbx Content-Type: multipart/mixed; boundary="FmHvOi8lvuEcgg5GKQwv4IOSn8osonOGh"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: Tino Calancha Cc: Emacs developers Message-ID: Subject: Re: master ca47390: image-dired: Report when a necessary executable is not found References: <20160904134431.30494.94659@vcs.savannah.gnu.org> <20160904134431.7513F220140@vcs.savannah.gnu.org> <9ba96760-15da-e7f5-a4e5-4a93ecd49f7a@gmail.com> In-Reply-To: --FmHvOi8lvuEcgg5GKQwv4IOSn8osonOGh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-09-05 01:30, Tino Calancha wrote: > Good point. I agree is a nuisance having to set those values > after installing the executable. > How about following more simple patch?: > It just check for the required executable at the top of each function > using it; it signals an error if the executable is not found: Looks good, but maybe you could extract this to a separate function that = takes the variable name and produces the error? There's a bit of duplica= tion in the patch you posted. --FmHvOi8lvuEcgg5GKQwv4IOSn8osonOGh-- --rJp6oFDGjMmiMvR4oE9HPaLsQNhmWgTbx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXzZPFAAoJEPqg+cTm90wjwfoQAJdW0JOyCaTbmhwFJm4XvkCb mSpy8D/0zLqYjMSx5FzM3soqzBM2KRc5ZX9NijWvpUlpC19oHlPgJjP7x8Nclegz rL7pWhK8gRPJJUkCwi0+9g5b9Jd2bEZwNlUofpqj+EPSVqt0I6ErvH4g3F/WCtIY W4TCNFF8PK02sdCcxsfGGDEykrUYKEyBvWkLoN0OFvvPXlKMUP6qkzW99q1aozUL yVQ9ga2JGtozaaHXEe93t8w8j7ax3HTTU30QQ0QLuE20pI/j3TK60Jks8f8Skcpf Evsmpe59FFOGk2KzOA80l9zQW//7QnQNZ2N4geEVp7m1GXYGXtZKOeO/KGFxDHJY XM12ATsX4F7J1qqOwegwPrTIZ5CqhvFDXLHbhNGB9g9v7aA9Am3gW8I7Ql8nedo6 wnzBreTCvN6YX3cNsCpvbS46P2eTElz42x5nH13P4NP5uj889rQAEHMxcdByZv/e 22ShKkBcBfU9Mwufz2DK1HNyC0YMCvaRHgdrD7qa9HxOY8uRsk19bQ1vmZZw9Okz j1k2qDRRkDmQ5QWzl5Q17E1n/KNjLhF5ikhlNK+EOdIMsE4Hi3FrSIsP2sMdMlpE QHfCMV6rShPg3Z2lR+a4QtUXszUKX6OdcN0KdLA+1XS8zAE1ARCyAfuK0jhrz8sB 2ONzHAzA9DDncnz7R3vc =9VPW -----END PGP SIGNATURE----- --rJp6oFDGjMmiMvR4oE9HPaLsQNhmWgTbx--