From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Daniel Colascione" Newsgroups: gmane.emacs.devel Subject: Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow Date: Mon, 24 Jun 2019 11:12:27 -0700 Message-ID: References: <183863e3-f4e3-4e31-a557-62ac98ce77aa@email.android.com> <83d0j2nbhx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="10862"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: SquirrelMail/1.4.23 [SVN] Cc: dancol@dancol.org, andrewjmoreton@gmail.com, emacs-devel@gnu.org To: "Eli Zaretskii" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 24 20:15:19 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfTUs-0002iK-HZ for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 20:15:19 +0200 Original-Received: from localhost ([::1]:53682 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfTUr-0001LE-Cb for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 14:15:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58099) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfTSG-0000NB-9y for emacs-devel@gnu.org; Mon, 24 Jun 2019 14:12:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfTSF-0006pd-4z for emacs-devel@gnu.org; Mon, 24 Jun 2019 14:12:36 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:40926) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfTSA-0006h5-I3; Mon, 24 Jun 2019 14:12:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=80Bsm0vspEF/0U+URYeyv7LrLStPK3k3xUt0VMLYApE=; b=LaXFnqbeDxrjQ6OWJIAhqeCzii4ed/W3aLuT3IFqaHDRHVAt47EOr3/OoNtxHYsj3byNRGio+ReLB/hmBMaN+lQFnYSqkHQUN2uw2rHHdalSlWz/RGhL2NkOcIbBhaBmf9Ofx1p1okGSAh50tIu3TIFf6EC3WTex7GaNayAtuX8cUlXM3pL7EDISJxszfglZnJzZsv9YeOLTahElPgsdGwVppGgeuG/aOowxRe6chXE9/58cNXLoTwu9RKB4ecux3WZ+FWscUChCbBPM50yWSQt8KmRD0XpBYOfBLEMsDAYhJYip2DfU3UTBhy24DoJaceqlMuSiKGxuEReKeJ5wWA==; Original-Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfTS7-0001VK-Jf; Mon, 24 Jun 2019 11:12:27 -0700 Original-Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Mon, 24 Jun 2019 11:12:27 -0700 In-Reply-To: <83d0j2nbhx.fsf@gnu.org> X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238111 Archived-At: >> Date: Mon, 24 Jun 2019 09:06:37 -0700 >> From: dancol@dancol.org >> Cc: Andy Moreton , emacs-devel@gnu.org >> >> > Building commit 65d45def8d71e50d111adf1141011a5d30a27447 still fails >> on >> > MSYS2 (Windows), and adds warnings: >> >> I'm working on this. >> >> Thanks. I thought gnulib was supposed to "just work" here. > > It mostly does, but not in this case, evidently. And even if it did, > we cannot use in Emacs Gnulib modules that manipulate file names, > because Gnulib on Windows supports only file names encodable in the > current ANSI codepage, whereas Emacs supports the full Unicode. Also, > in this case there are two more problems: (1) canonicalize-lgpl.c > doesn't support symlinks on Windows, and (2) it uses 'stat', which we > replaced in Emacs by our own enhanced implementation. So there are > more than enough reasons for this changeset to require additional work > on Windows ;-) Ah, I didn't look all that closely at the Gnulib implementation: I was under the impression that it was supposed to be more generally portable. It has other questionable behavior: for example, the findprog Gnulib module is a no-op on Cygwin even though the search path logic there is the same as it is on other platforms. > Thanks for fixing this issue on Posix platforms. Did you close the > bug which Richard opened about this? I will.