From: "Daniel Colascione" <dancol@dancol.org>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: dancol@dancol.org, andrewjmoreton@gmail.com, emacs-devel@gnu.org
Subject: Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow
Date: Mon, 24 Jun 2019 11:12:27 -0700 [thread overview]
Message-ID: <e7145945f93d1701648ac853d8730bf7.squirrel@dancol.org> (raw)
In-Reply-To: <83d0j2nbhx.fsf@gnu.org>
>> Date: Mon, 24 Jun 2019 09:06:37 -0700
>> From: dancol@dancol.org
>> Cc: Andy Moreton <andrewjmoreton@gmail.com>, emacs-devel@gnu.org
>>
>> > Building commit 65d45def8d71e50d111adf1141011a5d30a27447 still fails
>> on
>> > MSYS2 (Windows), and adds warnings:
>>
>> I'm working on this.
>>
>> Thanks. I thought gnulib was supposed to "just work" here.
>
> It mostly does, but not in this case, evidently. And even if it did,
> we cannot use in Emacs Gnulib modules that manipulate file names,
> because Gnulib on Windows supports only file names encodable in the
> current ANSI codepage, whereas Emacs supports the full Unicode. Also,
> in this case there are two more problems: (1) canonicalize-lgpl.c
> doesn't support symlinks on Windows, and (2) it uses 'stat', which we
> replaced in Emacs by our own enhanced implementation. So there are
> more than enough reasons for this changeset to require additional work
> on Windows ;-)
Ah, I didn't look all that closely at the Gnulib implementation: I was
under the impression that it was supposed to be more generally portable.
It has other questionable behavior: for example, the findprog Gnulib
module is a no-op on Cygwin even though the search path logic there is the
same as it is on other platforms.
> Thanks for fixing this issue on Posix platforms. Did you close the
> bug which Richard opened about this?
I will.
next prev parent reply other threads:[~2019-06-24 18:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 10:26 master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow Yuri D'Elia
2019-06-24 11:10 ` Ergus
2019-06-24 11:57 ` Yuri Khan
2019-06-24 12:28 ` Ergus
2019-06-24 13:21 ` Daniel Colascione
2019-06-24 13:50 ` Ergus
2019-06-24 13:54 ` Daniel Colascione
2019-06-24 14:05 ` Ergus
2019-06-24 14:19 ` Ergus
2019-06-24 14:14 ` Andy Moreton
2019-06-24 14:52 ` Eli Zaretskii
2019-06-24 16:06 ` dancol
2019-06-24 17:23 ` Eli Zaretskii
2019-06-24 18:12 ` Daniel Colascione [this message]
2019-06-24 18:25 ` Eli Zaretskii
2019-06-24 17:12 ` Eli Zaretskii
2019-06-24 18:26 ` Andy Moreton
2019-06-24 18:44 ` Eli Zaretskii
2019-06-26 16:26 ` Eli Zaretskii
2019-06-26 16:58 ` Eli Zaretskii
2019-06-27 17:45 ` Ken Brown
2019-06-27 18:36 ` Eli Zaretskii
2019-06-27 19:56 ` Ken Brown
2019-06-24 15:01 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7145945f93d1701648ac853d8730bf7.squirrel@dancol.org \
--to=dancol@dancol.org \
--cc=andrewjmoreton@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).