From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 17:38:27 +0300 Message-ID: References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16802"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: eliz@gnu.org, larsi@gnus.org, juri@jurta.org, emacs-devel@gnu.org To: "Alfred M. Szmidt" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 16:39:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT2P3-0004HP-FK for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 16:39:45 +0200 Original-Received: from localhost ([::1]:52520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT2P2-0001Tu-FB for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 10:39:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT2ON-0000p9-NZ for emacs-devel@gnu.org; Tue, 30 Aug 2022 10:39:03 -0400 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:33561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oT2OL-0007GI-Et; Tue, 30 Aug 2022 10:39:03 -0400 Original-Received: by mail-wr1-x436.google.com with SMTP id k9so14557413wri.0; Tue, 30 Aug 2022 07:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc; bh=9n1v48DZnVZdFzaqYagb8zF3gCQSodi5ytHkVU/KyhA=; b=HRTpg+JA57NQjFhF12VIXIb3/W3fAuABPLfqI7FcMc/UoscJN+3Qb13eqI1y2RJ1nh PMMkL39ITWnT8aznA+i1faOL2ixdlTeZd/ZSjPASE6ad1b61MqHIVa61wzvp9wIoBKwc qvjCONkmrobcD5sc2kC7cP2Hn6YcL9hxV1TVODA7ujTfpaP6ZPptdVBw2I8tMO6hyEdp qi76ZevVE89nucQ9NKRDOkAomkZRzEEL6GFnz68PiPqjGungCZoD4JJGbn2j1jJ2J73/ vpc/9Rw94gjVksjbTyPfB4dKSJXnRC+0r0Z1/K6gybp3gIu8rZL/UdxySzABHFiENJd/ NL6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc; bh=9n1v48DZnVZdFzaqYagb8zF3gCQSodi5ytHkVU/KyhA=; b=TIoyOdbx7VC91ZwCzAU6DqifyjUZd/kT0CFFoph0o2iwHZ0tYCt+u+WCJShVGA/mQg F9bu9Qwz9pbTYCBbm+V7ujaNWAPEsp5cd24thHqPHHmZV0+rnGqRilB1FBIAylmddVmg F3crskwXHwYsf6+QgxeTj25pCvjGLguMzTqYqz8D7LmBJ85O1xcfzUQAUgzlZVKVqIey oXCKO97CTCBuPvzJIVKhZNgaxQYJIy/5S2e2qp/yZtYd5vVe3NPZ/1posMTSE80bu8sd pewE/uAAFnoK6DDzX6/xJoNiVmjkkCBXVMoaFszAZZEjCp00lneLjuATCG8rrY/Dpp0V YELQ== X-Gm-Message-State: ACgBeo3hJSIu+6kLMdhr4WfmTlWc2h61pTZXM4i5oe/7B6VLcYTTN/lN JxS1uIK1iblGFndogiYKbqQ25Tj3c7I= X-Google-Smtp-Source: AA6agR7uuswy4q07LU2N+OjzdLeYG6iRDmBAXvzXrakhEbLGTuKhbQz9wre7EBPD8mQM4XRl+ntnag== X-Received: by 2002:a5d:6d86:0:b0:226:e362:237d with SMTP id l6-20020a5d6d86000000b00226e362237dmr2130786wrs.453.1661870309531; Tue, 30 Aug 2022 07:38:29 -0700 (PDT) Original-Received: from [192.168.0.215] (buscust41-118.static.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id z1-20020a05600c0a0100b003a1980d55c4sm14519187wmp.47.2022.08.30.07.38.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 07:38:29 -0700 (PDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=raaahh@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294348 Archived-At: On 30.08.2022 17:20, Alfred M. Szmidt wrote: > On 30.08.2022 16:25, Alfred M. Szmidt wrote: > > This is a pitty indeed. Specially seeing that it is easy enough to > > get this working for all VCSs. Here is a hack I wrote ages ago, and > > this works for just about everything, it doesn't do exactly what is > > needed (e.g, this works on a single file basis) but it isn't too hard > > to get that working. > > This indeed could work as an approach (I suggested /tmp, you are using a > single buffer to back up contents, but the effect should be the same). > > Yup, a temp file would make it work for multiple files. > > Do you like the current behavior with Git, though? Or do you perhaps > have the same misgivings as Eli? > > I've not tried Juri's change, but from the point of maintaining > vc-fossil it would mean that I need to figure out how to implement > this vc-checkin-patch function (and likewise for anyone else), > specially when there is no need to make this git specific for the most > common case. I can look into adapting this approach for other VCS if nobody beats me to it. As long as we fundamentally agree on the behavior.