From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Harald_J=c3=b6rg?= Newsgroups: gmane.emacs.devel Subject: Re: Re-vitalizing cperl-mode Date: Thu, 2 Jul 2020 16:56:07 +0200 Message-ID: References: <7e274cb1-dfeb-6d04-0ffc-892f55eba659@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22410"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 02 16:56:59 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jr0e3-0005gL-Fn for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Jul 2020 16:56:59 +0200 Original-Received: from localhost ([::1]:39276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jr0e2-0006Ab-If for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Jul 2020 10:56:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jr0dK-0005id-2R for emacs-devel@gnu.org; Thu, 02 Jul 2020 10:56:14 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:34499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jr0dH-00060y-9Z for emacs-devel@gnu.org; Thu, 02 Jul 2020 10:56:13 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 0B8652400FE for ; Thu, 2 Jul 2020 16:56:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1593701769; bh=bk4fkvQ1hicjFDIctzrvmZsiw36HzwDW7VkFZma3qm8=; h=Subject:To:Cc:From:Autocrypt:Date:From; b=WkM+G8fdALPKsWlKnQ6pTLDNeQ1pRPqzZXDa8mwq/xyxMowHBGYxJJvIE4ImQqIQo kXEB74kLhbXCGE/Tbr9n8rYNj2ENncRqWHYltWBarBbUhXgp07MNwyL75IcfsL4gEs xaaCWcbZNIfC4zTnVyWglJqQBz7Y3GEO9WGmHRk/a2xgt1DZ7M0f+WASMDMJCj3d6i VuUPACIRcKNlZtlag02KWcMC2MsCCwlEINSsV3a4e3ouop/8Icigebjm5xlufkeEbm 8gsprRn95Z2g+S+/PlzO+fOrTDV1xwVwru8bZtonN8Iem7yh4pRqlwJ0rZ+I4TDdx/ oX/FpgRK6oRZA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49yLkw1xqRz6tmm; Thu, 2 Jul 2020 16:56:08 +0200 (CEST) Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=185.67.36.66; envelope-from=haj@posteo.de; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/02 10:28:26 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252630 Archived-At: Hello Stefan, >> Emacs comes with cperl-mode, a major mode to edit Perl programs. > > As well as `perl-mode`, indeed. I know, but as far as I recall I've never used perl-mode. >> However, Perl is evolving... and I noticed that cperl-mode isn't >> developed accordingly. > > Indeed, neither `perl-mode` nor `cperl-mode` are getting much love > these days. Oh, they do get love. From their users. Their code doesn't, though :) >> Should I just keep the status quo - and the Emacs dev team will decide >> whether, and which of my changes you will adopt into the next Emacs >> release? > > Much better would be for you to step up as maintainer of the package: > it's likely that in many cases the "Emacs dev team" wouldn't really have > the resources or expertise to judge such changes. That might be an option, yes. > We can give guidance and feedback on the quality of the Elisp code, of > course. This is highly appreciated! >> Would it be an option to give cperl-mode a "dual life" in Emacs and in >> (M)ELPA? > > Yes, we could easily distribute emacs.git's ` cperl-mode.el` as a GNU > ELPA package as well (like we already do for python.el and a bunch of > others). > >> In any case: What rules / conventions / tools and frameworks should I >> obey to make my changes palatable for Emacs and/or (M)ELPA? > > Since `cperl-mode.el` is distributed with Emacs, its better to try and > obey the conventions used for Emacs's own Elisp code. > > Adding test cases under emacs.git/test would be a great contribution > as well (there's currently a very limited set of testcases in > test/manual/indent/perl.perl). Indeed, limited... It also seems to exercise some interesting border cases of fontification. But manual tests are not very pleasant. > The main rule there is that code's copyright needs to be assigned to > the FSF. I'll contact you off-list for that. Thanks! > PS: BTW, I assume you're familiar with https://github.com/jrockway/cperl-mode? Yes, I am aware. It seems that Emacs incorporated changes from this repo, but the cleanups done in the Emacs version weren't merged back. In short: Jonathan Rockway added stuff for Perl 5.10 and two modules which bring their own keywords. I want to go up to 5.32 and beyond, and have a mechanism to support _any_ module which adds their own keywords. -- Cheers, haj