From: "Harald Jörg" <haj@posteo.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Re-vitalizing cperl-mode
Date: Thu, 2 Jul 2020 16:56:07 +0200 [thread overview]
Message-ID: <e5c0726c-9a7a-4a68-7aeb-cc076eb37b08@posteo.de> (raw)
In-Reply-To: <jwv8sg2vyhz.fsf-monnier+emacs@gnu.org>
Hello Stefan,
>> Emacs comes with cperl-mode, a major mode to edit Perl programs.
>
> As well as `perl-mode`, indeed.
I know, but as far as I recall I've never used perl-mode.
>> However, Perl is evolving... and I noticed that cperl-mode isn't
>> developed accordingly.
>
> Indeed, neither `perl-mode` nor `cperl-mode` are getting much love
> these days.
Oh, they do get love. From their users. Their code doesn't, though :)
>> Should I just keep the status quo - and the Emacs dev team will decide
>> whether, and which of my changes you will adopt into the next Emacs
>> release?
>
> Much better would be for you to step up as maintainer of the package:
> it's likely that in many cases the "Emacs dev team" wouldn't really have
> the resources or expertise to judge such changes.
That might be an option, yes.
> We can give guidance and feedback on the quality of the Elisp code, of
> course.
This is highly appreciated!
>> Would it be an option to give cperl-mode a "dual life" in Emacs and in
>> (M)ELPA?
>
> Yes, we could easily distribute emacs.git's ` cperl-mode.el` as a GNU
> ELPA package as well (like we already do for python.el and a bunch of
> others).
>
>> In any case: What rules / conventions / tools and frameworks should I
>> obey to make my changes palatable for Emacs and/or (M)ELPA?
>
> Since `cperl-mode.el` is distributed with Emacs, its better to try and
> obey the conventions used for Emacs's own Elisp code.
>
> Adding test cases under emacs.git/test would be a great contribution
> as well (there's currently a very limited set of testcases in
> test/manual/indent/perl.perl).
Indeed, limited... It also seems to exercise some interesting border
cases of fontification. But manual tests are not very pleasant.
> The main rule there is that code's copyright needs to be assigned to
> the FSF. I'll contact you off-list for that.
Thanks!
> PS: BTW, I assume you're familiar with https://github.com/jrockway/cperl-mode?
Yes, I am aware. It seems that Emacs incorporated changes from this
repo, but the cleanups done in the Emacs version weren't merged back.
In short: Jonathan Rockway added stuff for Perl 5.10 and two modules
which bring their own keywords. I want to go up to 5.32 and beyond,
and have a mechanism to support _any_ module which adds their own
keywords.
--
Cheers,
haj
prev parent reply other threads:[~2020-07-02 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 11:34 Re-vitalizing cperl-mode Harald Jörg
2020-07-02 13:26 ` Eli Zaretskii
2020-07-02 14:28 ` Harald Jörg
2020-07-02 13:40 ` Stefan Monnier
2020-07-02 14:56 ` Harald Jörg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5c0726c-9a7a-4a68-7aeb-cc076eb37b08@posteo.de \
--to=haj@posteo.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).